fix(deps): update dependency apexcharts to ^5.15.2#72
Merged
Conversation
f642562 to
67f6a1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^5.15.0→^5.15.2Release Notes
apexcharts/apexcharts.js (apexcharts)
v5.15.2: 💎 Version 5.15.2Compare Source
Fixes
Draw-animation frame no longer touches a destroyed chart
An animated chart (e.g. an
areachart) schedules arequestAnimationFrameduringrender()to run its mask-reveal / draw animation. If the chart was destroyed before that frame fired, the stale callback ran against already-cleared DOM and threw:The classic trigger is React StrictMode, which mounts → unmounts → remounts a component in development: the first mount queues the animation frame, the unmount calls
destroy()(which nullsw.dom.elDefs), and the queued frame then fires against the torn-down chart. Any sufficiently rapid unmount hit the same race.The fix adds an internal
isDestroyedflag, set bydestroy()(but not by updates), that the deferred draw-animation callbacks - mask reveal, stroke draw, and bulk reveal - check and bail on before touching the DOM. The flag is cleared on the next render, so re-mounting re-arms animations normally.This complements the detached-chart
destroy()fix in 5.15.1; together they resolve the teardown crashes tracked in react-apexcharts#602.v5.15.1: 💎 Version 5.15.1Compare Source
A small patch release with a single stability fix: charts that are torn down before they ever mount no longer throw.
Fixes
destroy()no longer throws on an un-mounted / detached chartCalling
destroy()(or an internalclear()) on a chart that never finished rendering threw:This happened when a chart was constructed against an element that wasn't connected to the DOM - so
create()bailed out early before building the SVG, leavingw.dom.Paperundefined - and the chart was then destroyed. Common triggers:useEffectcleanup (or a Vueunmountedhook) tearing the chart down before the element was ever attached.update()firing after the host element had already been removed.The teardown path now guards on the SVG actually having been created, cancels any pending resize redraw, and tolerates a missing
Apex._chartInstancesregistry, so destroying a never-mounted chart is a safe no-op.Fixes react-apexcharts#602 and vue-apexcharts#256.
Configuration
📅 Schedule: (in timezone Europe/Rome)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.