IBX-11553: Made http-cache response taggers more specialized

features/setup/symfonyCache.feature

@@ -19,20 +19,20 @@ index 9982c21..03ac40a 100644
 +++ b/public/index.php
 @@ -1,9 +1,14 @@
  <?php
- 
+
  use App\Kernel;
 +use Ibexa\Bundle\HttpCache\AppCache;
 +use Symfony\Component\HttpFoundation\Request;
- 
+
  require_once dirname(__DIR__).'/vendor/autoload_runtime.php';
- 
- return function (array $context) {
+
+ return static function (array $context) {
 -    return new Kernel($context['APP_ENV'], (bool) $context['APP_DEBUG']);
 +    $kernel = new Kernel($context['APP_ENV'], (bool) $context['APP_DEBUG']);
 +    Request::enableHttpMethodParameterOverride();
 +
 +    return new AppCache($kernel);
  };
--- 
+--
 2.30.0
 """

phpstan-baseline.neon

@@ -606,132 +606,6 @@ parameters:
 			count: 1
 			path: spec/ResponseConfigurator/ConfigurableResponseCacheConfiguratorSpec.php
 
-		-
-			message: '#^Call to an undefined method Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Content\:\:willReturn\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Delegator/ContentValueViewTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method spec\\Ibexa\\HttpCache\\ResponseTagger\\Delegator\\ContentValueViewTaggerSpec\:\:tag\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Delegator/ContentValueViewTaggerSpec.php
-
-		-
-			message: '#^Class spec\\Ibexa\\HttpCache\\ResponseTagger\\Delegator\\ContentValueViewTaggerSpec extends generic class PhpSpec\\ObjectBehavior but does not specify its types\: TKey, TValue$#'
-			identifier: missingType.generics
-			count: 1
-			path: spec/ResponseTagger/Delegator/ContentValueViewTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method spec\\Ibexa\\HttpCache\\ResponseTagger\\Delegator\\DispatcherTaggerSpec\:\:tag\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Delegator/DispatcherTaggerSpec.php
-
-		-
-			message: '#^Class spec\\Ibexa\\HttpCache\\ResponseTagger\\Delegator\\DispatcherTaggerSpec extends generic class PhpSpec\\ObjectBehavior but does not specify its types\: TKey, TValue$#'
-			identifier: missingType.generics
-			count: 1
-			path: spec/ResponseTagger/Delegator/DispatcherTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Location\:\:willReturn\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Delegator/LocationValueViewTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method spec\\Ibexa\\HttpCache\\ResponseTagger\\Delegator\\LocationValueViewTaggerSpec\:\:tag\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Delegator/LocationValueViewTaggerSpec.php
-
-		-
-			message: '#^Class spec\\Ibexa\\HttpCache\\ResponseTagger\\Delegator\\LocationValueViewTaggerSpec extends generic class PhpSpec\\ObjectBehavior but does not specify its types\: TKey, TValue$#'
-			identifier: missingType.generics
-			count: 1
-			path: spec/ResponseTagger/Delegator/LocationValueViewTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method FOS\\HttpCache\\ResponseTagger\:\:shouldHaveBeenCalled\(\)\.$#'
-			identifier: method.notFound
-			count: 2
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method FOS\\HttpCache\\ResponseTagger\:\:shouldNotHaveBeenCalled\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method FOS\\HttpCache\\ResponseTagger\:\:willReturn\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\ContentInfoTaggerSpec\:\:tag\(\)\.$#'
-			identifier: method.notFound
-			count: 3
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Class spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\ContentInfoTaggerSpec extends generic class PhpSpec\\ObjectBehavior but does not specify its types\: TKey, TValue$#'
-			identifier: missingType.generics
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Method FOS\\HttpCache\\ResponseTagger\:\:addTags\(\) invoked with 0 parameters, 1 required\.$#'
-			identifier: arguments.count
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Parameter \#1 \$tags of method FOS\\HttpCache\\ResponseTagger\:\:addTags\(\) expects array\<string\>, Prophecy\\Argument\\Token\\AnyValueToken given\.$#'
-			identifier: argument.type
-			count: 1
-			path: spec/ResponseTagger/Value/ContentInfoTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method FOS\\HttpCache\\ResponseTagger\:\:shouldHaveBeenCalled\(\)\.$#'
-			identifier: method.notFound
-			count: 3
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method FOS\\HttpCache\\ResponseTagger\:\:shouldNotHaveBeenCalled\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method FOS\\HttpCache\\ResponseTagger\:\:willReturn\(\)\.$#'
-			identifier: method.notFound
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Call to an undefined method spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\LocationTaggerSpec\:\:tag\(\)\.$#'
-			identifier: method.notFound
-			count: 4
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Class spec\\Ibexa\\HttpCache\\ResponseTagger\\Value\\LocationTaggerSpec extends generic class PhpSpec\\ObjectBehavior but does not specify its types\: TKey, TValue$#'
-			identifier: missingType.generics
-			count: 1
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
-		-
-			message: '#^Parameter \#1 \$tags of method FOS\\HttpCache\\ResponseTagger\:\:addTags\(\) expects array\<string\>, Prophecy\\Argument\\Token\\AnyValueToken given\.$#'
-			identifier: argument.type
-			count: 2
-			path: spec/ResponseTagger/Value/LocationTaggerSpec.php
-
 		-
 			message: '#^Call to an undefined method Symfony\\Component\\HttpKernel\\HttpKernelInterface\:\:isDebug\(\)\.$#'
 			identifier: method.notFound
@@ -1122,24 +996,6 @@ parameters:
 			count: 1
 			path: src/lib/ResponseTagger/Delegator/ContentValueViewTagger.php
 
-		-
-			message: '#^Method Ibexa\\HttpCache\\ResponseTagger\\Delegator\\DispatcherTagger\:\:__construct\(\) has parameter \$taggers with no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/lib/ResponseTagger/Delegator/DispatcherTagger.php
-
-		-
-			message: '#^PHPDoc tag @var for property Ibexa\\HttpCache\\ResponseTagger\\Delegator\\DispatcherTagger\:\:\$taggers with type Ibexa\\Contracts\\HttpCache\\ResponseTagger\\ResponseTagger is incompatible with native type array\.$#'
-			identifier: property.phpDocType
-			count: 1
-			path: src/lib/ResponseTagger/Delegator/DispatcherTagger.php
-
-		-
-			message: '#^Property Ibexa\\HttpCache\\ResponseTagger\\Delegator\\DispatcherTagger\:\:\$taggers type has no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/lib/ResponseTagger/Delegator/DispatcherTagger.php
-
 		-
 			message: '#^Method Ibexa\\HttpCache\\ResponseTagger\\Delegator\\LocationValueViewTagger\:\:tag\(\) has no return type specified\.$#'
 			identifier: missingType.return