Repository navigation
ci: backport #12088 - size report against the build's base, keep newest baselines - #12151
Merged
sensei-hacker merged 2 commits intoOct 14, 2026
Conversation
CI builds refs/pull/<n>/merge, the base branch as it stood when the run started plus the PR, but the size report compared that build with the merge-base, so every change merged to the base since the PR forked was reported as the PR's own. ci.yml now records the merge's first parent in the base-ref artifact, only when HEAD is that merge, and the size report uses it; builds made before that fall back to the merge-base as before. When only a nearer ancestor has a baseline, the comment names both commits, so the reader knows what the delta also covers. (cherry picked from commit 184e8e2)
Pruning sorted the per-commit baselines by created_at, which GitHub sets to the date of the commit a release's tag points to. Every tag in pr-test-builds points to the same commit, so all the baselines share one created_at and the sort fell back to the tag, that is to the SHA. With maintenance-10.x at its 50, a new baseline whose SHA sorted below the lowest kept one was deleted right after being published. Sort by published_at, and test the order with the created_at GitHub reports. (cherry picked from commit f5217c2)
Contributor
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
RAM / Flash usage vs. base commit
See RAM/flash optimization guide for techniques to reduce usage. |
|
Test firmware build ready — commit Download firmware for PR #12151 245 targets built. Find your board's
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12088 (MrScothh) to release/9.1. Both commits are cherry-picked with
-xand keep their original authorship; they applied without conflicts.ci.yml/ci-size-report.yml: compare a PR's sizes against the base commit its build contains, not the merge-base.publish-size-baseline.sh: prune size baselines bypublished_atinstead ofcreated_at, so a new baseline is not deleted right after publishing.Depends on #11835, which is already on release/9.1. Since release/9.1 merges forward into maintenance-10.x, this is expected to supersede #12088 there.
Tested:
publish-size-baseline.test.sh,size-diff-comment.test.js(31/31) andcompute-region-sizes.test.pyall pass; both workflows parse as valid YAML. The workflow behavior itself can only be exercised by CI on this PR.https://claude.ai/code/session_013M19brPP7i2M6LA84AWLgB