Remove orphaned servo_autotrim_iterm_threshold field - #11800
Remove orphaned servo_autotrim_iterm_threshold field#11800sensei-hacker wants to merge 1 commit into
Conversation
Field had no settings.yaml entry, no reset initializer, and no code references anywhere in the tree.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
PR Summary by QodoRemove orphaned servo autotrim threshold field
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent |
|
RAM / Flash usage vs. base branch — commit
See RAM/flash optimization guide for techniques to reduce usage. |
|
Test firmware build ready — commit Download firmware for PR #11800 244 targets built. Find your board's
|
The Release job (nightly upload to iNavFlight/inav-nightly) can fail for reasons unrelated to the build itself and drags the whole run's conclusion to failure even when the build succeeded and produced the size-report/branch-name artifacts. Confirmed live: the 2026-08-20 push to release/9.1 had every build job succeed but Release fail with "Bad credentials" (NIGHTLY_TOKEN), so publish-baseline never ran and no baseline has ever been published — which is why PR iNavFlight#11800 still shows "No size baseline is available yet". Check the specific build/upload-artifacts job's conclusion instead of the aggregate run conclusion.
The Release job (nightly upload to iNavFlight/inav-nightly) can fail for reasons unrelated to the build itself and drags the whole run's conclusion to failure even when the build succeeded and produced the size-report/branch-name artifacts. Confirmed live: the 2026-08-20 push to release/9.1 had every build job succeed but Release fail with "Bad credentials" (NIGHTLY_TOKEN), so publish-baseline never ran and no baseline has ever been published — which is why PR #11800 still shows "No size baseline is available yet". Check the specific build/upload-artifacts job's conclusion instead of the aggregate run conclusion.
1 participant
Summary
Removes a dead struct field discovered during review of PR #11617.
Changes
servo_autotrim_iterm_thresholdfromservoConfig_tinsrc/main/flight/servos.hTesting
git log -Sshows the setting entry/initializer/reader were already removed in 2021 (commit e4f684f); this field was leftover from that cleanup.servoConfig_t; structsizeofis unchanged both before and after due to alignment padding, and no other field's offset shifts, so no PG version bump is needed). Same pattern as a prior precedent removal in this struct (commit 58dc107).Related Issues
None — discovered as a leftover from PR #11617.