feat: Formation Flight - possibility to show peer name - #11744
Conversation
|
Test firmware build ready — commit Download firmware for PR #11744 244 targets built. Find your board's
|
|
Just an FYI for contributors: The tentative schedule for INAV 10 is to have a full release in mid December. That means RC2 needs to be in early to mid November, which places INAV 10.0RC1 at September 1. Please plan to have any new features for INAV 10.0 ready for RC1 no later than September 1. After that, 10.1 will follow about six to seven months later. |
|
RAM / Flash usage vs. base branch — commit
|
FormationFlight transmits first three letters from aicraft name, but original MSP command MSP2_COMMON_SET_RADAR_POS does not supports it. So I added new MSP command to to be possible send peer name.
The name is possible to show only inI NAV radar fixed.
I decided to create new MSP command because I did not want to break compatibility. Command MSP2_COMMON_SET_RADAR_POS is used for ESP32-INAV-Radar and Ardupilot. So it's not possible to change structure of command.
Second posibility is send diferent command from FormationFlight if inav is detected, I don't like it.
Command MSP2_COMMON_SET_RADAR_PEER_NAME contains max_name_lenght so for future it's possible increase name lenght without breaking compatibility.
I will prepare PR for FormationFlight as well, it's not big change, and it does not break compatibility for Ardupilot.
The configurator needs to be adjusted as well, I will do that when aproach in this PR will be aproved
BTW: there is problem with peer indexes, original ESP32-INAV-Radar uses indexes 0 - X, FormationFlight starts with index 1, index 1 is used for "self", so first index whis is sent to inav is 2, it's a reasson why you see peers C, D, E ...
I made mistake when I created fixed OSD element, I dropped decreased index -1 so first letter what you can see is B (FormationFlight), and first peer is not displayed (ESP32-INAV-Radar). The question is if drop support for ESP32-INAV-Radar is good idea, I would not like do that.