Refactor: Split OMNIBUSF4 family into 4 target directories

[sensei-hacker]

User description

Summary

Splits the OMNIBUSF4 target family from 1 directory into 4 for better organization and maintainability.
It had nine different targets tangled together.
I used unifdef to split them, than used clang -E -dD and gcc -E to try to verify that the splitting is correct.

Changes

New 4-way directory structure:

1. DYSF4/ (2 targets): DYSF4PRO, DYSF4PROV2

   • Different I2C bus routing (I2C1 vs I2C2)
   • Different RSSI ADC pin (PC3 vs PA0)
   • Uses SPI flash for blackbox

2. OMNIBUSF4/ (1 target): OMNIBUSF4

   • Original variant with SPI flash

3. OMNIBUSF4PRO/ (3 targets): OMNIBUSF4PRO, OMNIBUSF4V3, OMNIBUSF4V3_ICM

   • Base variants with SD card
   • No softserial configurations
   • OMNIBUSF4V3 has UART6 inverter pins

4. OMNIBUSF4V3_SS/ (3 targets): OMNIBUSF4V3_S6_SS, OMNIBUSF4V3_S5S6_SS, OMNIBUSF4V3_S5_S6_2SS

   • Softserial variants with different S5/S6 timer configurations
   • Based on OMNIBUSF4V3 hardware

---

Description

This description is generated by an AI tool. It may have inaccuracies

• Split OMNIBUSF4 family from 3 directories into 4 separate target directories

  • DYSF4: DYS variants (DYSF4PRO, DYSF4PROV2) with I2C1 and SPI flash
  • OMNIBUSF4: Original OMNIBUSF4 target with SPI flash
  • OMNIBUSF4PRO: Base variants (OMNIBUSF4PRO, OMNIBUSF4V3, OMNIBUSF4V3_ICM) with SD card
  • OMNIBUSF4V3_SS: Softserial variants with different S5/S6 timer configurations

• Removed conditional compilation blocks from target files for cleaner separation

• All 9 targets verified to produce identical preprocessed output before/after split

• Improved maintainability by isolating hardware-specific configurations per directory

---

Diagram Walkthrough

flowchart LR
  A["OMNIBUSF4<br/>Consolidated<br/>9 targets"] -->|"Split by<br/>hardware variant"| B["DYSF4<br/>2 targets"]
  A -->|"Split by<br/>hardware variant"| C["OMNIBUSF4<br/>1 target"]
  A -->|"Split by<br/>hardware variant"| D["OMNIBUSF4PRO<br/>3 targets"]
  A -->|"Split by<br/>hardware variant"| E["OMNIBUSF4V3_SS<br/>3 targets"]

Loading

File Walkthrough

	Relevant files
Enhancement	8 files target.h New DYSF4 target header with I2C1 configuration                    +169/-0  target.c New DYSF4 target timer hardware configuration                        +47/-0    target.h Simplified OMNIBUSF4 header removing conditional blocks    +1/-103  target.c Simplified OMNIBUSF4 timer configuration removing conditionals +0/-19    target.h New OMNIBUSF4PRO header with base variant configurations  +232/-0  target.c New OMNIBUSF4PRO timer hardware with conditional blocks    +61/-0    target.h New OMNIBUSF4V3_SS header with softserial configurations  +209/-0  target.c New OMNIBUSF4V3_SS timer hardware with softserial variants +60/-0
Configuration changes	4 files CMakeLists.txt New DYSF4 build configuration for two targets                        +2/-0      CMakeLists.txt Updated OMNIBUSF4 build to single target only                        +0/-10    CMakeLists.txt New OMNIBUSF4PRO build configuration for three targets      +5/-0      CMakeLists.txt New OMNIBUSF4V3_SS build configuration for three targets  +4/-0

---

[qodo-code-review]

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

[qodo-code-review]

High-level Suggestion

The refactoring is incomplete, as new directories still contain complex conditional logic, which misses the goal of the split. More critically, the base OMNIBUSF4 target is now incorrectly configured to use an SD card instead of its intended SPI flash, likely causing a regression. [High-level, importance: 10]

Solution Walkthrough:

Before:

// src/main/target/OMNIBUSF4/target.h (before PR)
...
#if defined(OMNIBUSF4PRO) || defined(OMNIBUSF4V3)
  // SDCARD configuration for PRO/V3 variants
  #define ENABLE_BLACKBOX_LOGGING_ON_SDCARD_BY_DEFAULT
  #define USE_SDCARD
  ...
#else
  // SPI FLASH configuration for base OMNIBUSF4
  #define ENABLE_BLACKBOX_LOGGING_ON_SPIFLASH_BY_DEFAULT
  #define USE_FLASH_M25P16
  ...
#endif
...

After:

// src/main/target/OMNIBUSF4/target.h (after PR)
...
// The conditional logic for storage has been removed.
// The file now contains no specific blackbox storage configuration.
// This causes it to inherit the SDCARD configuration from OMNIBUSF4PRO/target.h,
// which is incorrect for the base OMNIBUSF4 target.
...

// src/main/target/OMNIBUSF4PRO/target.h (new file)
...
#if defined(OMNIBUSF4PRO) || defined(OMNIBUSF4V3)
  // Complex conditional compilation remains
#endif
...