Repository navigation
Function getCurrentControlProfile defined in header but not implemented #11616
Description
control_profile.h defines a getCurrentControlProfile function, but it was never implemented in control_profile.c
The function should probably either be implemented or alternatively its declaration removed from the header
I previously made a PR implementing the function (#11528) because I briefly thought I'd need it in another PR but ultimately ended up not needing it and decided it would make more sense to discuss how to handle this in an issue first
Activity
sensei-hacker commentedon Sep 9, 2026
Decision: implement, not remove.
getCurrentControlProfile()has a real (if currently dormant) caller —rc_adjustments.c'sapplySelectAdjustment(), underUSE_INFLIGHT_PROFILE_ADJUSTMENT(permanently commented out inrc_adjustments.htoday, so it doesn't affect current builds). Removing the declaration would leave that call site referencing a nonexistent function the moment that flag is ever enabled.Implemented as a simple linear scan (adapted from the approach in #11528), returning 0 on no match to match
setControlProfile()'s own clamp-to-0 behavior for an out-of-range index. PR: #11882