Repository navigation
Move minimatch 9.x/10.x to 11.0.3 (GHSA-g3hv-75wg-m249) - #62
Merged
Merged
Conversation
minimatch <11.0.1 can amplify globparts in firstPhasePreProcess() when optimizationLevel >= 2 (moderate DoS; first patched release 11.0.1). That code exists in 9.x and 10.x, used here by eslint, @eslint/config-array, @typescript-eslint/typescript-estree, app-builder-lib, @electron/universal and test-exclude. A range-keyed override moves those six copies to the project's minimatch 11.0.3. test-exclude also gets a nested override: npm kept re-adding 10.2.6 under it with the range key alone. 11 drops the top-level makeRe and AST exports and Minimatch#makeRe; none of the six consumers uses them (they call minimatch(), new Minimatch(), .match(path, partial), .negate and .set). Checked against the real tree: - electron-builder's matchers select identical files for all six release legs (about 57,000 files) with 10.2.6 and 11.0.3; - ESLint lints the same 1,546 files with identical results. The 3.x and 5.x copies (eslint-plugin-import/react/jsx-a11y, @electron/asar and its glob 7, dir-compare, filelist) stay: they have no firstPhasePreProcess or optimizationLevel, so the vulnerable code is not there, and their callers use the module as a function, which 11 no longer exports. npm audit still lists them because the advisory's single range covers every major. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5Uo5hC58DRSh1qB489Sos
iLevyTate
pushed a commit
that referenced
this pull request
Nov 1, 2026
- package.json / package-lock.json: 5.1.2. - CHANGELOG: 5.1.2 section for the glob and minimatch tooling updates (#61, #62) and the retried macOS notarization (#60); compare links. - SECURITY.md: applies to 5.1.2; example patch versions. - BETA_TESTER_GUIDE / INSTALL_GUIDE: current version and download names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5Uo5hC58DRSh1qB489Sos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<11.0.1can amplify globparts infirstPhasePreProcess()whenoptimizationLevel >= 2. The only fix is 11.0.1; there are no backports. That code exists in 9.x and 10.x, used here byeslint,@eslint/config-array,@typescript-eslint/typescript-estree,app-builder-lib,@electron/universalandtest-exclude."minimatch@>=9.0.0 <11.0.1": "^11.0.3", moves those six copies to the project's minimatch 11.0.3, and they deduplicate to the root copy. With the range key alone, npm kept re-adding 10.2.6 undertest-excludeand flagging it invalid, sotest-excludealso gets a nested override. Its subtree holds only glob 14 and minimatch 11.makeRe/ASTexports andMinimatch#makeRe. None of the six consumers uses them. They callminimatch(),new Minimatch(),.match(path, partial),.negateand.set.eslint-plugin-import/react/jsx-a11y,@electron/asarand its glob 7,dir-compareandfilelist. They have nofirstPhasePreProcessoroptimizationLevel, so the vulnerable code isn't there. Their callers also use the module as a function, which 11 no longer exports, and@electron/asarmatches the asar unpack patterns.npm auditstill lists them, because the advisory's single range covers every major.Scope
Type of Change
Test Plan
Automated
npm run format:checknpm run lintnpm testBefore/after comparisons on the real tree:
getMainFileMatchersandgetNodeModuleFileMatcherwith the committed configs) select identical files with minimatch 10.2.6 and 11.0.3. The only differences are the removed minimatch copies themselves.npm audit --omit=devfinds 0 vulnerabilities. A secondnpm installleaves the lockfile unchanged,npm ci --dry-run(with the repo's.npmrc) passes, andnpm lsshows no invalid minimatch nodes.npm run ciis running locally. I'll compare its coverage totals with main's before merging.Manual QA
docs/TESTING.md)Manual QA notes:
app.asarcheck cover the electron-builder side.Checklist
npm audituntil their parents move to minimatch 9+. The newerfilelist2.x and@electron/asar4.x already have, but they sit behindjakeand electron-builder's pinned@electron/asar3.4.1.Generated by Claude Code