Repository navigation
Move the vulnerable glob copies to 14.0.3 (GHSA-3g3m-2fjr-6pw4) - #61
Merged
Merged
Conversation
glob >=9.0.0 <=14.0.1 keeps walking directories after its AbortSignal fires (moderate; first patched release 14.0.2). The affected copies are dev-only: jest-config, jest-runtime and @jest/reporters (13.0.6), rimraf (13.0.6) and test-exclude (10.5.0). A scoped override moves exactly those to ^14.0.2 (14.0.3); glob 10, 13 and 14 export the same API, including the glob.sync that test-exclude calls. @electron/asar's glob 7.2.3 is outside the advisory and keeps its own major (its callback API differs), so the override key is limited to >=9.0.0 <14.0.2. The commercial-use inventory is regenerated for the lockfile change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5Uo5hC58DRSh1qB489Sos
iLevyTate
pushed a commit
that referenced
this pull request
Nov 1, 2026
- package.json / package-lock.json: 5.1.2. - CHANGELOG: 5.1.2 section for the glob and minimatch tooling updates (#61, #62) and the retried macOS notarization (#60); compare links. - SECURITY.md: applies to 5.1.2; example patch versions. - BETA_TESTER_GUIDE / INSTALL_GUIDE: current version and download names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5Uo5hC58DRSh1qB489Sos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glob(Dependabot, moderate): GHSA-3g3m-2fjr-6pw4. glob>=9.0.0 <=14.0.1keeps walking directories after itsAbortSignalfires; the first patched release is 14.0.2. Every affected copy is dev-only:jest-config,jest-runtimeand@jest/reporters(13.0.6),rimraf(13.0.6) andtest-exclude(10.5.0)."glob@>=9.0.0 <14.0.2": "^14.0.2", moves exactly those copies to 14.0.3. glob 10, 13 and 14 export the same API, including theglob.syncthattest-excludecalls.@electron/asarkeeps its glob 7.2.3, which is outside the advisory and has a different, callback-based API.docs/commercial-use-inventory.jsonis regenerated for the lockfile change and is stable on re-run.deepmerge(Dependabot, low), not changed: GHSA-gcqx-w48m-w2h4 lists no patched version; the latest release, 4.3.1, is the top of the vulnerable range. It is dev-only, and its two users,jest-configand@svgr/plugin-svgo, merge config objects from this repo, not attacker input. That alert has to be dismissed in GitHub; this session can't read or dismiss Dependabot alerts.Scope
npm run ciexercises every affected consumer: jest config, runtime and coverage,test-excludeinstrumentation, andrimrafinbuild.Type of Change
Test Plan
Automated
npm run format:checknpm run lintnpm testnpm auditno longer reports GHSA-3g3m-2fjr-6pw4, andnpm audit --omit=devfinds 0 vulnerabilities.compliance:commercial:verifypasses. The fullnpm run ciis running locally on this commit; I'll report the result here before merging.Manual QA
docs/TESTING.md)Manual QA notes:
Checklist
deepmergealert (no fix exists).npm auditalso still lists GHSA-g3hv-75wg-m249 for nested dev copies of minimatch 3.x/5.x/9.x. Their callers (eslint, jest, electron-builder) need those majors, and 3.x callers use the module as a function, which 11 no longer exports.Generated by Claude Code