Repository navigation
Build the Windows zip at normal compression so the release job finishes - #57
Merged
Merged
Conversation
The top-level `compression: maximum` makes electron-builder build a zip with 15-pass Deflate (-mx=9 -mfb=258 -mpass=15). On the x64 CUDA libraries that ran the v5.1.0 Windows release job past its 45-minute limit while it was still writing the zip. Setting win.compression to normal builds the zip at -mx=7; the NSIS app archive is 7z at -mx=9 either way, so the installer is unchanged. release.yml applies the same setting at build time for tags cut before this change (v5.1.0) and is a no-op after it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5Uo5hC58DRSh1qB489Sos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StratoSortStack-5.1.0-win-x64.zip(run). For a zip, the top-levelcompression: maximummakes electron-builder run 7-Zip with-mx=9 -mfb=258 -mpass=15, which is 15-pass Deflate over the CUDA libraries.electron-builder.jsonnow setswin.compression: "normal", so the zip is built at-mx=7. The NSIS app archive is 7z at-mx=9at either level, so the installer is unchanged. The arm64 leg builds only NSIS.release.ymlgains an x64-only step that applies the same setting at build time when the checked-out config doesn't have it yet. Tagv5.1.0already points at the old config and the tag workflow won't move a tag, so this step lets the existing tag build. For later tags it does nothing.Scope
Type of Change
Test Plan
Automated
npm run format:check(Prettier on the three changed files)npm run lint(ESLint on the changed test)npm test:electron-builder-config,verifyElectronFusesConfigandsettingsImportParser(57 tests), plusverify:electron-fuses-configThe new tests call electron-builder's own
compute7zCompressArgs. One checks that the Windows zip no longer gets-mpass=15. That test fails against thev5.1.0config and passes now. The other checks that the 7z settings for the NSIS archive match whatmaximumproduced.Manual QA
docs/TESTING.md)Manual QA notes:
v5.1.0copy ofelectron-builder.json. It setswin.compressiontonormal, a second run leaves the file alone, and the result matches the committed config exactly.release.ymlonv5.1.0after this merges.Checklist
NSURLErrorDomain -1005). That needs a re-run, not a code change.Generated by Claude Code