Expand test coverage using node:test#21
Merged
Merged
Conversation
Test src/translations.js directly (not the babel-built dist) and cover all three exported functions including window-dependent branches and the uninitialized-translations fallback path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
masonmcelvain
previously approved these changes
May 7, 2026
It says this is a module type but complains since we don't declare it.
Without clearing the state to undefined, we weren't actually seeing the errors get added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/translations.jsdirectly (not the babel-builtdist/) using Node's built-innode:testrunner_js(lookup, whitespace compaction, single/multi/repeated%Nplaceholders, non-string coercion,window.App.showTranslatedPlaceholdershort-circuit),___p(singular/plural branches incl. 0, arg forwarding), andsetTranslations(replacement)test/test-uninitialized.mjsin a separate file so theUITranslations === nullfallback path can be exercised on a fresh module load (node --testruns each file in its own process)Test plan
npm test— 17 tests pass across both filesqa_req 0 (CI is enough)