Conversation
Member
gautierdag
reviewed
Mar 18, 2019
| # c0 | ||
| c = torch.zeros([batch_size, self.hidden_size], device=device) | ||
|
|
||
| state = (h[None, ...], c[None, ...]) |
Member
There was a problem hiding this comment.
You can remove the whole state variable since you are initializing it to zero for all cases. See https://pytorch.org/docs/stable/nn.html?highlight=lstm#torch.nn.LSTM
gautierdag
reviewed
Mar 18, 2019
| nn.init.constant_(self.rnn.bias_hh_l0, val=0) | ||
| nn.init.constant_(self.rnn.bias_hh_l0[self.hidden_size:2 * self.hidden_size], val=1) | ||
|
|
||
| def forward(self, m): |
Member
There was a problem hiding this comment.
I don't particularly like having one letter variables if they represent uncommon things or are not iterators. If I could suggest changing m to messages maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.