Skip to content

fix(receipt): record PWG-2ii for N-1, N-2, N-3, N-7, N-8, N-9 (standards#1625) - #55

Closed
hyperpolymath wants to merge 3 commits into
mainfrom
claude/practical-hamilton-f2gkfu
Closed

hyperpolymath wants to merge 3 commits into
mainfrom
claude/practical-hamilton-f2gkfu

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

The standards proof-receipt reader (standards 940a27af) rejected verification/receipts/agda_praxis.deed:

FAIL ...: claim "N-1" records :pwg PWG-1, but its legs and receipts support PWG-2ii (PROOF-POLICY §8.2, §8.4)

Cause: standards#1625 (owner ruling 2026-11-16). PWG-1 now requires every counted witness's current receipt to name the container image its checker ran in, pinned by digest (:image "NAME@sha256:<64 hex>"). None of this receipt's legs names one, so the reader derives PWG-2ii. No digest was added or invented: no CI log of these runs printed one. The Agda job runs in a digest-pinned container, but the Rocq and Lean legs run on the bare runner, so PWG-1 would not be reachable by naming an image on the Agda leg alone.

The fix is made at its source, the generator scripts/grade-receipt.sh, so that CI's --check passes and a later --write does not revert the grades.

Changes

Claim Old New
N-1 PWG-1 PWG-2ii
N-2 PWG-1 PWG-2ii
N-3 PWG-1 PWG-2ii
N-7 PWG-1 PWG-2ii
N-8 PWG-1 PWG-2ii
N-9 PWG-1 PWG-2ii
  • scripts/grade-receipt.sh:
    • pwg_of now mirrors readProofReceipt at standards 940a27af. PWG-1 needs three source-describing witnesses and a current receipt naming a digest-pinned :image on every counted witness. Otherwise it is PWG-2ii.
    • The run ledger gains an optional 11th image column, emitted as :image on a current receipt. No row carries one.
    • STANDARDS_COMMIT is now 940a27af1e25a73a2d55daa78d0763e6749fd935, with the reader and checker sha256 pins updated (the digest script is unchanged).
    • The negative control (the first claim recorded as PWG-1 is refused) still holds.
  • verification/receipts/agda_praxis.deed: six :pwg fields, plus the header's reader pin (now 940a27a). --write reproduces the file exactly, so it is the generator's own output.
  • PROOF-STATUS.adoc: the census records PWG-2ii (was PWG-1) with the reason, and names the 940a27a pin.
  • README.adoc, docs/proof-debt.adoc, verification/proofs/README.adoc: stale PWG-1 statements corrected to PWG-2ii with the #1625 reason.
  • CHANGELOG.adoc: new entry.

New receipt sha256: 2c5f13fe59bfe49d719ba70068f4a63fc0215d2f022773b4d72ca9420c8138ac
Commits on the branch: d8cb4fea3fb5fef59b539e27553744e6ce3532a7 (receipt and census), 56c525998c15ae256e682e2ea791302f8be7c724 (generator, pin, docs), 2be7d3e7ae04133de2e9a8e6101e7c164b31d07e (PROOF-STATUS pin text). The head is 2be7d3e.

Testing

All at standards 940a27af.

  • node 1-formats/deed/tools/deed_lint.js --proof-receipt-json verification/receipts/agda_praxis.deed: exit 0. It derives PWG-2ii for N-1, N-2, N-3, N-7, N-8 and N-9.
  • scripts/check-proof-receipt.sh <receipt> <full clone>: exit 0. It prints 28 ok lines and ends with check-proof-receipt: every check holds.
  • bash scripts/grade-receipt.sh --check: exit 0:
PASS: verification/receipts/agda_praxis.deed matches the tree and the ledgers (source-commit 292d566a81a9bafcd6bdf7f3caab7fc2ebad36bd)
... (the shared checker's 28 ok lines)
check-proof-receipt: every check holds
PASS: git checks of §8.5.3 (shared checker, standards 940a27af1e25, --branch refs/remotes/origin/main)
PASS: the pinned reader (standards 940a27af1e25) accepts verification/receipts/agda_praxis.deed
  source-commit 292d566a81a9bafcd6bdf7f3caab7fc2ebad36bd
  N-1  PWG-2ii  foundation-diverse false
  N-2  PWG-2ii  foundation-diverse false
  N-3  PWG-2ii  foundation-diverse false
  N-7  PWG-2ii  foundation-diverse false
  N-8  PWG-2ii  foundation-diverse false
  N-9  PWG-2ii  foundation-diverse false
PASS: negative control (the first claim recorded as :pwg PWG-1 is refused: its legs support PWG-2ii)
  • Not run: scripts/check-adoc-renders.sh (asciidoctor is not installed here).
  • The commits carry SSH signatures from the platform signer. Local %G? shows N because no allowed-signers file is configured, so verify them on the forge.

Follow-up

  • hyperpolymath/mathesis docs/atlas/claims/claims.jsonl rows for secret-types currently pin this receipt at commit 4ed0672 / sha256 4ed7e550e399074cc8a93bd190f193a0fea78de97d54e27889263b9d386ce9cc. They need re-pinning to the merge commit and the new sha256 (2c5f13fe59bfe49d719ba70068f4a63fc0215d2f022773b4d72ca9420c8138ac, if the receipt does not change before merge) once this merges (and lintel's equivalent PR merges).

🤖 Generated with Claude Code

https://claude.ai/code/session_01J4QvDhq2buNFimmickMwwp

Summary by CodeRabbit

  • Documentation
    • Updated proof-witness grades for six claims to PWG-2ii to reflect that current receipts do not identify checker container images by digest.
    • Clarified that PWG-1 requires every counted witness receipt to include a digest-pinned image reference.
    • Updated the receipt and related documentation with the revised grading criteria and standards reader details.

…rds#1625)

standards#1625 (owner ruling 2026-11-16) makes PWG-1 require that every
counted witness's current receipt names the container image its checker
ran in, pinned by digest (:image "NAME@sha256:<64 hex>"). None of this
receipt's legs carries an :image, so the reader at standards 940a27af
derives PWG-2ii. Set :pwg PWG-2ii on all six claims and record the
downgrade in PROOF-STATUS.adoc. No digest was added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDhq2buNFimmickMwwp
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The receipt generator now supports optional digest-pinned checker images and requires them to derive PWG-1. The receipt and project documentation record PWG-2ii for six claims because their current receipts do not name an image.

Changes: Proof witness grades

Layer / File(s) Summary
Run-ledger validation and grade generation
scripts/grade-receipt.sh
The script accepts an optional 11th ledger field for current rows and validates its NAME@sha256: format. It derives PWG-1 only when all three current receipts name images, and emits :image when an image is supplied. The standards reader and checker pins are updated.
Receipt grades and documented rule
verification/receipts/agda_praxis.deed, PROOF-STATUS.adoc, README.adoc, docs/proof-debt.adoc, verification/proofs/README.adoc, CHANGELOG.adoc
The receipt changes N-1, N-2, N-3, N-7, N-8, and N-9 to PWG-2ii and updates the reader revision. The project documents explain that the receipts lack the image reference required for PWG-1.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to 2be7d

This change lowers the recorded proof grade for six claims from PWG-1 to PWG-2ii to match the updated standards rule, and it adds optional digest-pinned image support to the receipt generator. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: recording PWG-2ii grades for claims N-1, N-2, N-3, N-7, N-8 and N-9 in the receipt, with the standards#1625 reason. The raw summary and objectives both describe this a…
Description check Passed The description follows the template's main sections: Summary, Changes, and Testing are filled in with specific detail. The RSR Quality Checklist and Screenshots sections are not addressed, and the au…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: recording PWG-2ii grades for claims N-1, N-2, N-3, N-7, N-8 and N-9 in the receipt, with the standards#1625 reason. The raw summary and objectives both describe this as the primary change, and the generator, docs and changelog updates support it.

Full details: Description check

Explanation

The description follows the template's main sections: Summary, Changes, and Testing are filled in with specific detail. The RSR Quality Checklist and Screenshots sections are not addressed, and the author gives no checkbox state. The template's required checklist items (tests, formatting, linter, banned patterns, SPDX headers, secrets) are not marked. Most required content is present, so the check passes with a note about the missing checklist.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9fb8430 and 2be7d3e.

Files selected for processing: 7

  • CHANGELOG.adoc
  • PROOF-STATUS.adoc
  • README.adoc
  • docs/proof-debt.adoc
  • scripts/grade-receipt.sh
  • verification/proofs/README.adoc
  • verification/receipts/agda_praxis.deed

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Hypatia grid green

🟢 clean · commit 2be7d3e7ae04 · run 44213661955 · scope: this change (7 file(s))

Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high) — reported, never grading the change.

Reporter Gate Status Critical High Medium Minor Since previous revision
Hypatia scan gating 🟢 clean 0 0 0 0 — no comparable baseline
panic-attack assail advisory 🟡 medium 0 0 1 0 — no comparable baseline
pons asinorum advisory 🟢 clean 0 0 0 0 — no comparable baseline
finishingbot (release readiness) advisory 🔴 high 0 9 8 2 — no comparable baseline
glambot (presentation quality) advisory 🔵 minor 0 0 0 9 — no comparable baseline
rhodibot (RSR compliance) advisory 🟢 clean 0 0 0 0 — no comparable baseline
accessibilitybot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
cipherbot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
echidnabot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
panicbot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
seambot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
sustainabot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
Hypatia scan: 20 finding(s)
  • 20 further finding(s) in files this change does not touch: reported, not graded (0 critical, 4 high).
panic-attack assail: 17 finding(s)
  • medium CommandInjection — scripts/grade-receipt.sh — 71 potentially unquoted variable expansions in scripts/grade-receipt.sh
  • 16 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
pons asinorum: 9 finding(s)
  • 9 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
finishingbot (release readiness): 174 finding(s)
  • high V1-DOC-ROADMAP.adoc — Required file ROADMAP.adoc not found (Project roadmap).
  • high TOOL-001 — .tool-versions file not found for asdf/mise version management.
  • high SCM-001-NEUROSYM.scm — Required SCM file NEUROSYM.scm not found (Neurosymbolic AI documentation).
  • high SCM-001-AGENTIC.scm — Required SCM file AGENTIC.scm not found (Agentic AI integration documentation).
  • high SCM-001-PLAYBOOK.scm — Required SCM file PLAYBOOK.scm not found (Operational playbooks and procedures).
  • high SCM-001-ECOSYSTEM.scm — Required SCM file ECOSYSTEM.scm not found (Project's place in the ecosystem).
  • high SCM-001-META.scm — Required SCM file META.scm not found (Meta-level information and architectural decisions).
  • high SCM-001-STATE.scm — Required SCM file STATE.scm not found (Project state and progress tracking).
  • high PH-100 — Found 124 placeholders, exceeds maximum allowed (0)
  • medium V1-COM-CONTRIBUTING.md — CONTRIBUTING.md file not found (Contribution guidelines).
  • medium V1-COM-CODE_OF_CONDUCT.md — CODE_OF_CONDUCT.md file not found (Code of conduct).
  • medium V1-SEC-001 — SECURITY.md not found for responsible disclosure.
  • medium TEST-001 — Could not determine if this is a Rust or Deno project.
  • medium REL-004 — No SECURITY.md file found
  • medium CLM-006 — CHANGELOG.adoc — Documentation references non-existent file: e2e.yml.template
  • medium CLM-006 — CHANGELOG.adoc — Documentation references non-existent file: hypatia-scan.yml
  • medium PH-001 — CHANGELOG.adoc:138 — Found 'TODO' in: `FROM …:latest` lines and a body of TODO comments built nothing and failed
  • info CLM-003 — README.adoc — README missing 'Usage examples' section
  • info CLM-003 — README.adoc — README missing 'Installation instructions' section
  • 155 further finding(s) in files this change does not touch: reported, not graded (0 critical, 3 high).
glambot (presentation quality): 95 finding(s)
  • info GS-001 — Install git-seo for comprehensive SEO analysis: https://github.com/hyperpolymath/git-seo
  • info MACH-007 — ECOSYSTEM.scm not found in .machine_readable/ directory.
  • info MACH-007 — META.scm not found in .machine_readable/ directory.
  • info MACH-007 — STATE.scm not found in .machine_readable/ directory.
  • info MACH-005 — No robots.txt found. Consider adding one for crawler control.
  • info VIS-005 — docs/proof-debt.adoc:7 — Line 83 characters exceeds max length of 80.
  • info VIS-005 — PROOF-STATUS.adoc:42 — Line 85 characters exceeds max length of 80.
  • info VIS-005 — README.adoc:8 — Line 209 characters exceeds max length of 80.
  • info VIS-005 — CHANGELOG.adoc:86 — Line 84 characters exceeds max length of 80.
  • 86 further finding(s) in files this change does not touch: reported, not graded (0 critical, 2 high).
rhodibot (RSR compliance): 13 finding(s)
  • 13 further finding(s) in files this change does not touch: reported, not graded (0 critical, 12 high).
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
  • ⚪ not applicable: template default: enrol once the repository serves HTML
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
  • ⚪ not applicable: template default: enrol once the repository implements cryptography
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
  • ⚪ not applicable: template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
  • ⚪ not applicable: panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
  • ⚪ not applicable: template default: enrol once a seam register exists at spec/seams/seam-register.json
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
  • ⚪ not applicable: reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)

Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run.

…standards 940a27a

The generator still graded PWG-1 whenever three witnesses described the
source, so --check failed against the PWG-2ii receipt and --write would
revert it. pwg_of now mirrors readProofReceipt at standards 940a27af:
PWG-1 also needs every counted witness's current receipt to name a
digest-pinned :image. The run ledger gains an optional 11th image column,
emitted as :image; no row carries one, as no CI log printed a digest.

Pin the reader, reference digest script and checker at standards
940a27af, regenerate the receipt with --write (only the header pin
changes), and correct the stale PWG-1 statements in README.adoc,
docs/proof-debt.adoc and verification/proofs/README.adoc. Add a
CHANGELOG entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDhq2buNFimmickMwwp
@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Owner Author

Closing in favour of #56, at the owner's choice.

#54 merged the shared generator into main, so this branch now conflicts. #56 makes the same six PWG-2ii changes through the shared generator, and it adds digest-pinned images, the way back to PWG-1.

I checked #56's receipt at head 910d978 with the standards reader at 940a27af. It exits 0 and derives PWG-2ii for N-1, N-2, N-3, N-7, N-8 and N-9 (receipt sha256 7336af19…5eeb).

The mathesis claims.jsonl re-pin moves to #56's merge.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants