Skip to content

fix(required-contexts): require the local reusable to declare a string context input - #56

Open
hyperpolymath wants to merge 1 commit into
mainfrom
claude/sweet-edison-yp088x
Open

hyperpolymath wants to merge 1 commit into
mainfrom
claude/sweet-edison-yp088x

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Change

This PR makes scripts/check-required-contexts.sh (localTargetError) require the local reusable workflow to declare on.workflow_call.inputs.context with type: string.

The caller passes with.context, and GitHub refuses an input that the called workflow does not declare. Today the checker accepts a local target that declares only on.workflow_call, or the list or string forms, which cannot declare inputs at all. Such a target can never publish the required status.

CodeRabbit raised this on hyperpolymath/mathesis#106. The same fix is in that PR and in hyperpolymath/rsr-template-repo#451, which is the template source.

Changes to the tests:

  • The positive local fixtures now declare the input.
  • New negative tests cover:
    • no inputs at all;
    • the list form;
    • the string form;
    • inputs without context;
    • a context input that is not a string;
    • a context input with no type.
  • The path-traversal and self-call fixtures use the valid on block, so each fails for its own reason only.

Proven (local runs)

  • tests/workflows/squabble_gate_test.sh: 150 passed, 0 failed.
  • Control, the new tests run against the old checker: 143 passed, 7 failed. The 7 failures are exactly the new negative tests.
  • scripts/check-required-contexts.sh . on this repository: OK.

Not proven


Generated by Claude Code

…g context input

The caller passes with.context, and GitHub refuses an input that the
called workflow does not declare, so a local target with a bare
on.workflow_call (or the list/string forms, which cannot declare
inputs) was accepted by the checker but could never publish the
required status. The target must now declare
on.workflow_call.inputs.context with type: string.

Positive local fixtures declare that input; new negatives cover no
inputs, list and string forms, inputs without context, a non-string
type and a missing type. Path and self-call fixtures use the valid
on-block, so they fail for their own reason only.

Tests: squabble 150/0 (old checker against the new tests: 143/7).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDg8YzLVHtwwDfcY3J9
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9862866 and 3b9f658.

Files selected for processing: 2

  • scripts/check-required-contexts.sh
  • tests/workflows/squabble_gate_test.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Owner Author

CI on this head is red because the GitHub API quota for the hyperpolymath installation is exhausted, not because of this diff. The diff touches only scripts/check-required-contexts.sh and its tests.

Each failing job reports a 403 from the API:

  • "API rate limit exceeded for installation" (the gate and Hypatia);
  • setup-bun 403 (the 3-outcome suite);
  • curl 403 when reading the deed (Canon lockstep, which then reports "no ..._chora.deed");
  • "release not found" in the squabble installer.

The squabble self-tests themselves pass in this run. Other PRs fail the same way in the same window.

I will re-run the failed jobs once, after the quota window resets.


Generated by Claude Code

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 18, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants