Repository navigation
fix(required-contexts): require the local reusable to declare a string context input - #56
hyperpolymath wants to merge 1 commit into
Conversation
…g context input The caller passes with.context, and GitHub refuses an input that the called workflow does not declare, so a local target with a bare on.workflow_call (or the list/string forms, which cannot declare inputs) was accepted by the checker but could never publish the required status. The target must now declare on.workflow_call.inputs.context with type: string. Positive local fixtures declare that input; new negatives cover no inputs, list and string forms, inputs without context, a non-string type and a missing type. Path and self-call fixtures use the valid on-block, so they fail for their own reason only. Tests: squabble 150/0 (old checker against the new tests: 143/7). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDg8YzLVHtwwDfcY3J9
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
|
CI on this head is red because the GitHub API quota for the hyperpolymath installation is exhausted, not because of this diff. The diff touches only Each failing job reports a 403 from the API:
The squabble self-tests themselves pass in this run. Other PRs fail the same way in the same window. I will re-run the failed jobs once, after the quota window resets. Generated by Claude Code |



Change
This PR makes
scripts/check-required-contexts.sh(localTargetError) require the local reusable workflow to declareon.workflow_call.inputs.contextwithtype: string.The caller passes
with.context, and GitHub refuses an input that the called workflow does not declare. Today the checker accepts a local target that declares onlyon.workflow_call, or the list or string forms, which cannot declare inputs at all. Such a target can never publish the required status.CodeRabbit raised this on hyperpolymath/mathesis#106. The same fix is in that PR and in hyperpolymath/rsr-template-repo#451, which is the template source.
Changes to the tests:
inputsat all;inputswithoutcontext;contextinput that is not a string;contextinput with no type.onblock, so each fails for its own reason only.Proven (local runs)
tests/workflows/squabble_gate_test.sh: 150 passed, 0 failed.scripts/check-required-contexts.sh .on this repository: OK.Not proven
Generated by Claude Code