Skip to content

chore: stop tracking Agda interface files (*.agdai) - #47

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/untrack-agdai
Nov 17, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/untrack-agdai

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

Stop tracking the seven compiled Agda interface files under src/ResourceAlgebra/ and ignore *.agdai. They are version-specific build output that every local Agda run rewrites. The gate runs --ignore-interfaces, so nothing reads them. Found in passing while working on #45.

Changes

  • git rm --cached the seven src/ResourceAlgebra/*.agdai files (they stay on disk).
  • .gitignore: ignore *.agdai everywhere. Previously only verification/proofs/agda/*.agdai was ignored.

RSR Quality Checklist

Required

  • Tests pass: scripts/check-agda.sh (Agda 2.6.4.3) passes unchanged, with its core proofs, unit tests and all 9 expected rejections
  • No banned language patterns
  • No secrets, credentials or .env files

Testing

scripts/check-agda.sh passed on this branch. After the run, git status shows no .agdai file as modified or untracked.


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Generated Agda interface files are now excluded from version control as build output. This repository housekeeping keeps those artifacts out of tracked changes and does not alter the application’s behavior or any user-facing features. No changes to functionality, settings, or workflows are included in this update.

src/ResourceAlgebra/*.agdai are compiled interface files: version-specific
build output that every local Agda run rewrites. The gate runs
--ignore-interfaces, so nothing reads them. verification/proofs/agda/*.agdai
was already ignored; this ignores *.agdai everywhere and removes the seven
tracked copies from the index. scripts/check-agda.sh passes unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013CuBToxr5h9catptGiTsFX
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The .gitignore file now identifies Agda interface files as build output and ignores files matching *.agdai.

Changes: Agda build outputs

Layer / File(s) Summary
Agda interface file ignore rule
.gitignore
Adds a comment identifying Agda interface files as build output and ignores files matching *.agdai.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: Minimal · up to 96cd0

This change stops tracking generated Agda interface files and ignores them going forward. It has no runtime impact, and no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the seven Agda interface files (*.agdai) are no longer tracked by Git. It matches the raw summary, which shows the .gitignore update and the removal of those files fro…
Description check Passed The description covers the core content of the change. It has a Summary that explains what changed and why, a Changes list with the seven untracked files and the .gitignore update, and a Testing secti…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the seven Agda interface files (*.agdai) are no longer tracked by Git. It matches the raw summary, which shows the .gitignore update and the removal of those files from tracking. The 'chore:' prefix is a conventional-commit type and does not affect the match.

Full details: Description check

Explanation

The description covers the core content of the change. It has a Summary that explains what changed and why, a Changes list with the seven untracked files and the .gitignore update, and a Testing section with the check-agda.sh run. It keeps the required checklist items the author judged relevant. It omits the template's Required items for linting, formatting, SPDX headers, and banned functions, and it does not address the As Applicable items. These omissions are minor because the change touches only build output and .gitignore. The description also does not include a Screenshots section, which is optional. It leaves the HTML comment placeholders out, which is acceptable. Overall the description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between a17ffb6 and 96cd05b.

Files selected for processing: 8

  • .gitignore
  • src/ResourceAlgebra/All.agdai
  • src/ResourceAlgebra/Core.agdai
  • src/ResourceAlgebra/Instances/HWM.agdai
  • src/ResourceAlgebra/Instances/Loss.agdai
  • src/ResourceAlgebra/Instances/MaxPlus.agdai
  • src/ResourceAlgebra/Prelude.agdai
  • src/ResourceAlgebra/Separation.agdai

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 17, 2026 13:53
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026
@hyperpolymath
hyperpolymath merged commit 4f8b058 into main Nov 17, 2026
47 checks passed
@hyperpolymath
hyperpolymath deleted the claude/untrack-agdai branch November 17, 2026 14:01
hyperpolymath pushed a commit that referenced this pull request Nov 17, 2026
main moved six commits ahead (#36, #37, #41, #43, #44, #47). The branch's
proofs.yml predated #43's rename of the aggregating job to `Proofs verdict`,
so the CI/gate publisher reported "never reported: proofs.yml:Proofs
verdict" on this PR's head.

Conflicts: CHANGELOG.adoc keeps both sides' entries, newest first;
PROOF-STATUS takes main's revdate. The port's changelog line said the
gate's `-W noUnsupportedIndexedMatch` was unchanged; #37 removed it, so the
line now says the gate suppresses no warning and names the abbreviated and
split-pragma refusals.

coverage-exemption.toml: drop `pending-removal = ["src/interface"]`, whose
comment says to delete it when this PR merges; this PR removes the tree.
The exemption still holds, and a planted src/interface/*.zig is refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDjDR2MdRwZH9b4rKJn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants