Repository navigation
fix(trust): no level 5 without a kernel check; honest status; v1.0.0 plan - #5
Merged
Merged
Conversation
A coqc and a lean binary on PATH raised the trust level to 5. No code checks the emitted .v and .lean files, so the level was false. The maximum is now 4 and --require-level-5 always reports Q-504 in this version. Suite case 16 puts fake coqc and lean on PATH and requires the doctor to report level 4. It fails on the old source. Checked with Zig 0.17.1: 10 of 10 unit tests pass; the suite gives 14 passed and 2 failed (cases 2 and 15 fail before and after this change, off the solver versions that the README names). Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmp1i8PGVHkq3u2iNz
The README claimed a proof-DAG kernel checker, a symbolic BMC engine and honest certificates. The status block now gives the measured results and the limits of the evidence. docs/plan/ULTRAPLAN.adoc lists the open holes H1 to H10, the release gates, the order, the model roles and the effort sizes. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmp1i8PGVHkq3u2iNz
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Two commits, each reviewable alone.
fix(trust): acoqcand aleanbinary on PATH raised the trust level to 5. No code checks the emitted.vand.leanfiles, so the level was false. This is a soundness hole.docs: the README states the measured status and the limits of the evidence. A plan to v1.0.0 lists the open holes.Changes
src/core/engine.zig,src/interface/ffi/src/cli_main.zig,src/core/errors.zig: the maximum trust level is 4.--require-level-5always reportsQ-504in this version. The doctor markscoqcandleanas unused.tests/quintessence/run_suite.sh: case 16 puts fakecoqcandleanon PATH and requires the doctor to report level 4.README.adoc: the status block gives measured results and seven limits (structural Alethe check, generic BMC model, heuristic Layer C, receipt entries not checked, local mutation engine, level 4 maximum, no project proof).docs/plan/ULTRAPLAN.adoc(new): holes H1 to H10, release gates, order Q0 to Q6 mapped to WP-01 to WP-27 and M1 to M5, model roles, effort sizes.CHANGELOG.adoc: entry under Unreleased.Not fixed here (open holes, in the plan)
provedwith one rule checked (H2).RSR Quality Checklist
zig build test: 10 of 10 passed (Zig 0.17.1)src/)tests/quintessence/run_suite.sh: 14 passed, 2 failed. Cases 2 and 15 fail before and after this change, with Z3 4.8.12 and cvc5 1.1.2. The suite was written for Z3 5.3.1 and cvc5 1.4.2, which are not pinned. This PR does not claim a green suite.CHANGELOGupdatedmix)Testing
As above. Estate checks run and passing:
check-no-placeholders.sh,check-no-md-in-docs.sh,check_root_shape_test.sh.check-lock-sync.shneedsgawk, which the session did not have; this PR changes no workflow.Generated by Claude Code