Skip to content

fix(trust): no level 5 without a kernel check; honest status; v1.0.0 plan - #5

Merged
hyperpolymath merged 2 commits into
mainfrom
marina/cool-noether-i2rc8g
Nov 15, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
marina/cool-noether-i2rc8g

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Two commits, each reviewable alone.

  1. fix(trust): a coqc and a lean binary on PATH raised the trust level to 5. No code checks the emitted .v and .lean files, so the level was false. This is a soundness hole.
  2. docs: the README states the measured status and the limits of the evidence. A plan to v1.0.0 lists the open holes.

Changes

  • src/core/engine.zig, src/interface/ffi/src/cli_main.zig, src/core/errors.zig: the maximum trust level is 4. --require-level-5 always reports Q-504 in this version. The doctor marks coqc and lean as unused.
  • tests/quintessence/run_suite.sh: case 16 puts fake coqc and lean on PATH and requires the doctor to report level 4.
  • README.adoc: the status block gives measured results and seven limits (structural Alethe check, generic BMC model, heuristic Layer C, receipt entries not checked, local mutation engine, level 4 maximum, no project proof).
  • docs/plan/ULTRAPLAN.adoc (new): holes H1 to H10, release gates, order Q0 to Q6 mapped to WP-01 to WP-27 and M1 to M5, model roles, effort sizes.
  • CHANGELOG.adoc: entry under Unreleased.

Not fixed here (open holes, in the plan)

  • The NIF receipt emitter records C1 to C12 as proved with one rule checked (H2).
  • The committed NIF receipt hash does not match a fresh build on a second host, with Zig 0.17.0 or 0.17.1 (H3).
  • No CI workflow builds or tests the engine (H9). A workflow needs the lock tooling that the newer template carries.

RSR Quality Checklist

  • zig build test: 10 of 10 passed (Zig 0.17.1)
  • Case 16 passes with the fix and fails on the old source (checked by stashing src/)
  • tests/quintessence/run_suite.sh: 14 passed, 2 failed. Cases 2 and 15 fail before and after this change, with Z3 4.8.12 and cvc5 1.1.2. The suite was written for Z3 5.3.1 and cvc5 1.4.2, which are not pinned. This PR does not claim a green suite.
  • No banned language, no secrets, SPDX headers present
  • CHANGELOG updated
  • Not run: the Elixir front end (mix)

Testing

As above. Estate checks run and passing: check-no-placeholders.sh, check-no-md-in-docs.sh, check_root_shape_test.sh. check-lock-sync.sh needs gawk, which the session did not have; this PR changes no workflow.


Generated by Claude Code

A coqc and a lean binary on PATH raised the trust level to 5. No code checks the emitted .v and .lean files, so the level was false. The maximum is now 4 and --require-level-5 always reports Q-504 in this version.

Suite case 16 puts fake coqc and lean on PATH and requires the doctor to report level 4. It fails on the old source. Checked with Zig 0.17.1: 10 of 10 unit tests pass; the suite gives 14 passed and 2 failed (cases 2 and 15 fail before and after this change, off the solver versions that the README names).

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmp1i8PGVHkq3u2iNz
The README claimed a proof-DAG kernel checker, a symbolic BMC engine and honest certificates. The status block now gives the measured results and the limits of the evidence. docs/plan/ULTRAPLAN.adoc lists the open holes H1 to H10, the release gates, the order, the model roles and the effort sizes.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmp1i8PGVHkq3u2iNz
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 15, 2026 10:04
@hyperpolymath
hyperpolymath merged commit f097c7e into main Nov 15, 2026
19 of 20 checks passed
@hyperpolymath
hyperpolymath deleted the marina/cool-noether-i2rc8g branch November 15, 2026 10:04
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T10:07:03.380656Z 0379417 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-15T10:07:11.570253Z 0379417 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants