Repository navigation
fix(assail): blank // comments only where // is a comment - #305
Merged
Merged
Conversation
analyze_cross_language blanked C-style `//` line comments in every file before matching URLs. In shell scripts and Justfile recipes that cut `curl http://host` at the `//`, so an unquoted plain-HTTP URL was never reported (found while testing PA1 claim (c), whose test had to quote its URL). routing.rs gains slash_line_comments(Language), an exhaustive match beside `route`, and the cross-language pass takes the file's (or the embedded script's) language. Languages whose comment syntax the table does not record (nextgen DSLs, Datalog, Unknown) keep the old blanking. Tests: claim (c) now uses an unquoted recipe URL; slash_comment_tests checks a shell script (reported) and a Rust doc comment (ignored). Planted faults "always blank" and "never blank" each fail them. Self-scan findings are unchanged (36 before and after, on main). PROOF-NEEDS closes the open recall-gap row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jma5ixtpeZyJRmfoSsC98u
hyperpolymath
marked this pull request as ready for review
November 16, 2026 19:54
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
hyperpolymath
enabled auto-merge (squash)
November 16, 2026 19:54
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The gap
analyze_cross_languageblanks C-style//line comments in every file before matching URLs. In shell scripts and Justfile recipes, that cutscurl http://hostat the//, so an unquoted plain-HTTP URL is never reported by the InsecureProtocol check.This was found while testing PA1 claim (c). That test on
mainhas to quote its recipe URL to pass, andPROOF-NEEDS.adoclists the gap as an open obligation.The fix
src/assail/routing.rsgainsslash_line_comments(Language) -> bool, an exhaustive match besideroute.rustcforces every new language to be classified.analyze_cross_languagetakes the language of the file, or of the embedded script, and blanks//comments only where//is a comment.Unknown.Evidence
slash_comment_tests:main-based branch:cargo test --all-features: 888 passed, 0 failed.cargo clippy --all-targets --all-features -D warnings: clean.cargo fmt --check: clean.main.PROOF-NEEDS.adoc: the open "Unquotedhttp://URLs" row is closed, and the routing row says how the gap was closed.Independent of #304; either can merge first.
Generated by Claude Code