Skip to content

ci: remove the BoJ build trigger workflow, which could never succeed - #192

Open
hyperpolymath wants to merge 1 commit into
mainfrom
claude/charming-maxwell-1ar6w3
Open

hyperpolymath wants to merge 1 commit into
mainfrom
claude/charming-maxwell-1ar6w3

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

Removes .github/workflows/boj-build.yml and its entry in .github/workflows/actions.lock. Two files, 25 lines deleted, nothing added.

Why remove and not repair

The step "Trigger BoJ Server (Casket/ssg-mcp)" was broken in three ways, and the repo gives nothing to repair it against.

Fault Evidence
The run: script is not valid shell The payload ends \"engine\": \"casket\\"}"}. bash -n on the script (with the two ${{ }} expressions substituted) exits 2: unexpected EOF while looking for matching '"'. actionlint 1.7.7 with shellcheck 0.10.0 reports SC1073, SC1072, SC1083 and SC1009. Bash stops before curl runs, so no request was ever sent.
Plain HTTP to an unreachable host It targets http://boj-server.local:7700/cartridges/ssg-mcp/invoke. .claude/CLAUDE.md (Security Requirements) says HTTPS only. A .local name does not resolve on GitHub-hosted runners.
The failure is hidden The step has continue-on-error: true. Run 44131608409 on 246b03d shows the step and the job both concluded success. The five most recent runs on main all concluded success; the workflow has 192 recorded runs.

No reachable BoJ endpoint is documented in this repo. I searched the tree for boj-server, ssg-mcp, casket, 7700 and BOJ_URL. The only URLs are:

  • http://boj-server.local:7700, in this workflow;
  • http://localhost:7700, in .github/copilot/coding-agent.yml, which is the Copilot agent's own local MCP server and not a build target.

There is no HTTPS endpoint, no repository variable naming one, and no doc describing one. I did not guess one.

Nothing depends on it

  • Triggers: push to main/master and workflow_dispatch. It has no workflow_call, so nothing can call it.
  • Other workflows: none references it by file, by name ("BoJ Server Build Trigger") or by job (trigger-boj). No workflow has a workflow_run trigger.
  • Required checks: ci.yml's CI/gate aggregates agda-proofs, rust-ci and dashboard-check only. ci: add the required CI/gate aggregator #190 records that the rulesets require only CI/gate and scan / gitleaks. I could not query the rulesets API from this session, so that part rests on ci: add the required CI/gate aggregator #190 and on the repo's files.
  • The site build: casket-pages.yml builds and deploys the site by running casket-ssg on the runner. It does not use BoJ.

Validation

Check Result
actionlint 1.7.7 + shellcheck 0.10.0 over .github/workflows/, before 16 findings, 4 of them in boj-build.yml
Same, after 12 findings, none new. The 12 are byte-identical to the baseline and are in dogfood-gate.yml (10), dependabot-automerge.yml (1) and e2e.yml (1). They are not touched here.
bash tests/workflows/ci_gate_test.sh exit 0
Lock: every workflows: key names a file that exists holds for all 12 remaining keys
Lock: actions/checkout@v7.0.1 still in use 8 workflows list it, so no dependencies: entry changes
References left in the tree one, in docs/reports/audit/audit-2026-04-04.adoc, a dated audit report, left as history

Not run: gh actions-lock. The repo has no local lock check, and the tool was not available here, so the lock entry was removed by hand, as #190 did for its entry. Please regenerate the lock if you prefer. The lock is keyed by workflow path, and a key for a deleted file is the stale state this avoids.

Notes for the owner

  • Commit message wording. The commit says "across 192 green runs". I verified the five most recent runs, not all 192. The table above is the accurate statement; please use it if you squash.
  • Legacy field now stale. .machine_readable/6a2/anchor/ANCHOR.a2ml still says ssg.boj_trigger: true and cartridge: "ssg-mcp". Under .claude/CLAUDE.md the .a2ml files are legacy and agents may not add facts to them, so I left it. It belongs with the migration in Retire the 29 legacy .a2ml files (A2ML is retired estate-wide) #187.
  • This is estate-wide. A code search for boj-server.local in the hyperpolymath org returns 165 hits, nearly all .github/workflows/boj-build.yml in other repos, plus hyperpolymath/scripts boj-unify-repos.sh, which looks like the generator. squisher-corpus has already moved its copy to .github-retired/. This PR fixes januskey only.
  • If a BoJ trigger is wanted later, it needs a documented HTTPS endpoint held in a repository variable, a body built with jq -n, curl --fail, and no continue-on-error.

Generated by Claude Code

boj-build.yml POSTed to http://boj-server.local:7700 on every push to
main. The step could not work, and continue-on-error kept the job green:

- The run script was not valid shell. The JSON payload ended with an
  escaped backslash before the closing quote, so bash stopped at
  "unexpected EOF while looking for matching quote" before curl ran
  (actionlint/shellcheck SC1073, SC1072).
- The target was plain HTTP, which the repo's security rules forbid, on
  a .local name that GitHub-hosted runners cannot resolve.
- continue-on-error: true hid both, across 192 green runs.

Nothing depends on the workflow: it is not called, not a workflow_run
source, and not a required check. The repo documents no reachable BoJ
endpoint, so there is nothing to repair it against. The site is built
by casket-pages.yml, which runs casket-ssg on the runner.

Also drop the workflow's entry from actions.lock. Its only action,
actions/checkout@v7.0.1, is still used by eight other workflows, so no
dependency entry changes.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDiMgLS4FnZApYxUk1b
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Removed an automated repository workflow that sent build and branch details to an external service.
    • This change does not affect application features or the experience of using the product.

The BoJ build workflow was removed. It ran on pushes to main or master and on manual dispatch, then sent repository and engine details to the BoJ server.

Changes: BoJ build workflow

Layer / File(s) Summary
Remove the BoJ build workflow
.github/workflows/boj-build.yml
The workflow, its triggers, checkout, POST request, timeout, error handling, and read-only permissions were removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to dd8d9

This removes a CI workflow that could not reach its target and whose failures were suppressed, so it provided no signal. No product behavior changes, and it can be restored with a revert if needed.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: removing the BoJ build trigger workflow. It also gives the reason that the workflow could never succeed. The deletion matches the raw summary, which records the delet…
Description check Passed The description explains what was removed (the boj-build.yml workflow and its actions.lock entry), why it was removed (invalid shell script, unreachable plain-HTTP host, hidden failure), and what depe…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: removing the BoJ build trigger workflow. It also gives the reason that the workflow could never succeed. The deletion matches the raw summary, which records the deleted workflow file and no other code change.

Full details: Description check

Explanation

The description explains what was removed (the boj-build.yml workflow and its actions.lock entry), why it was removed (invalid shell script, unreachable plain-HTTP host, hidden failure), and what depends on it or does not. It matches the raw summary and the objectives. Some validation steps were not run, and the author states this.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 17a320cd-332b-4581-b88e-04a86cb19cf3
Commits

Reviewing files that changed from the base of the PR and between 246b03d and dd8d9fe.

Files ignored due to path filters: 1

  • .github/workflows/actions.lock is excluded by !**/*.lock
Files selected for processing: 1

  • .github/workflows/boj-build.yml
Files with no reviewable changes: 1

  • .github/workflows/boj-build.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 16

  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / rust-secrets
  • GitHub Check: rust-ci / Cargo doc (warnings denied)
  • GitHub Check: rust-ci / cargo-deny (advisories, bans, sources)
  • GitHub Check: rust-ci / Cargo check + clippy + fmt
  • GitHub Check: Dogfooding compliance summary
  • GitHub Check: CodeRabbit
  • GitHub Check: agda-proofs / Reversibility as a grade (Loss instance), expected rejections
  • GitHub Check: dashboard-check / STATE vs dashboard reconciliation
  • GitHub Check: agda-proofs / Rocq and Lean recheck legs, expected rejections
  • GitHub Check: idris-abi
  • GitHub Check: Rust Build + Unit Tests
  • GitHub Check: Zig FFI Build + Test
  • GitHub Check: Criterion Benchmarks
  • GitHub Check: E2E Lifecycle Test
  • GitHub Check: semgrep-cloud-platform/scan

@sonarqubecloud

Copy link
Copy Markdown

@linear-code
linear-code Bot marked this pull request as ready for review November 17, 2026 17:40
@hyperpolymath
hyperpolymath marked this pull request as draft November 17, 2026 17:41
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 17, 2026 17:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants