fix(abi): accept runtogether form for multi-cap acronym variants (ise…#35
Merged
Merged
Conversation
…riser#18)
`zig_variant_candidates` previously only emitted the snake_case form.
That choked on cartridges whose hand-written Zig FFI spells multi-cap
acronyms as a single run-together word (verified on boj-server/main):
| Idris2 | Emitter said | Zig actually has |
| ---------- | ------------ | ---------------- |
| GitHub | git_hub | github |
| GitLab | git_lab | gitlab |
| RabbitMQ | rabbit_mq | rabbitmq |
| DynamoDB | dynamo_db | dynamodb |
Per iseriser#18, the runtogether form (snake with all `_` removed) is
added as an additional candidate. The verifier already accepts any
candidate, so cartridges using snake_case (`manifest_loaded`, etc.)
stay green and cartridges using runtogether (`github`, etc.) now also
pass. No cartridge files are touched.
Single-word variants (`Empty` → `empty`) do NOT get a duplicate
candidate — the runtogether form is only added when it actually
differs from the snake form.
End-to-end verified against boj-server/main:
git-mcp: abi-verify OK (was Class B drift)
queues-mcp: abi-verify OK (was Class B drift)
aws-mcp: still drifts, but on a *different* class
(variant-extra-in-zig: sqs_send_message, sts_*,
not the DynamoDB normalisation case) — separate fix
8 manifest_schema unit tests pass; full suite (46 lib + 9 integration)
stays green.
Refs hyperpolymath/standards#92 (Phase 2 allowlist expansion).
Refs #18.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…riser#18)
zig_variant_candidatespreviously only emitted the snake_case form. That choked on cartridges whose hand-written Zig FFI spells multi-cap acronyms as a single run-together word (verified on boj-server/main):Per iseriser#18, the runtogether form (snake with all
_removed) is added as an additional candidate. The verifier already accepts any candidate, so cartridges using snake_case (manifest_loaded, etc.) stay green and cartridges using runtogether (github, etc.) now also pass. No cartridge files are touched.Single-word variants (
Empty→empty) do NOT get a duplicate candidate — the runtogether form is only added when it actually differs from the snake form.End-to-end verified against boj-server/main:
git-mcp: abi-verify OK (was Class B drift)
queues-mcp: abi-verify OK (was Class B drift)
aws-mcp: still drifts, but on a different class
(variant-extra-in-zig: sqs_send_message, sts_*,
not the DynamoDB normalisation case) — separate fix
8 manifest_schema unit tests pass; full suite (46 lib + 9 integration) stays green.
Refs hyperpolymath/standards#92 (Phase 2 allowlist expansion). Refs #18.
Summary
Changes
RSR Quality Checklist
Required
just testor equivalent)just fmtor equivalent)unsafeblocks without// SAFETY:commentsbelieve_me,unsafeCoerce,Obj.magic,Admitted,sorry).envfiles includedAs Applicable
.machine_readable/STATE.a2mlupdated (if project state changed).machine_readable/ECOSYSTEM.a2mlupdated (if integrations changed).machine_readable/META.a2mlupdated (if architectural decisions changed)TOPOLOGY.mdupdated (if architecture changed)CHANGELOGor release notes updatedsrc/interface/abi/andsrc/interface/ffi/consistent)Testing
Screenshots