revert(scaffold): remove wrong-place adapter emission (standards#89 s…#28
Merged
Conversation
…ub-issue 1)
The unified transaction-gated adapter belongs to the boj-server cartridge
(boj-server/cartridges/<name>-mcp/adapter/), not to the new -iser repo.
The pilot k9iser confirms this: k9iser has no adapter; its adapter lives
at boj-server/cartridges/k9iser-mcp/adapter/k9iser_adapter.zig.
iseriser PR#12 emitted adapter/<name>_adapter.zig into the new -iser repo
where it had no FFI module to import (`@import("<name>_ffi")` against
nothing), no build.zig, and no cartridge.json. The emitted dispatch was
a stub that discarded tool+body, only two of four advertised protocols
were routed, and a buffer-aliasing bug between dispatchRest and the HTTP
response writer would have corrupted output if any FFI were attached.
Surgical revert:
- Drop generate_unified_adapter (213 lines).
- Drop the call site and its doc-comment marker.
- Update test threshold 22 → 21 (base + regen workflow only).
- Drop the adapter-existence assertion in test_files_written_to_disk.
- Update the CI/CD generator header to document why the adapter is not
emitted here and where it belongs (cartridge-skeleton codegen is
tracked under standards#89 Phase 2b).
Keeps generate_regen_workflow unchanged — .github/workflows/<name>-regen.yml
correctly belongs in the -iser repo (it triggers the cartridge in boj-server).
Verification: cargo build clean; cargo test 49 unit + 9 integration green.
Refs hyperpolymath/standards#90
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ub-issue 1)
The unified transaction-gated adapter belongs to the boj-server cartridge (boj-server/cartridges/-mcp/adapter/), not to the new -iser repo.
The pilot k9iser confirms this: k9iser has no adapter; its adapter lives at boj-server/cartridges/k9iser-mcp/adapter/k9iser_adapter.zig.
iseriser PR#12 emitted adapter/_adapter.zig into the new -iser repo where it had no FFI module to import (
@import("<name>_ffi")against nothing), no build.zig, and no cartridge.json. The emitted dispatch was a stub that discarded tool+body, only two of four advertised protocols were routed, and a buffer-aliasing bug between dispatchRest and the HTTP response writer would have corrupted output if any FFI were attached.Surgical revert:
Keeps generate_regen_workflow unchanged — .github/workflows/-regen.yml correctly belongs in the -iser repo (it triggers the cartridge in boj-server).
Verification: cargo build clean; cargo test 49 unit + 9 integration green.
Refs hyperpolymath/standards#90
🤖 Generated with Claude Code
Summary
Changes
RSR Quality Checklist
Required
just testor equivalent)just fmtor equivalent)unsafeblocks without// SAFETY:commentsbelieve_me,unsafeCoerce,Obj.magic,Admitted,sorry).envfiles includedAs Applicable
.machine_readable/STATE.a2mlupdated (if project state changed).machine_readable/ECOSYSTEM.a2mlupdated (if integrations changed).machine_readable/META.a2mlupdated (if architectural decisions changed)TOPOLOGY.mdupdated (if architecture changed)CHANGELOGor release notes updatedsrc/interface/abi/andsrc/interface/ffi/consistent)Testing
Screenshots