fix(ci): triage Tests + Dogfood Gate failures (Refs #77)

[hyperpolymath]

Triage of the three workflows in #77.

Tests — fixed (988/988)

Root cause of the red was a single uncaught exception (PhoenixSocket.nextRef is not a function) that aborted the run mid-suite. The runner only console.log'd failures and never exited nonzero, so that crash was the only thing failing CI — and it masked 18 pre-existing real failures.

• PhoenixSocket: allocRef → nextRef (API drift; both test suites expect nextRef).
• applyFriction: float-safe assertion (100.0*0.55 !== 55.0 in IEEE-754).
• Gated the runner (Deno.exit(1) on failure) — this un-masks the 18; all fixed, choosing the canonical side per the source's documented intent:
  • Multiplayer ×3 — Hacker→Q was a deliberate rename across 5 source files; tests were stale.
  • LevelConfig ×10 + Functional F06/F15 + Regression R09 — a dated, commented gameplay rebalance ("Counts updated 2026-03-16", "Win rate was 0%"); tests encoded the old numbers.
  • CompanionMole getCarryCapacity — mock used the old multi-slot equipment model; source refactored to single equipped.
  • DLC bundle round-trip — wire form is lowercase "expert"; test wrongly expected "Expert".

The gating is the important durable fix: silent test rot is no longer possible.

Dogfood Gate — A2ML fixed at source; K9 tracked

Both sub-jobs were pinned to stale (2026-04-11) action SHAs.

• A2ML: 15 errors. 10 were already-fixed false positives (stale pin); the remaining 5 were the canonical .machine_readable/ tree — an over-strict identity check that rsr-template-repo itself fails. Fixed at source in fix(validate-a2ml): treat whole .machine_readable/ tree as structural-identity a2ml-validate-action#12 (merged); this PR adopts the new pin 59145c7. idaptik A2ML: 0 errors.
• K9: pin un-drifted to 2d96f43. The 6 remaining errors are real but rooted in the k9iser generator emitting contracts without the K9! magic line + pedigree block — tracked as codegen emits K9 files without K9! magic line + pedigree block (fails canonical k9-validate-action) k9iser#8. The K9 sub-job stays red until that lands (not masked).

RSR Anti-Pattern Check

Already returned to green via #82 — no action needed.

Status vs #77

• Tests: ✅ green + gated
• Dogfood Gate: ✅ A2ML half green at source; ⏳ K9 half blocked on k9iser#8
• RSR Anti-Pattern: ✅ already green

Not using Closes #77 — Dogfood Gate is only fully green once k9iser#8 lands.

🤖 Generated with Claude Code

[github-actions]

🔍 Hypatia Security Scan

Findings: 52 issues detected

Severity	Count
🔴 Critical	12
🟠 High	27
🟡 Medium	13

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "No permissions declaration -- add permissions: read-all",
    "type": "missing_permissions",
    "file": "serviceworker-check.yml",
    "action": "add_permissions",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Python file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/idaptik/idaptik/dlc/idaptik-dlc-reversible/robot-repo-bot/_modules/robot_repo.py",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "Deno -A grants all permissions -- use specific --allow-* flags (3 occurrences, CWE-250)",
    "type": "js_deno_all_perms",
    "file": "/home/runner/work/idaptik/idaptik/run.js",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  },
  {
    "reason": "Nickel file missing SPDX-License-Identifier header (1 occurrences, CWE-1104)",
    "type": "ncl_missing_spdx",
    "file": "/home/runner/work/idaptik/idaptik/configs/config.ncl",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "getExn on external data -- use pattern matching (2 occurrences, CWE-754)",
    "type": "getexn_on_external",
    "file": "/home/runner/work/idaptik/idaptik/src/app/devices/VMBridge.res",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "critical"
  },
  {
    "reason": "JSON decode without validation (2 occurrences, CWE-20)",
    "type": "json_decode_no_validation",
    "file": "/home/runner/work/idaptik/idaptik/src/app/proven/SafeJson.res",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "critical"
  },
  {
    "reason": "JSON decode without validation (1 occurrences, CWE-20)",
    "type": "json_decode_no_validation",
    "file": "/home/runner/work/idaptik/idaptik/src/app/screens/BalanceAnalyserModel.res",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "critical"
  },
  {
    "reason": "Obj.magic bypassing type safety (1 occurrences, CWE-704)",
    "type": "obj_magic",
    "file": "/home/runner/work/idaptik/idaptik/src/app/verisimdb/VeriSimDrift.res",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  },
  {
    "reason": "Obj.magic bypassing type safety (1 occurrences, CWE-704)",
    "type": "obj_magic",
    "file": "/home/runner/work/idaptik/idaptik/src/app/verisimdb/VeriSimVcl.res",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  },
  {
    "reason": "Obj.magic bypassing type safety (1 occurrences, CWE-704)",
    "type": "obj_magic",
    "file": "/home/runner/work/idaptik/idaptik/src/app/verisimdb/VeriSimSearch.res",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence