Skip to content

docs: name who calls the safety GenServers, and count lib/ recursively - #1191

Open
hyperpolymath wants to merge 9 commits into
claude/eager-wright-zwwbe2-ledger-hardeningfrom
claude/eager-wright-zwwbe2-safety-callers
Open

hyperpolymath wants to merge 9 commits into
claude/eager-wright-zwwbe2-ledger-hardeningfrom
claude/eager-wright-zwwbe2-safety-callers

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Stacked on the ledger-hardening PR. Fixes two Codex findings on #1030 that still apply on main.

  • EXPLAINME.adoc said Safety.Quarantine and Safety.RateLimiter have no caller in lib/. That is too strong:

    • the application starts both;
    • the Kin watchdog watches the limiter;
    • lib/hypatia/web/api_router.ex and lib/hypatia/web/graphql.ex list quarantines.

    The real gap is that no scan or dispatch path calls either, and the text now says that in both places.

  • .claude/CLAUDE.md told agents to re-measure with ls lib/**/*.ex. Without globstar that matches only one directory level, giving 106 files. It now uses find lib -name "*.ex", and the count is re-measured as 172.

Verification

  • scripts/check-readme-claims.sh passes.
  • EXPLAINME.adoc renders cleanly with asciidoctor 2.0.26.

Not changed: Codex's anchor-before-quoted-scalar finding on #1039 no longer applies. main now reads workflows through Hypatia.Kyaml (#1036), and the reported input parses to the triggers ["workflow_dispatch", "issue_comment"]. That was probed by compiling kyaml.ex and workflow.ex standalone.


Generated by Claude Code

EXPLAINME said Safety.Quarantine and Safety.RateLimiter have no caller in
lib/. The application starts both, the Kin watchdog watches the limiter,
and the REST and GraphQL APIs list quarantines. The gap is narrower: no scan
or dispatch path calls either, and the text now says that.

.claude/CLAUDE.md told agents to re-measure with `ls lib/**/*.ex`, which
without globstar matches only one directory level (106 files, not the
tree). It now uses find, and the count is re-measured: 172.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CYR5bf5FBLS7cXQK72aVNM
Repository owner deleted a comment from coderabbitai Bot Nov 16, 2026
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 16, 2026 19:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T02:05:40.276181Z fea468a New commits
🔒 Security Review ❌ Failed 2026-11-17T02:03:54.917025Z
We couldn’t complete this review. Comment @codex security review to try again.
fea468a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Resolve .claude/CLAUDE.md to main's lib/ count (171, re-measured with
find lib -name "*.ex" | wc -l after #1192 deleted workflow_yaml.ex).

EXPLAINME: the Kin watchdog monitors Safety.RateLimiter and
Safety.Quarantine (lib/kin/watchdog.ex), not the limiter alone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CYR5bf5FBLS7cXQK72aVNM
@sonarqubecloud

Copy link
Copy Markdown

Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026
Repository owner deleted a comment from coderabbitai Bot Nov 17, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants