Repository navigation
docs: name who calls the safety GenServers, and count lib/ recursively - #1191
Open
hyperpolymath wants to merge 9 commits into
Open
hyperpolymath wants to merge 9 commits into
hyperpolymath wants to merge 9 commits into
Conversation
EXPLAINME said Safety.Quarantine and Safety.RateLimiter have no caller in lib/. The application starts both, the Kin watchdog watches the limiter, and the REST and GraphQL APIs list quarantines. The gap is narrower: no scan or dispatch path calls either, and the text now says that. .claude/CLAUDE.md told agents to re-measure with `ls lib/**/*.ex`, which without globstar matches only one directory level (106 files, not the tree). It now uses find, and the count is re-measured: 172. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CYR5bf5FBLS7cXQK72aVNM
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…e/eager-wright-zwwbe2-safety-callers
…e/eager-wright-zwwbe2-safety-callers
…e/eager-wright-zwwbe2-safety-callers
…e/eager-wright-zwwbe2-safety-callers
Resolve .claude/CLAUDE.md to main's lib/ count (171, re-measured with find lib -name "*.ex" | wc -l after #1192 deleted workflow_yaml.ex). EXPLAINME: the Kin watchdog monitors Safety.RateLimiter and Safety.Quarantine (lib/kin/watchdog.ex), not the limiter alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CYR5bf5FBLS7cXQK72aVNM
…e/eager-wright-zwwbe2-safety-callers
…e/eager-wright-zwwbe2-safety-callers
…e/eager-wright-zwwbe2-safety-callers
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Stacked on the ledger-hardening PR. Fixes two Codex findings on #1030 that still apply on
main.EXPLAINME.adoc said
Safety.QuarantineandSafety.RateLimiterhave no caller inlib/. That is too strong:lib/hypatia/web/api_router.exandlib/hypatia/web/graphql.exlist quarantines.The real gap is that no scan or dispatch path calls either, and the text now says that in both places.
.claude/CLAUDE.md told agents to re-measure with
ls lib/**/*.ex. Withoutglobstarthat matches only one directory level, giving 106 files. It now usesfind lib -name "*.ex", and the count is re-measured as 172.Verification
scripts/check-readme-claims.shpasses.EXPLAINME.adocrenders cleanly with asciidoctor 2.0.26.Not changed: Codex's anchor-before-quoted-scalar finding on #1039 no longer applies.
mainnow reads workflows throughHypatia.Kyaml(#1036), and the reported input parses to the triggers["workflow_dispatch", "issue_comment"]. That was probed by compilingkyaml.exandworkflow.exstandalone.Generated by Claude Code