Repository navigation
chore: remove Logtalk files and mentions - #697
Conversation
Delete the 11 rule files (.lgt), the 3 approval sidecars, and the generator, report and workflow code that wrote or read them. Record what each rule detected, and its Hypatia coverage, in shared-context/learning/RETIRED-LOGTALK-RULES.adoc. Reword mentions in docs and audits; drop the report-format key from three NEUROSYM files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
|
CI triage, three groups. Caused by this PR (needs a regenerated lockfile, not yet fixed): Already red on Also red: Generated by Claude Code |
|
…oop.yml #697 removed the "Upload rule proposals" step from learning-loop.yml but left actions/upload-artifact@v7.0.2 under that workflow's lock entry. Main has been red since: check-lock-sync.sh fails on the stale entry and audit-lock-closure.sh reports FATAL WF-ORPHAN, which fails Pinned source closure and, through it, E2E tests. Pruned with standards scripts/prune-stale.sh (the tool step of the lock repair chain), not by hand. The dependencies: record stays: two other workflows still use upload-artifact@v7.0.2. Local, after: check-lock-sync.sh rc=0; audit-lock-closure.sh fatal=0 review=0 accepted=3; lock-closure-test 47 passed, 0 failed (45/2 before); audit-pinned-reusable-sources.sh --fetch-sources findings=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq



Summary
Owner ruling: eliminate Logtalk completely, including the mention of it. This removes every Logtalk rule file and the generator, report and workflow code that wrote or read them, and records what the rules detected before they go.
What was deleted
bots/glambot/bot-integration/src/glambot_findings.lgtshared-context/learning/approved-rules/{eval_usage,technical_debt,unsafe_without_doc}.lgtshared-context/learning/approved-rules/{eval_usage,technical_debt,unsafe_without_doc}.lgt.meta(approval sidecars; the glob in the task did not match them, they are part of the same rules)shared-context/learning/rule-proposals/{eval_usage,getexn_on_external_data,technical_debt,type_safety_bypass,unsafe_crash,unsafe_panic,unsafe_without_doc}.lgtfleet-coordinator.sh:propose_new_rule()(generator with four rule templates) andcreate_rule_approval_pr()(cloned hypatia, pushed a branch, opened a PR, enabled auto-merge), plus the call sites inlearn_from_findings()andgenerate_rules()learning-monitor.sh: the "Rule Proposals" section and the two "next actions" hints that pointed at it.github/workflows/learning-loop.yml: the "Upload rule proposals" step and the proposals block of the summary step.gitignore:/exports/*.lgtWhat was edited
fleet-coordinator.sh: header comment,usage()line forgenerate-rules, a comment inlearn_from_findings().docs/BOT-OPERATIONS.adoc,docs/archive/DOGFOODING-ANALYSIS.adoc,docs/archive/NEW-PATTERNS-DEPLOYMENT-2026-02-06.adoc,bots/finishingbot/ROADMAP.adoc,audits/directive-census-2026-09-26/REPORT.md,audits/fleet-wiring-2026-09-26.md,shared-context/findings/security-audit-20260125.md,shared-context/learning/{ECHIDNA-VALIDATION-SUMMARY,RULE-PROPOSALS-2026-02-06}.adoc. In the dated reports only the Logtalk wording and.lgtfile names changed.NEUROSYM.a2mlfiles (.machine_readable/descriptiles/,robot-repo-automaton/.machine_readable/6a2/,robot-repo-automaton/templates/skeleton/.machine_readable/descriptiles/): the linereport-format = "logtalk"removed, nothing else. Each remains valid TOML. Nothing in this repo reads the key. (Hypatia's own ledger replaced the value with"json"; I did not add that, since the rule is never to add to an.a2ml.)shared-context/learning/RETIRED-LOGTALK-RULES.adoc(plain AsciiDoc,CC-BY-SA-4.0), the record described below.Trace: what read or wrote the rule files
Writers:
fleet-coordinator.shprocess_findings->learn_from_findings->propose_new_rulewroterule-proposals/<type>.lgtonce a pattern type reached 5 observations; in CI it then calledcreate_rule_approval_pr(PR into hypatia, auto-merge).fleet-coordinator.sh generate-rules->generate_rulescalledpropose_new_ruleper pattern type.approved-rules/*.lgtfiles were hand-moved copies of three proposals; the.metasidecars were approval notes.Readers:
learning-loop.yml: uploadedrule-proposals/*.lgtas an artifact and listed them in the step summary.learning-monitor.sh: counted proposals and compared them with a hypatiaengine/rules/auto-learned/directory that no longer exists.approved-rules/*.lgtorglambot_findings.lgt. Thedeploy-approved-rulesjob isif: false, and the glambot file's JSON ingestion was a placeholder that returned nothing.Entry points were already dead:
process_findings,generate_rulesanddeploy_botsreturn 78 (BLOCKED) before any of this code, perdocs/AUTOMATION-QUARANTINE.adoc. So no live behaviour is removed. Deleting the generator also removes the dormant PR-and-auto-merge path into hypatia.Where each rule went
Hypatia (
lib/rules/, read at6f3f16f; I read the Elixir and did not run it):unsafe_without_doccode_safety.exunsafe_block+reject_excused_unsafegetexn_on_external_data(draft)code_safety.exgetexn_on_externalunpinned_actioncicd_rules.exunpinned_action(canonical: WH004 inworkflow_hardening.ex)missing_permissionscicd_rules.exmissing_permissionsmissing_spdxcicd_rules.exmissing_spdxeval_usagecode_safety.exjs_evaleval(onlytechnical_debthonest_completion.ex(TODO and FIXME counts),baseline_health.exBH002No equivalent, recorded in
RETIRED-LOGTALK-RULES.adoc(name, pattern, what it flagged):eval_usageFunction-constructor and stringsetTimeout/setIntervalchecks, the test/production severity split and the CSP suggestion;technical_debtHACK/XXX/BUG markers, priorities and the 50-marker threshold; the glambot findings bridge (presentation-debt, fleet-wide-pattern and related predicates).type_safety_bypass,unsafe_crash,unsafe_panicand the generic template were stubs whose detection clause ended infail; there is nothing to port, and the record says so. I did not invent a new rule format.Checks run
bash -n fleet-coordinator.sh learning-monitor.sh: OK.shellcheck:fleet-coordinator.sh105 -> 90 findings,learning-monitor.sh1 -> 0. No new finding; the rest pre-date this change.bash tests/automation-quarantine-test.sh: all PASS, includinggenerate-rulesexiting 78 withBLOCKED:.actionlint: not installed, not run.yqparses the edited workflow.git grep -n -i -I 'logtalk\|\.lgt\b'on the committed tree: empty.Needs your decision (not guessed)
learning-loop.ymlstill runsprocess-findingsandgenerate-rules. Both exit 78 by design, so the workflow already fails visibly; I left that alone.generate-rulesnow has no function behind it. Retire the command, the steps and thedeploy-approved-rulesjob together if you want.shared-context/learning/rule-deployment-status.jsonstill lists the approved rules (a data record, no Logtalk text); left as is.logtalk_namefields inlib/rules/audit_prevention.ex(outside this change).Kept, with reason
shared-context/learning/RETIRED-LOGTALK-RULES.adoc: the name was specified by the task. Its content does not use the word or the extension, and no other file links to it by name, so the grep stays empty.Generated by Claude Code
Summary by CodeRabbit
generate-rulescommand is marked as retired and blocked.