Repository navigation
feat(rhodibot): any .a2ml is a priority-1 finding; stop expecting retired forms - #690
Conversation
…ired forms Owner directive (2026-11-17): rid the estate of A2ML, and make any .a2ml a priority-1 finding in the relevant bots, rhodibot first. canon (the report-back path): - New severity `retired`, ranked above `missing`. Every tracked *.a2ml is one `rhodibot.no-a2ml` finding (tier P1) at its own path, so the grid can place it against a change. Each names the deed form its family maps to under the standards mapping specs and whether kyX can convert it today (only ECOSYSTEM.a2ml, D313); none asks for an .a2ml or a hand conversion. - counts.retired, a "P1:" summary line, and --fail-on retired (clap and FailOn); a tree with an .a2ml exits 1, a clean one 0. - The legacy read fallback is unchanged: the criterion an old file would satisfy is still "migrate" (relocated), never "missing". GitHub App check (rsr.rs): - `no-*.a2ml` (RSR-A2ML-001): any .a2ml in the default-branch tree is a Required failure under every policy pack; .rsr.toml cannot skip or downgrade it. An unlistable or truncated tree is a Skip naming the reason, never a pass. - RSR-015 (.machine_readable/bot_directives/) is retired: its files were .a2ml and the directives are the chora deed's (bot-directives ...) clause, so demanding the directory demanded a retired form. The legacy .bot_directives/ advice now points at the deed clause. Report-back: `retired` -> `critical` (above `error` -> high). Dogfood: `rhodibot canon --path .` on this repository reports 42 P1 findings, 3 of them (the ECOSYSTEM files) routable to kyX. deed.rs is untouched (#687 owns it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDhFeexmokLqLRfZNce
CI's "The grid accepts the envelopes" failed: the real renderer (standards scripts/verdict-grid.sh) now grades rhodibot's stubbed row purple, because the stub carries a P1 retired .a2ml finding (critical) and critical outranks red. That is the intended effect of this PR, so the check now expects purple and pins the critical count; error -> red stays pinned by ponsbot's row. Reproduced and fixed locally with STANDARDS_DIR set: 228/1 before, 229/0 after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDhFeexmokLqLRfZNce
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3c07a0d80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c53a784f5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…losed Review findings on #690: - A push or PR check now scans the tree at the head it reports on (check_compliance_at / tree_paths_at), not the default branch, so a PR that adds an .a2ml fails on that PR. - A tree that cannot be listed fails the Required check and clears required_passed, instead of a Skip that left the run green. - The report carries the retired paths (retired_a2ml), and the fleet gets one finding per file at its real path, never one at the wildcard. - Displayed paths are escaped (control characters, then Markdown) before they reach the check-run text; matching uses the raw path. - canon's git listing uses ls-files -z, so a C-quoted name cannot slip past the .a2ml suffix test. - *file.a2ml routes to a contractile deed only under a contractiles/ path. - The README names kyX's invocation and #691 instead of a script this PR does not add. Each fix has a test; the head-SHA and ls-files tests were mutation-checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDhFeexmokLqLRfZNce
|
…write reports safely Review findings on #691, each with a test that fails on the previous code (18 new checks fail there, all 67 pass here): - family_of uses '|', not a tab: IFS whitespace collapsed an empty spec, so a contractile reported spec "0" and linked mappings/0. - .a2ml paths stay NUL-delimited through filter, sort and mapfile, so a name with a newline is refused whole instead of split. - jq and sha256sum are checked before anything is classified (exit 69). - jq gets -- before positional reasons, so a reason starting with '-' is data. - The chora deed comes from the index and must be unmodified; the source must be unmodified; .machine_readable/descriptiles must not be a symlink; the target must not be gitignored. All asked before kyX runs. - Staging is all-or-nothing, with a rollback and a refusal on failure. - The random work directory is replaced by <work> in reasons, so a refusal keeps its fingerprint across runs. - A2ML_REPORT_DIR is resolved physically before the containment check; existing non-regular report paths are refused; reports are renamed into place, never written through a link. - The census decodes \u/\U escapes in multi-line strings too. - *file.a2ml is a contractile only under contractiles/ (as rhodibot, #690). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDhFeexmokLqLRfZNce



Why
The owner's directive (2026-11-17): rid the estate of A2ML, and make any
.a2mla priority-1 finding in the relevant bots, starting with rhodibot. Today rhodibot reports a legacy.a2mlonly asrelocated(→ info on the grid), and its GitHub App check still demanded.machine_readable/bot_directives/, a directory whose files were.a2ml.What
canon(the report-back path)retired, ranked abovemissing. Every tracked*.a2mlbecomes onerhodibot.no-a2mlfinding (tierP1) at its own path, so the grid can place it against a change.ECOSYSTEM.a2mlcan (D313). A finding never asks for an.a2mland never suggests hand conversion.counts.retired, aP1:summary line, and--fail-on retired.GitHub App check (
rsr.rs)no-*.a2ml(RSR-A2ML-001): any.a2mlin the default-branch tree is a Required failure under every policy pack, and.rsr.tomlcannot skip or downgrade it.Skipthat names the reason, never a pass..machine_readable/bot_directives/was demanding a retired form, since bot directives are now the deed's(bot-directives …)clause. The legacy.bot_directives/advice now points at that clause.Report-back:
retired→critical, aboveerror(high).Dogfood:
rhodibot canon --path .on this repo42 P1 findings, worst first. Only 3 (the ECOSYSTEM files) can be routed to kyX. The other 39 (CLADE, STATE, META, AGENTIC, contractiles, bot directives, session logs, the vendored canon…) have no kyX front end, or no mapping spec at all.
--fail-on retiredexits 1 here and 0 on a clean tree.rhodibot is enrolled here without
gating, so these show on this repo's grid as advisory and don't block.Validation (local)
-D warningsis clean, rustfmt is clean, andcheck-canon-drift.shis OK.tests/fleet-report-back-test.sh: 214 passed, including new checks thatretired→criticaland that the finding is placed at its path. The build test: 69 passed.Coordination
bots/rhodibot/src/deed.rsis untouched. #687 owns it, so the two merge independently.Rollout note
Repos that call
fleet-report-back-reusable.ymlat an older fleet SHA keep the old behaviour. The P1 rule reaches them only when their pin moves; the rollout options are in the companion fixer PR.Generated by Claude Code