Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ jobs:
dir: bots/ponsbot
- module: idris-dependents
dir: idris-dependents
# deed-reader: the shared, std-only reader for <repo>_chora.deed.
- module: deed-reader
dir: deed-reader
# finishingbot reads the chora deed through deed-reader; it was
# never built, tested or linted in CI before (2026-11-17). glambot
# also uses deed-reader but stays out until its pre-existing clippy
# debt (about 60 diagnostics under -D warnings) is paid.
- module: finishingbot
dir: bots/finishingbot
defaults:
run:
working-directory: ${{ matrix.dir }}
Expand Down
5 changes: 5 additions & 0 deletions bots/finishingbot/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions bots/finishingbot/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ keywords = ["release", "validation", "ci-cd", "compliance", "gitbot-fleet"]
categories = ["development-tools", "command-line-utilities"]

[dependencies]
# Repo deed reader (shared, std-only, in-repo)
gitbot-deed-reader = { path = "../../deed-reader" }

# Async runtime
tokio = { version = "1.52.3", features = ["full"] }

Expand Down
18 changes: 13 additions & 5 deletions bots/finishingbot/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,28 @@
# Cerro Torre - The Challenging Peak
# Patagonian mountain known for difficulty and technical climbing
# Purpose: Release readiness validation (conquering the final ascent)
#
# Build from the REPOSITORY ROOT, so the in-repo deed-reader crate is in the
# context (finishingbot reads the chora deed through it):
# podman build -f bots/finishingbot/Containerfile -t cerro-torre .

FROM docker.io/library/rust:latest AS builder

WORKDIR /build
WORKDIR /build/bots/finishingbot

# Install dependencies and nightly toolchain
RUN apt-get update && \
apt-get install -y pkg-config libssl-dev && \
rm -rf /var/lib/apt/lists/* && \
rustup default nightly

# Copy source
COPY Cargo.toml Cargo.lock ./
COPY src ./src
# Copy source, keeping the repository layout so ../../deed-reader resolves
COPY deed-reader /build/deed-reader
COPY bots/finishingbot/Cargo.toml bots/finishingbot/Cargo.lock ./
COPY bots/finishingbot/src ./src
# Cargo.toml declares a [[bench]]; without it the manifest does not parse
# (this image failed to build on main for that reason alone).
COPY bots/finishingbot/benches ./benches

# Remove path dependency that isn't available in container context
RUN sed -i '/gitbot-shared-context.*path.*optional/d' Cargo.toml && \
Expand All @@ -32,7 +40,7 @@ RUN apt-get update && \
apt-get install -y ca-certificates libssl3 && \
rm -rf /var/lib/apt/lists/*

COPY --from=builder /build/target/release/finishing-bot /usr/local/bin/cerro-torre
COPY --from=builder /build/bots/finishingbot/target/release/finishing-bot /usr/local/bin/cerro-torre

# Run as non-root
RUN useradd -r -s /bin/false cerro-torre
Expand Down
8 changes: 4 additions & 4 deletions bots/finishingbot/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ the gitbot-fleet shared context layer and makes the final release-readiness dete
|Version consistency across files, debug statement detection, sensitive data patterns, SECURITY.md, release profiles
|No

|**SCM Files**
|Legacy `.machine_readable/` SCM files (STATE.scm, META.scm, ECOSYSTEM.scm, PLAYBOOK.scm, AGENTIC.scm, NEUROSYM.scm) are validated only if present (SPDX headers, required sections, content completeness); their absence is canonical, since those descriptiles are now clauses of `<name>_chora.deed`
|**Repo Deed** (the `scm_files` report key)
|Reads the one `<repo>_chora.deed` at the root (through `deed-reader/`): none is DEED-001 (warning), more than one is DEED-002 (error, D312), unreadable or not a `repo-deed` is DEED-003 (error), no `(status …)` or `(maturity …)` clause and no `.machine_readable/descriptiles/STATE.deed` is DEED-004 (warning). A retired STATE, META, ECOSYSTEM, PLAYBOOK, AGENTIC or NEUROSYM `.scm` at the root, under `.machine_readable/` or under `.machine_readable/6scm/` is SCM-006 (warning, "migrate"): it is not validated and is never to be moved
|No

|**Testing**
Expand Down Expand Up @@ -179,7 +179,7 @@ The analyzers accept the estate's canonical locations, not only one spelling:
* `mise.toml` in place of `.tool-versions` (TOOL-001).
* `tests/fuzz/` as well as `fuzz/` and `.clusterfuzzlite/` (TEST-RU-003); a crate with no code yet (no `.rs` line that is not blank or a comment) is exempt from TEST-RU-005 and TEST-RU-006.
* A workflow named by file name in prose resolves under `.github/workflows/` (CLM-006).
* SCM-001 is retired: STATE, META, ECOSYSTEM, PLAYBOOK, AGENTIC and NEUROSYM are clauses of `<name>_chora.deed`, not files.
* SCM-001 to SCM-005 are retired: STATE, META, ECOSYSTEM, PLAYBOOK, AGENTIC and NEUROSYM are clauses of `<name>_chora.deed`, not files, so a legacy `.scm` is neither required nor validated, and SCM-005 no longer advises moving one into `.machine_readable/` (a retired layout).
* REL-008 matches key material (PEM headers, AWS key ids, vendor token shapes, long key literals), not the words "private key".

A repository can acknowledge a finding in its `.hypatia-baseline.json`, the estate's documented exemption mechanism (`docs/upstream-proposals/standards--hypatia-baseline-consumer/docs/EXEMPTION-MECHANISMS.adoc`, "Layer 2"). `.hypatia-ignore` is not read: that document rejects it. An entry uses this bot's `rule_module`, `finishing_bot`, and the finding id as `type`, with the estate severity word (error = `high`, warning = `medium`, info = `info`, suggestion = `low`) and exactly one of `file` or `file_pattern`: `{"severity": "medium", "rule_module": "finishing_bot", "type": "PH-001", "file_pattern": "build/just/**", "note": "scanner names the tokens"}`. Matching is exact on severity, module and type, so a rule family needs one entry per id. Entries past `expires_at`, or carrying `severity_override` (this bot does not downgrade), acknowledge nothing; other modules' entries (`cicd_rules`, ...) are Hypatia's and are not read. Currently only the placeholder analyzer (PH-nnn, hence PH-100) honours it. See `src/baseline.rs`.
Expand Down Expand Up @@ -418,7 +418,7 @@ src/
placeholder.rs Placeholder detection and removal
claims.rs Documentation claims verification
release.rs Release artifact and security checks
scm_files.rs .machine_readable/ SCM file validation
scm_files.rs Repo deed (<repo>_chora.deed) checks; retired .scm reported as "migrate"
testing.rs Testing infrastructure analysis
tooling.rs Tooling and CI workflow validation
v1_readiness.rs V1 release readiness assessment
Expand Down
Loading
Loading