Skip to content

proofs/characteristic: mark EchoVs* header references as historical - #384

Open
hyperpolymath wants to merge 1 commit into
mainfrom
docs/agda-comments-echovs
Open

hyperpolymath wants to merge 1 commit into
mainfrom
docs/agda-comments-echovs

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Follow-up to #379. The headers of ten proofs/agda/characteristic/*.agda modules named EchoVsQuotient.agda and EchoVsGalois.agda as if they were present. Neither module is in the tracked tree. The comment now says the 2-cell argument historically rested on the EchoVsQuotient and EchoVsGalois modules, which are absent and not current checked evidence. This matches the wording #379 used in the docs.

Files: ChoreoInjective, InteractionTest, ModeGraded, RecipeNonTriviality, RecipeSpec, RecipeTheorem, RoleGraded, RoleMode, RoleModeGrade, RoleRole.

Comment lines only. No code, pragma or import changed (the diff has only -- lines), and nothing was added to or removed from All.agda or Smoke.agda.

Verification

Local run with the CI toolchain from scripts/setup-agda.sh (Agda 2.7.0.1, stdlib 8326c74, absolute-zero 8a3162a), on 140002f plus this commit:

  • --safe --without-K --cubical-compatible --ignore-interfaces on characteristic/All.agda, All.agda and Smoke.agda: exit 0 each. The existing --cubical-compatible warnings in from-to definitions are unchanged and unrelated.
  • sh scripts/kernel-guard.sh: PASS.
  • bash tools/check-guardrails.sh proofs/agda: OK (152 modules).

This is a local run, not a CI receipt.


Generated by Claude Code

…historical

The ten characteristic modules' headers named EchoVsQuotient.agda and
EchoVsGalois.agda as if present. Neither module is in the tracked tree.
Comment-only change; no code, pragma or import touched.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDi1YcoUEuuFkNCPByz
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that cited historical 2-cell evidence comes from submodules absent from the tracked project and is not currently checked evidence.
    • Clarified which arguments support claims of distinctness, distinguishing them from the integration argument.

Ten Agda characteristic module comments now describe the cited Sophisticated submodules as historical, absent from the tracked tree, and not current checked evidence. The comments retain distinctions between the 2-cell, truncation, and integration arguments.

Changes: Historical evidence comments

Layer / File(s) Summary
Clarify historical evidence status
proofs/agda/characteristic/ChoreoInjective.agda, proofs/agda/characteristic/InteractionTest.agda, proofs/agda/characteristic/ModeGraded.agda, proofs/agda/characteristic/RecipeNonTriviality.agda, proofs/agda/characteristic/RecipeSpec.agda, proofs/agda/characteristic/RecipeTheorem.agda, proofs/agda/characteristic/RoleGraded.agda, proofs/agda/characteristic/RoleMode.agda, proofs/agda/characteristic/RoleModeGrade.agda, proofs/agda/characteristic/RoleRole.agda
The comments identify the cited Sophisticated submodules as historical and absent from the tracked tree. They clarify that the references are not current checked evidence and retain statements about which arguments establish distinctness.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to de132

This change only clarifies in comments that two referenced modules are historical and are not current checked evidence. It does not affect behavior, and merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the EchoVsQuotient and EchoVsGalois header references in the characteristic Agda modules are now marked as historical. It is specific and matches the changeset and obj…
Description check Passed The description states the purpose (ten characteristic modules name absent EchoVs modules as if present, now marked historical), lists the affected files, and reports comment-only changes with a local…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the EchoVsQuotient and EchoVsGalois header references in the characteristic Agda modules are now marked as historical. It is specific and matches the changeset and objectives.

Full details: Description check

Explanation

The description states the purpose (ten characteristic modules name absent EchoVs modules as if present, now marked historical), lists the affected files, and reports comment-only changes with a local verification run. It is directly related to the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1093e148-12f0-415d-b898-3b55512a9309
Commits

Reviewing files that changed from the base of the PR and between 140002f and de13258.

Files selected for processing: 10

  • proofs/agda/characteristic/ChoreoInjective.agda
  • proofs/agda/characteristic/InteractionTest.agda
  • proofs/agda/characteristic/ModeGraded.agda
  • proofs/agda/characteristic/RecipeNonTriviality.agda
  • proofs/agda/characteristic/RecipeSpec.agda
  • proofs/agda/characteristic/RecipeTheorem.agda
  • proofs/agda/characteristic/RoleGraded.agda
  • proofs/agda/characteristic/RoleMode.agda
  • proofs/agda/characteristic/RoleModeGrade.agda
  • proofs/agda/characteristic/RoleRole.agda

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 3

  • GitHub Check: CodeRabbit
  • GitHub Check: fleet / Fleet report-backs
  • GitHub Check: cold-check

@linear-code
linear-code Bot marked this pull request as ready for review November 18, 2026 01:25
@hyperpolymath hyperpolymath assigned Copilot and unassigned Copilot Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants