Skip to content

proofs: strict pragma sweep (exact-split, no-sized-types, no-guardedness) - #377

Merged
hyperpolymath merged 1 commit into
mainfrom
proofs/strict-pragma-sweep
Nov 16, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
proofs/strict-pragma-sweep

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Pragma-only change. Ten modules now carry exactly
{-# OPTIONS --safe --without-K --cubical-compatible --exact-split --no-sized-types --no-guardedness #-}:

All, Smoke, AuditSmoke, Echo/Measure/Composition, EchoDependentPushforward, EchoFiniteResidue, EchoResidueProtocol, EchoSourcePreserving, EchoSourcePreservingComparison, EchoThermodynamicsArbitrary.

No overlapping-clause fixes were needed: every module passed --exact-split unchanged. No CATCHALL, no flag weakened, no postulates introduced. Each diff is the one OPTIONS line.

Deliberately not changed

  • EchoImageFactorizationPropCubical.agda: the --cubical island keeps its own profile.
  • EchoImageFactorizationPropPostulated.agda: the quarantined postulate shadow ({-# OPTIONS --without-K #-}, four postulates). --safe rejects postulate, so the requested pragma cannot apply without changing what the module is. Left as is. It is outside every CI root.
  • EchoCNOBridge, EchoCNOSemantics, EchoCNOPackaging: left to CNO bridges: repin absolute-zero to 8a3162a (pc-driven machine) #376. grep -rL therefore still lists these three plus the two modules above (5 files).

Verification (local, Agda 2.7.0.1 via AGDA_TOOLS_DIR=/tmp/echo-agda bash scripts/setup-agda.sh; source /tmp/echo-agda/env.sh)

Static guards, all exit 0:

  • sh scripts/kernel-guard.sh: PASS
  • bash scripts/check-experimental-aggregate.sh: OK
  • bash scripts/test-experimental-aggregate.sh: PASS
  • sh scripts/check-agda-invocations.sh: OK
  • bash tools/check-guardrails.sh proofs/agda: OK (152 modules)

Cold typechecks (agda --no-libraries -i "$AGDA_STDLIB" -i "$ABSOLUTE_ZERO_AGDA" --ignore-interfaces --safe --without-K --cubical-compatible -i proofs/agda <root>), each exit 0, no errors or warnings in output:

  • All, Smoke, AuditSmoke, characteristic/All, examples/All, experimental/echo-additive/All, NarrowingSmoke

Cubical island (... --ignore-interfaces --safe --cubical ... EchoImageFactorizationPropCubical.agda): exit 0.

Not run locally: the Rocq/Lean recheck legs (unaffected by this change). CI has not yet run on this PR; nothing here claims it passed.

Note: #376 also edits Smoke.agda (other lines); a pragma-line-only change should not conflict.


Generated by Claude Code

Add --exact-split --no-sized-types --no-guardedness (and
--cubical-compatible where missing) to the OPTIONS line of ten modules.
Pragma-only change; no proof text touched.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDgtB5aF31cgQadaMa5
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Standardised verification settings across the formal proof suite, retaining safe-mode checks while enforcing stricter definition and termination requirements.

Ten Agda modules update their compiler options. The changes add --exact-split, --no-sized-types and --no-guardedness; some modules also add --cubical-compatible.

Changes: Agda pragma updates

Layer / File(s) Summary
Update module compiler options
proofs/agda/All.agda, proofs/agda/AuditSmoke.agda, proofs/agda/Echo/Measure/Composition.agda, proofs/agda/EchoDependentPushforward.agda, proofs/agda/EchoFiniteResidue.agda, proofs/agda/EchoResidueProtocol.agda, proofs/agda/EchoSourcePreserving.agda, proofs/agda/EchoSourcePreservingComparison.agda, proofs/agda/EchoThermodynamicsArbitrary.agda, proofs/agda/Smoke.agda
The options pragmas add --exact-split, --no-sized-types and --no-guardedness. All.agda, EchoThermodynamicsArbitrary.agda and Smoke.agda also add --cubical-compatible. Existing options remain enabled.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • hyperpolymath/echo-types#376: This PR applies the same strict pragma set to three CNO bridge modules that this change leaves unchanged, and splits the pragma updates across both PRs.
Merge Risk: Minimal · up to 942de

This is a pragma-only tightening of proof module options with no runtime behavior change. Any incompatibility would show up as a typecheck failure in CI, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: a strict pragma sweep that adds the exact-split, no-sized-types and no-guardedness OPTIONS flags to the Agda proof modules. The raw summary and objectives confirm that…
Description check Passed The description states that the change is pragma-only and lists the ten affected modules with the exact OPTIONS line. It also covers the deliberately unchanged files, the verification steps and the fa…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: a strict pragma sweep that adds the exact-split, no-sized-types and no-guardedness OPTIONS flags to the Agda proof modules. The raw summary and objectives confirm that each changed file only modifies its OPTIONS pragma line.

Full details: Description check

Explanation

The description states that the change is pragma-only and lists the ten affected modules with the exact OPTIONS line. It also covers the deliberately unchanged files, the verification steps and the fact that CI has not run. This matches the changeset described in the raw summary and objectives.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f9ecdb09-c69c-4bab-b1e1-d72a623f8fa8
Commits

Reviewing files that changed from the base of the PR and between 5549185 and 942de47.

Files selected for processing: 10

  • proofs/agda/All.agda
  • proofs/agda/AuditSmoke.agda
  • proofs/agda/Echo/Measure/Composition.agda
  • proofs/agda/EchoDependentPushforward.agda
  • proofs/agda/EchoFiniteResidue.agda
  • proofs/agda/EchoResidueProtocol.agda
  • proofs/agda/EchoSourcePreserving.agda
  • proofs/agda/EchoSourcePreservingComparison.agda
  • proofs/agda/EchoThermodynamicsArbitrary.agda
  • proofs/agda/Smoke.agda

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 24

  • GitHub Check: CodeRabbit
  • GitHub Check: governance / JS runtimes — pnpm
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / JS runtimes — bun
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / JS runtimes — deno
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / JS runtimes — environment provisions Bun first
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / UUID v8 conformance
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / UUID v7 conformance
  • GitHub Check: fleet / Fleet report-backs
  • GitHub Check: check
  • GitHub Check: Bit-narrowing exhibit
  • GitHub Check: Experimental echo-additive
  • GitHub Check: cold-check
  • GitHub Check: analyze (javascript-typescript, none)
Additional context used

Learnings: 2

Learning: 2026-10-31T20:51:46.566Z

Learnt from: CR
Repo: hyperpolymath/echo-types PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T20:51:46.566Z
Learning: Source excerpt:
# Working rules in this repo

- `--safe --without-K` throughout.

Applied to files:

  • proofs/agda/Echo/Measure/Composition.agda
  • proofs/agda/EchoDependentPushforward.agda
  • proofs/agda/EchoResidueProtocol.agda
  • proofs/agda/EchoSourcePreservingComparison.agda
  • proofs/agda/EchoThermodynamicsArbitrary.agda
Learning: 2026-11-04T17:52:29.962Z

Learnt from: CR
Repo: hyperpolymath/echo-types PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-11-04T17:52:29.962Z
Learning: Source excerpt:
# Proof policy

The normative estate policy is
https://github.com/hyperpolymath/standards/blob/main/3-practice/PROOF-POLICY.adoc.
Its default Agda theory profile is `--safe --without-K --cubical-compatible`;
full Cubical proofs require a separate reviewed profile. Record toolchain,
assumptions, results and exact source revisions; historical checks do not
prove the new profile. Mathesis grades are theorem- and receipt-specific.

Applied to files:

  • proofs/agda/EchoSourcePreservingComparison.agda

@linear-code
linear-code Bot marked this pull request as ready for review November 16, 2026 19:50
@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 16, 2026 19:51
@hyperpolymath
hyperpolymath merged commit 6bc52b8 into main Nov 16, 2026
41 checks passed
@hyperpolymath
hyperpolymath deleted the proofs/strict-pragma-sweep branch November 16, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants