Skip to content

ci(static-analysis-gate): run the Hypatia scan on OTP 27.3.4.19, not 28.3 - #211

Open
hyperpolymath wants to merge 3 commits into
mainfrom
claude/clever-heisenberg-q9qp32-otp
Open

hyperpolymath wants to merge 3 commits into
mainfrom
claude/clever-heisenberg-q9qp32-otp

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

In static-analysis-gate.yml, the Hypatia scan job pinned OTP '28.3'. On OTP 28.3, :httpc resends credentials to another origin on a redirect. It did so for both an authorization header and URL credentials, in 20 of 20 cases, measured on loopback on 2026-11-17. 27.3.4.19 forwards neither, and it is the release that Hypatia pins in mise.toml and in its CI.

Changes

  1. OTP pin (first commit): '28.3' becomes '27.3.4.19' in that job. The scan job does not pass a secret to :httpc, so this keeps the gate on the pinned runtime rather than stopping a live leak.
  2. Duplicate Hypatia job removed (ci(static-analysis-gate): drop the second Hypatia scan #213, merged into this branch at b47856f). The rsr-template-repo static-analysis-gate.yml no longer runs Hypatia. Hypatia runs once, through hypatia-scan.yml and the standards reusable workflow. deposit-findings now needs only panic-attack-assail and patch-bridge-triage, and the header comment says so. The OTP pin in change 1 goes away with the job.
  3. quinn-udp 0.5.16 in Cargo.lock (f865fc7), ported from fix(deps): bump quinn-udp to 0.5.16 in Cargo.lock (RUSTSEC-2026-0538) #210 so that the cargo audit job is green here too. It becomes a no-op once fix(deps): bump quinn-udp to 0.5.16 in Cargo.lock (RUSTSEC-2026-0538) #210 merges.

Before merge

actions.lock on main still pins seven entries to hyperpolymath/standards@740c9d7, but #203 moved those callers to metadatastician/standards. The lock should be regenerated first, as tracked in #212. Run the standards scripts/update-actions-lock.sh with an authenticated GitHub CLI. actions.lock belongs to the tool, so it is not edited by hand here.


Generated by Claude Code

…28.3

OTP 26 has no release that is safe here. Measured on loopback on
2026-11-17 for 301, 302, 303, 307 and 308, GET and POST, to another port
and another host: OTP 26.2.5.21, the newest 26 build, forwards an
explicit authorization header in 20 of 20 cross-origin redirects, and
credentials from the URL (sent as Basic auth) in 20 of 20. OTP 27.3.4.19
forwards neither (0 of 20 each). OTP 28.3 also forwards both.

27.3.4.19 is the release that Hypatia pins in mise.toml and its CI, and
that the standards Hypatia reusable uses.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDgzT72Tq2HTJmikyNg
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated the environment used for automated static analysis. This internal maintenance change does not alter the application’s features or behaviour, and no changes to the end-user experience are included. There is nothing new for users to configure or learn as a result of this update.

The Hypatia scan job now configures Erlang/OTP version 27.3.4.19 instead of 28.3. The Elixir version remains 1.19.4.

Changes: Hypatia Scan Configuration

Layer / File(s) Summary
Update the Hypatia OTP version
.github/workflows/static-analysis-gate.yml
The Hypatia job now uses Erlang/OTP version 27.3.4.19 instead of 28.3.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: Minimal · up to f865f

Merge Risk: ⚪ Minimal · up to f865f

This moves the Hypatia scan job to an earlier OTP version, matching the version Hypatia itself pins. No concrete merge-blocking risk was found. The CI job's first run on the new runtime will confirm it works.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: the Hypatia scan in the static-analysis gate workflow moves from OTP 28.3 to OTP 27.3.4.19. It matches the one-line change in static-analysis-gate.yml and the stated object…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is specific and related to the changeset. It explains that the Hypatia scan job pinned OTP '28.3', which forwarded credentials across cross-origin redirects, and that the change moves …
Full details: Title check

Explanation

The title names the change: the Hypatia scan in the static-analysis gate workflow moves from OTP 28.3 to OTP 27.3.4.19. It matches the one-line change in static-analysis-gate.yml and the stated objective. The title is specific and does not overstate the change.

Full details: Description check

Explanation

The description is specific and related to the changeset. It explains that the Hypatia scan job pinned OTP '28.3', which forwarded credentials across cross-origin redirects, and that the change moves the job to OTP '27.3.4.19'. It also covers the removal of a duplicate Hypatia job, a quinn-udp lockfile update, and a pre-merge actions.lock regeneration step. Some of these described changes are not in the file-level summary, but the description is clearly on topic for the PR.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6dde5acd-d4ba-400e-b1d4-e26815caf595
Commits

Reviewing files that changed from the base of the PR and between 7a5b8c4 and 241dc04.

Files selected for processing: 1

  • .github/workflows/static-analysis-gate.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 8

  • GitHub Check: CodeRabbit
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: E2E — Unit, P2P and End-to-End
  • GitHub Check: Theory proofs (Agda, Lean, Rocq)
  • GitHub Check: Dependency audit
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Migrations + schema drift
  • GitHub Check: Proof protocol contracts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Nov 17, 2026
@linear-code
linear-code Bot marked this pull request as ready for review November 17, 2026 00:31
Ported from #210 so this PR's Dependency audit job passes. cargo audit
fails on main for quinn-udp 0.5.14, which is in Cargo.lock only through
an inactive optional path. Once #210 merges, this commit is a no-op.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDgzT72Tq2HTJmikyNg

Copy link
Copy Markdown
Owner Author

The Dependency audit failure did not come from this PR. cargo audit reports RUSTSEC-2026-0538 for quinn-udp 0.5.14, and main fails the same way. #210 fixes it by bumping that crate in the lockfile, and f865fc7 ports the same Cargo.lock bump here. Locally, cargo audit now reports only the allowed warning. Once #210 merges, this commit becomes a no-op.


Generated by Claude Code

## Summary

Stacked on #211. It waits on #212, the lockfile regeneration.

`hypatia-scan.yml` already runs Hypatia through the standards reusable.
`static-analysis-gate.yml` ran it a second time. Because its build step
carried `continue-on-error`, that copy passed even when the Hypatia
build failed. The rsr-template-repo gate dropped the same job in
2026-10, and the owner ruled on 2026-11-17 that echidnabot matches the
template.

## Changes

- `.github/workflows/static-analysis-gate.yml`:
  - deletes the `hypatia-scan` job;
- `deposit-findings` no longer needs it and no longer downloads
`hypatia-findings`;
- the unified report now holds the panic-attack findings and the
patch-bridge report;
  - the header says where Hypatia runs instead.

## Checks

- **Required checks:** "Hypatia neurosymbolic scan" is not one of
`main`'s required status checks (repo rulesets read on 2026-11-17), so
removing the job blocks nothing.
- **YAML:** the workflow parses, and its jobs are now
`panic-attack-assail`, `patch-bridge-triage` and `deposit-findings`.
- **actions.lock:** still lists `erlef/setup-beam@v1.24.1` for this
workflow, which gh-actions-lock v0.2.0 reports as `stale`. The lockfile
is tool-owned and not edited by hand. It is regenerated in #212,
together with the seven `hyperpolymath/standards` entries already stale
on `main`.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01J4QvDgzT72Tq2HTJmikyNg)_

Co-authored-by: Claude <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants