Repository navigation
ci(static-analysis-gate): run the Hypatia scan on OTP 27.3.4.19, not 28.3 - #211
hyperpolymath wants to merge 3 commits into
Conversation
…28.3 OTP 26 has no release that is safe here. Measured on loopback on 2026-11-17 for 301, 302, 303, 307 and 308, GET and POST, to another port and another host: OTP 26.2.5.21, the newest 26 build, forwards an explicit authorization header in 20 of 20 cross-origin redirects, and credentials from the URL (sent as Basic auth) in 20 of 20. OTP 27.3.4.19 forwards neither (0 of 20 each). OTP 28.3 also forwards both. 27.3.4.19 is the release that Hypatia pins in mise.toml and its CI, and that the standards Hypatia reusable uses. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDgzT72Tq2HTJmikyNg
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
Ported from #210 so this PR's Dependency audit job passes. cargo audit fails on main for quinn-udp 0.5.14, which is in Cargo.lock only through an inactive optional path. Once #210 merges, this commit is a no-op. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDgzT72Tq2HTJmikyNg
|
The Dependency audit failure did not come from this PR. Generated by Claude Code |
## Summary Stacked on #211. It waits on #212, the lockfile regeneration. `hypatia-scan.yml` already runs Hypatia through the standards reusable. `static-analysis-gate.yml` ran it a second time. Because its build step carried `continue-on-error`, that copy passed even when the Hypatia build failed. The rsr-template-repo gate dropped the same job in 2026-10, and the owner ruled on 2026-11-17 that echidnabot matches the template. ## Changes - `.github/workflows/static-analysis-gate.yml`: - deletes the `hypatia-scan` job; - `deposit-findings` no longer needs it and no longer downloads `hypatia-findings`; - the unified report now holds the panic-attack findings and the patch-bridge report; - the header says where Hypatia runs instead. ## Checks - **Required checks:** "Hypatia neurosymbolic scan" is not one of `main`'s required status checks (repo rulesets read on 2026-11-17), so removing the job blocks nothing. - **YAML:** the workflow parses, and its jobs are now `panic-attack-assail`, `patch-bridge-triage` and `deposit-findings`. - **actions.lock:** still lists `erlef/setup-beam@v1.24.1` for this workflow, which gh-actions-lock v0.2.0 reports as `stale`. The lockfile is tool-owned and not edited by hand. It is regenerated in #212, together with the seven `hyperpolymath/standards` entries already stale on `main`. --- _Generated by [Claude Code](https://claude.ai/code/session_01J4QvDgzT72Tq2HTJmikyNg)_ Co-authored-by: Claude <noreply@anthropic.com>
|



Summary
In
static-analysis-gate.yml, the Hypatia scan job pinned OTP'28.3'. On OTP 28.3,:httpcresends credentials to another origin on a redirect. It did so for both anauthorizationheader and URL credentials, in 20 of 20 cases, measured on loopback on 2026-11-17. 27.3.4.19 forwards neither, and it is the release that Hypatia pins inmise.tomland in its CI.Changes
'28.3'becomes'27.3.4.19'in that job. The scan job does not pass a secret to:httpc, so this keeps the gate on the pinned runtime rather than stopping a live leak.static-analysis-gate.ymlno longer runs Hypatia. Hypatia runs once, throughhypatia-scan.ymland the standards reusable workflow.deposit-findingsnow needs onlypanic-attack-assailandpatch-bridge-triage, and the header comment says so. The OTP pin in change 1 goes away with the job.Cargo.lock(f865fc7), ported from fix(deps): bump quinn-udp to 0.5.16 in Cargo.lock (RUSTSEC-2026-0538) #210 so that thecargo auditjob is green here too. It becomes a no-op once fix(deps): bump quinn-udp to 0.5.16 in Cargo.lock (RUSTSEC-2026-0538) #210 merges.Before merge
actions.lockon main still pins seven entries tohyperpolymath/standards@740c9d7, but #203 moved those callers tometadatastician/standards. The lock should be regenerated first, as tracked in #212. Run the standardsscripts/update-actions-lock.shwith an authenticated GitHub CLI.actions.lockbelongs to the tool, so it is not edited by hand here.Generated by Claude Code