Skip to content

chore: delete the quarantined retired rule module and its last mentions - #516

Open
hyperpolymath wants to merge 6 commits into
mainfrom
claude/retire-logtalk
Open

hyperpolymath wants to merge 6 commits into
mainfrom
claude/retire-logtalk

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

The repo owner wants the retired rule language removed from the estate entirely. Here that meant:

  • the archived rule file and README in archive/logtalk/, quarantined on 2026-11-01;
  • one commented-out report-format value in the playground's NEUROSYM;
  • some explanatory prose.

The semantics of the archived file already live in hyperpolymath/hypatia: lib/rules/security_errors.ex, checked by the Agda model AlertTableCorrespondence.agda (hyperpolymath/hypatia#1185). Git history keeps the deleted file; it is recoverable at 478b751.

Changes

  • Archive deleted. archive/logtalk/ is removed, with its .machine_readable/root-allow.txt entry and the archive/* line in .reuse/dep5. archive/ held nothing else.
  • Docs. docs/DEBT.adoc, docs/ECOSYSTEM-INTEGRATION.adoc and docs/PROOF-STATUS.adoc no longer point at the quarantine. ECOSYSTEM-INTEGRATION keeps the live fact: Hypatia's rule engine is Elixir, and ECHIDNA is a scan target, not a rule producer.
  • Playground NEUROSYM. echidna-playground/.machine_readable/descriptiles/NEUROSYM.a2ml now declares report-format = "json", Hypatia's canonical format, in place of the commented-out retired value.
  • Recon report. docs/reports/2026-11-01-routing-and-rule-engine-recon.adoc is reworded to "the retired rule engine", with 2026-11-16 follow-ups recording the deletion. Its anchors and section references still work.

RSR Quality Checklist

Required

  • Tests pass. No code changed; the checks that read the touched files pass, listed under Testing.
  • Code is formatted. No code changed.
  • Linter is clean. reuse lint was already failing on main, with the same 24 invalid SPDX expressions before and after; only the two deleted files leave its counts.
  • No banned language patterns. The PR removes the last one.
  • No unsafe blocks without // SAFETY: comments
  • No banned functions
  • SPDX license headers present on all new/modified source files
  • No secrets, credentials, or .env files included

As Applicable

  • Documentation updated

Testing

  • INPUT_STRICT=true bash .github/hooks/validate-a2ml.sh: "Files scanned: 57, Errors: 0, Warnings: 0 … A2ML validation passed". The playground NEUROSYM is among the files scanned.
  • bash scripts/ci/test-manifest-validator-regressions.sh: all 5 cases give the expected exit codes.
  • bash scripts/check-verification-integrations.sh: "OK: 141 ProverKind declarations; 12 assessed tool roles".
  • asciidoctor --failure-level=WARN on the four changed .adoc files: clean.
  • git grep -n -i logtalk: no output.

Not run: the pinned standards governance reusable workflow, which reads root-allow.txt; no Rust or Julia builds, since nothing here feeds them.

Left for later

The root .machine_readable/descriptiles/NEUROSYM.a2ml says report-format = "JSON (AssailReport)", which is not one of Hypatia's format names (json, text, github, sarif). It is left unchanged here.


Generated by Claude Code

archive/ held one dead rule module and its README, quarantined on
2026-11-01. Its semantics now live in hyperpolymath/hypatia's
lib/rules/security_errors.ex, checked there by the Agda model
verification/proofs/agda/AlertTableCorrespondence.agda. Git history
keeps the file (last present at 478b751).

archive/ is now empty, so its root-allow.txt entry and its .reuse/dep5
bulk-stanza line go too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ
DEBT.adoc's two "fixed en route" bullets described only the retired
rule engine and its quarantine, so they go. ECOSYSTEM-INTEGRATION.adoc
keeps the live fact (Hypatia's rule engine is Elixir; ECHIDNA is a
Hypatia target, not a rule producer) without the correction history.
PROOF-STATUS.adoc's "Not obligations" no longer lists the deleted
directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ
The key was commented out because it named a retired rule format that
no scanner emits. Hypatia's report formats are json, text, github and
sarif, with json canonical, so declare that rather than leaving the
consumer to guess.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ
…econ

The 2026-11-01 recon named the retired rule language throughout §0, the
claim ledger, §4, §5 and §8. Reword those passages to "the retired rule
engine" and record the 2026-11-16 follow-ups: the quarantine under
archive/ was deleted (git history keeps it at 478b751; the semantics
live in hypatia's lib/rules/security_errors.ex, checked by
AlertTableCorrespondence.agda), and the playground's report-format now
declares "json".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 31ef5938-db25-4a04-81ea-79af64297f69
Commits

Reviewing files that changed from the base of the PR and between 5aea2e2 and 6799529.

Files selected for processing: 9

  • .machine_readable/root-allow.txt
  • .reuse/dep5
  • archive/logtalk/README.adoc
  • archive/logtalk/security_learning.lgt
  • docs/DEBT.adoc
  • docs/ECOSYSTEM-INTEGRATION.adoc
  • docs/PROOF-STATUS.adoc
  • docs/reports/2026-11-01-routing-and-rule-engine-recon.adoc
  • echidna-playground/.machine_readable/descriptiles/NEUROSYM.a2ml

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Updated integration and proof-status information to reflect the current rule-engine and playground descriptions.
    • Revised the historical investigation report to record the retirement and deletion of the archived Logtalk material.
    • Removed resolved items from the debt register.
  • Configuration
    • Set the playground’s report format to JSON.
  • Maintenance
    • Removed the archived Logtalk module and its quarantine record, along with related archive entries in repository metadata.

The pull request deletes the quarantined Logtalk source and README, removes archive references from repository declarations, updates related documentation, and sets the playground’s Hypatia report format to JSON.

Changes: Logtalk quarantine removal

Layer / File(s) Summary
Delete quarantine and archive declarations
archive/logtalk/*, .machine_readable/root-allow.txt, .reuse/dep5
The quarantined Logtalk source and README are deleted. The archive allow-list and fallback licence pattern no longer include the archive.
Update documentation and Hypatia configuration
docs/DEBT.adoc, docs/ECOSYSTEM-INTEGRATION.adoc, docs/PROOF-STATUS.adoc, docs/reports/2026-11-01-routing-and-rule-engine-recon.adoc, echidna-playground/.machine_readable/descriptiles/NEUROSYM.a2ml
The documentation records the quarantine’s deletion and describes Hypatia’s rule engine as Elixir. The playground configuration sets report-format to json.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Possibly related PRs

  • hyperpolymath/echidna#455: This PR quarantines the Logtalk rule engine. The current PR deletes that quarantined module and updates related records.
Merge Risk: Minimal · previous review 5aea2

This change removes an unused archived module and updates documentation to match. It has no known runtime impact and is low risk to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: deletion of the quarantined retired rule module (archive/logtalk/) and its remaining references. The changeset removes that directory, its root-allow and REUSE entries…
Description check Passed The description follows the repository template. It has a Summary, a Changes list, the RSR Quality Checklist with the required and as-applicable items marked, and a Testing section with concrete comma…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: deletion of the quarantined retired rule module (archive/logtalk/) and its remaining references. The changeset removes that directory, its root-allow and REUSE entries, and the doc references, so the title is specific and accurate. It is slightly long at 71 characters but within reasonable bounds for a conventional commit style title.

Full details: Description check

Explanation

The description follows the repository template. It has a Summary, a Changes list, the RSR Quality Checklist with the required and as-applicable items marked, and a Testing section with concrete commands and results. It also explains the rationale, the recoverable history reference, and a follow-up item. The Screenshots section is omitted, which is acceptable because it is marked as applicable only when relevant. The 'Documentation updated' item is ticked, and the deed, ROADMAP, TOPOLOGY and CHANGELOG items are not addressed, but these are conditional on the change type, so the description is mostly complete.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2c1181fc-0087-479d-8a09-3f2064ad2ab5
Commits

Reviewing files that changed from the base of the PR and between 478b751 and 5aea2e2.

Files selected for processing: 9

  • .machine_readable/root-allow.txt
  • .reuse/dep5
  • archive/logtalk/README.adoc
  • archive/logtalk/security_learning.lgt
  • docs/DEBT.adoc
  • docs/ECOSYSTEM-INTEGRATION.adoc
  • docs/PROOF-STATUS.adoc
  • docs/reports/2026-11-01-routing-and-rule-engine-recon.adoc
  • echidna-playground/.machine_readable/descriptiles/NEUROSYM.a2ml
Files with no reviewable changes: 5

  • .machine_readable/root-allow.txt
  • .reuse/dep5
  • archive/logtalk/README.adoc
  • archive/logtalk/security_learning.lgt
  • docs/DEBT.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 7

  • GitHub Check: CodeRabbit
  • GitHub Check: rust-ci / Cargo check + clippy + fmt
  • GitHub Check: rust-ci / llvm-cov line coverage
  • GitHub Check: panic-attack assail
  • GitHub Check: T1 / minizinc
  • GitHub Check: MVP Smoke
  • GitHub Check: PR (address)
Additional context used

Code guidelines: 2

.github/copilot-instructions.md — auto-discovered
CLAUDE.md — auto-discovered
Path-based instructions: 2

Source excerpt: State files (.a2ml) live in `.machine_readable/` ONLY, never the root.

CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

  • echidna-playground/.machine_readable/descriptiles/NEUROSYM.a2ml
Source excerpt: **Version + release history**: [`CHANGELOG.adoc`](CHANGELOG.adoc) (single source of truth; do not duplicate version strings elsewhere)

CodeRabbit inference engine (CLAUDE.md)

Files:

  • docs/ECOSYSTEM-INTEGRATION.adoc
  • docs/PROOF-STATUS.adoc
  • docs/reports/2026-11-01-routing-and-rule-engine-recon.adoc
  • echidna-playground/.machine_readable/descriptiles/NEUROSYM.a2ml
Additional comments: 1

echidna-playground/.machine_readable/descriptiles/NEUROSYM.a2ml: 1

12-12: Data Integrity & Integration

The review comment asks whether Hypatia accepts report-format = "json". Its failure claim depends on an external reader contract. The inspected repository contains no reader, formatter selector, or accepted-value list for this key, and the only external-contract statement is the file's own comment. The repository does not show that the value is rejected, so the concern has no supported consequence.

hyperpolymath pushed a commit to hyperpolymath/hypatia that referenced this pull request Nov 16, 2026
The requests they carried are now pull requests in their home repos:
metadatastician/standards#1618 (report-format closed to json, fixtures
updated) and hyperpolymath/echidna#516 (archived rule module deleted).
The .hypatia-ignore block that only covered the packets goes with them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ
coderabbitai[bot]
coderabbitai Bot previously approved these changes Nov 16, 2026
@linear-code
linear-code Bot marked this pull request as ready for review November 16, 2026 19:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-16T19:25:10.573273Z
We couldn’t complete this review. Comment @codex review to try again.
5aea2e2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Main moved on after the branch point, so the archive was last present
on a later commit. Name 478b751 as one commit to recover it from.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants