Skip to content

fix(k9): check for just only when a path that calls it is enabled - #515

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/new-session-th4e9w-k9-just-gate
Nov 16, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/new-session-th4e9w-k9-just-gate

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

In .machine_readable/setup-prover-env.k9.ncl, check-prerequisites required just in every configuration. Take use_guix = true, use_sealed_containers = false and run_doctor = false. Then install-all runs only guix package -m manifests/live-provers.scm, but a Guix host without just still failed before provisioning. Review on #464 found this after the merge.

What

The just check now runs only when use_sealed_containers or run_doctor is true, since only those paths call it. The guix and podman checks were already gated the same way.

Checks run

  • .github/hooks/validate-k9.sh, run against a local standards checkout: 10 files, 0 failing, layer L1.
  • Nickel is not available in this session, so the L2 evaluation is left to the CI job, which installs Nickel.

Generated by Claude Code

check-prerequisites required `just` unconditionally. With
use_guix = true, use_sealed_containers = false and run_doctor = false,
install-all runs only `guix package -m manifests/live-provers.scm`, yet a
Guix host without `just` failed before provisioning. The `just` check now
runs only when the container build or the doctor is enabled, as the guix
and podman checks already do.

The canonical validator passes: 10 files, 0 failing, layer L1. Nickel is
not available locally, so the L2 evaluation is left to CI.

Reported by review on #464 after merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
@sonarqubecloud

Copy link
Copy Markdown

Repository owner deleted a comment from coderabbitai Bot Nov 16, 2026
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 16, 2026 19:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T19:41:19.785302Z 0b0e8b1 Draft marked ready
🔒 Security Review ❌ Failed 2026-11-16T19:39:24.255071Z
We couldn’t complete this review. Comment @codex security review to try again.
0b0e8b1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b71179b8-2c7e-45c7-87a7-83418d598c4f
Commits

Reviewing files that changed from the base of the PR and between 478b751 and 0b0e8b1.

Files selected for processing: 1

  • .machine_readable/setup-prover-env.k9.ncl
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@hyperpolymath
hyperpolymath merged commit 81f40a6 into main Nov 16, 2026
71 checks passed
@hyperpolymath
hyperpolymath deleted the claude/new-session-th4e9w-k9-just-gate branch November 16, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants