Repository navigation
fix(k9): check for just only when a path that calls it is enabled - #515
Conversation
check-prerequisites required `just` unconditionally. With use_guix = true, use_sealed_containers = false and run_doctor = false, install-all runs only `guix package -m manifests/live-provers.scm`, yet a Guix host without `just` failed before provisioning. The `just` check now runs only when the container build or the doctor is enabled, as the guix and podman checks already do. The canonical validator passes: 10 files, 0 failing, layer L1. Nickel is not available locally, so the L2 evaluation is left to CI. Reported by review on #464 after merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |



Why
In
.machine_readable/setup-prover-env.k9.ncl,check-prerequisitesrequiredjustin every configuration. Takeuse_guix = true,use_sealed_containers = falseandrun_doctor = false. Theninstall-allruns onlyguix package -m manifests/live-provers.scm, but a Guix host withoutjuststill failed before provisioning. Review on #464 found this after the merge.What
The
justcheck now runs only whenuse_sealed_containersorrun_doctoris true, since only those paths call it. The guix and podman checks were already gated the same way.Checks run
.github/hooks/validate-k9.sh, run against a local standards checkout: 10 files, 0 failing, layer L1.Generated by Claude Code