Skip to content

fix(ci): the Agda receipt names the commit that was actually checked - #510

Merged
hyperpolymath merged 3 commits into
mainfrom
claude/new-session-th4e9w-agda-receipt-commit
Nov 17, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
claude/new-session-th4e9w-agda-receipt-commit

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

On pull_request runs, agda-meta-checker.yml checks out github.event.pull_request.head.sha. GITHUB_SHA on that event is GitHub's synthetic merge commit. scripts/ci/check-agda.sh preferred GITHUB_SHA, so PR receipts attributed the source hashes to a commit that was never checked out. Review on #471 found this after the merge.

What

One line: the receipt always records git rev-parse HEAD of the checked tree.

Checks run

bash -n scripts/ci/check-agda.sh passes. The next agda-meta-checker run on this PR prints the receipt line with the PR head SHA.


Generated by Claude Code

On pull_request runs, agda-meta-checker checks out the PR head
(pull_request.head.sha), but GITHUB_SHA is the merge commit GitHub
synthesises. The receipt preferred GITHUB_SHA, so it attributed the source
hashes to a commit that was never checked out. It now records
`git rev-parse HEAD` of the checked tree in every case.

Reported by review on #471 after merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 16, 2026 19:42
Repository owner deleted a comment from coderabbitai Bot Nov 16, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: dd7ae10f-adab-451c-ae96-cf4a835ecd51
Commits

Reviewing files that changed from the base of the PR and between 17ca526 and 2e244b2.

Files selected for processing: 1

  • scripts/ci/check-agda.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T00:16:46.875140Z 2e244b2 New commits
🔒 Security Review ❌ Failed 2026-11-17T00:14:58.776922Z
We couldn’t complete this review. Comment @codex security review to try again.
2e244b2 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 16, 2026 19:42
@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit ebbebb3 into main Nov 17, 2026
74 checks passed
@hyperpolymath
hyperpolymath deleted the claude/new-session-th4e9w-agda-receipt-commit branch November 17, 2026 00:32
hyperpolymath added a commit that referenced this pull request Nov 17, 2026
…the Agda receipt (#520)

## Summary

This follows up on #509 and #510, both already merged. An independent
review of that batch raised two gaps, and this PR closes them.

## Changes

- **`dogfood-proofs-ci.yml` (verif-idris gate from #509).** The gate
only checked that `%default total` is present. A later `partial` or
`covering` annotation, or a `%default partial|covering`, switches the
totality check off again, and the package still builds. Idris 2 defaults
to covering, and under covering `bad : Void; bad = bad` type-checks. The
gate now rejects both forms.
- **`idris2-abi-ci.yml`.** A new step applies the same ban to
`src/abi/`. It runs on every event, because it is cheap.
- **`scripts/ci/check-agda.sh` (from #510).** `git rev-parse HEAD` ran
inside `echo`'s arguments, where a failure escapes `set -e`. The receipt
would then name an empty commit and the script would still pass. The
commit is now read on its own line.

**Not in this PR:** requiring `%default total` in every `src/abi/`
module. That waits for #513, which moves the one module that lacks it
(`NeSyAssistTesting.idr`) out of `src/abi/`.

## RSR Quality Checklist

### Required

- [x] Tests pass: both new gates were run against the current tree and
against a broken copy (see Testing).
- [x] Code is formatted: no Rust changed.
- [ ] Linter is clean: actionlint was not available in this session. The
repo's Workflow Security Linter runs on this PR.
- [x] No banned language patterns
- [x] No `unsafe` blocks without `// SAFETY:` comments: not applicable.
- [x] No banned functions
- [x] SPDX license headers present: no new files.
- [x] No secrets, credentials, or `.env` files included

## Testing

- **verif-idris step:** extracted with `yq` and run on the current tree,
exit 0. On a scratch corpus where `B.idr` has a `covering` line, it
prints `::error file=…B.idr::module declares a partial or covering
definition or default` and exits 1.
- **src/abi step:** run on the current tree, exit 0. On a scratch
`src/abi/X.idr` with a `partial` line, it prints the error and exits 1.
- **`check-agda.sh`:** `bash -n` passes. The changed line was not
exercised in this session: Agda is not installed here.

---
_Generated by [Claude
Code](https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants