Repository navigation
fix(proofs): NatLte declares %default total, and CI requires it of every module - #509
Conversation
…ery module NatLte.idr is in echidna-verif-proofs.ipkg and its lteLit helper feeds several proofs. It had neither %default total nor per-definition total modifiers, so the package build did not check its totality. PROOF-STATUS cited %default total as evidence for the whole package. - NatLte.idr gains %default total. Its three definitions match on Dec and cover both cases. - The verif-idris job in dogfood-proofs-ci.yml fails if any module in verification/proofs/idris2/ lacks the directive. - PROOF-STATUS says that the cited receipt predates the fix and that NatLte needs a fresh receipt. Reported by review on #482 after merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…4e9w-natlte-total
|
…te caveat The 2026-11-01 routing recon still said R9 and R10 were `proven` (§ "What is therefore not claimed" and §10.4). Under the 2026-11-16 ruling both rows are `open`. The report is a dated record, so the original text stays and a dated note now follows each claim. The closing summary of PROOF-STATUS now names, among R2's limits, the fresh receipt that NatLte totality still needs (#509). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
…the Agda receipt (#520) ## Summary This follows up on #509 and #510, both already merged. An independent review of that batch raised two gaps, and this PR closes them. ## Changes - **`dogfood-proofs-ci.yml` (verif-idris gate from #509).** The gate only checked that `%default total` is present. A later `partial` or `covering` annotation, or a `%default partial|covering`, switches the totality check off again, and the package still builds. Idris 2 defaults to covering, and under covering `bad : Void; bad = bad` type-checks. The gate now rejects both forms. - **`idris2-abi-ci.yml`.** A new step applies the same ban to `src/abi/`. It runs on every event, because it is cheap. - **`scripts/ci/check-agda.sh` (from #510).** `git rev-parse HEAD` ran inside `echo`'s arguments, where a failure escapes `set -e`. The receipt would then name an empty commit and the script would still pass. The commit is now read on its own line. **Not in this PR:** requiring `%default total` in every `src/abi/` module. That waits for #513, which moves the one module that lacks it (`NeSyAssistTesting.idr`) out of `src/abi/`. ## RSR Quality Checklist ### Required - [x] Tests pass: both new gates were run against the current tree and against a broken copy (see Testing). - [x] Code is formatted: no Rust changed. - [ ] Linter is clean: actionlint was not available in this session. The repo's Workflow Security Linter runs on this PR. - [x] No banned language patterns - [x] No `unsafe` blocks without `// SAFETY:` comments: not applicable. - [x] No banned functions - [x] SPDX license headers present: no new files. - [x] No secrets, credentials, or `.env` files included ## Testing - **verif-idris step:** extracted with `yq` and run on the current tree, exit 0. On a scratch corpus where `B.idr` has a `covering` line, it prints `::error file=…B.idr::module declares a partial or covering definition or default` and exits 1. - **src/abi step:** run on the current tree, exit 0. On a scratch `src/abi/X.idr` with a `partial` line, it prints the error and exits 1. - **`check-agda.sh`:** `bash -n` passes. The changed line was not exercised in this session: Agda is not installed here. --- _Generated by [Claude Code](https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3)_ --------- Co-authored-by: Claude <noreply@anthropic.com>



Why
verification/proofs/idris2/NatLte.idris inechidna-verif-proofs.ipkg, and itslteLithelper feeds several recorded proofs. The module had neither%default totalnor per-definitiontotalmodifiers, so a successful package build did not check its totality. PROOF-STATUS R2 still cited%default totalas evidence for the whole package. Review on #482 found this after the merge.What
NatLte.idrdeclares%default total. Its three definitions (IsYes,fromYes,lteLit) match onDecand cover both constructors.verif-idrisjob ofdogfood-proofs-ci.yml: it fails if anyverification/proofs/idris2/*.idrlacks the directive.docs/PROOF-STATUS.adocR2 now says that the cited receipt predates the fix and thatNatLteneeds a fresh receipt before its totality is cited.Checks run
main'sNatLte.idrwould fail it.idris2is not available in this session, so the type-check is left to theIdris2 (verification)job.Generated by Claude Code