Skip to content

fix(proofs): NatLte declares %default total, and CI requires it of every module - #509

Merged
hyperpolymath merged 3 commits into
mainfrom
claude/new-session-th4e9w-natlte-total
Nov 17, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
claude/new-session-th4e9w-natlte-total

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

verification/proofs/idris2/NatLte.idr is in echidna-verif-proofs.ipkg, and its lteLit helper feeds several recorded proofs. The module had neither %default total nor per-definition total modifiers, so a successful package build did not check its totality. PROOF-STATUS R2 still cited %default total as evidence for the whole package. Review on #482 found this after the merge.

What

  • NatLte.idr declares %default total. Its three definitions (IsYes, fromYes, lteLit) match on Dec and cover both constructors.
  • New step in the verif-idris job of dogfood-proofs-ci.yml: it fails if any verification/proofs/idris2/*.idr lacks the directive.
  • docs/PROOF-STATUS.adoc R2 now says that the cited receipt predates the fix and that NatLte needs a fresh receipt before its totality is cited.

Checks run

  • Gate simulated locally: this branch has 0 modules missing the directive, and main's NatLte.idr would fail it.
  • idris2 is not available in this session, so the type-check is left to the Idris2 (verification) job.

Generated by Claude Code

…ery module

NatLte.idr is in echidna-verif-proofs.ipkg and its lteLit helper feeds
several proofs. It had neither %default total nor per-definition total
modifiers, so the package build did not check its totality. PROOF-STATUS
cited %default total as evidence for the whole package.

- NatLte.idr gains %default total. Its three definitions match on Dec and
  cover both cases.
- The verif-idris job in dogfood-proofs-ci.yml fails if any module in
  verification/proofs/idris2/ lacks the directive.
- PROOF-STATUS says that the cited receipt predates the fix and that NatLte
  needs a fresh receipt.

Reported by review on #482 after merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Repository owner deleted a comment from coderabbitai Bot Nov 16, 2026
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 16, 2026 19:47
@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 16, 2026 19:47
Repository owner deleted a comment from coderabbitai Bot Nov 16, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-16T19:49:16.950324Z
We couldn’t complete this review. Comment @codex review to try again.
29a0450 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c5a285bf-5e5a-423d-a66a-541687d4cf11
Commits

Reviewing files that changed from the base of the PR and between 17ca526 and d9c664d.

Files selected for processing: 3

  • .github/workflows/dogfood-proofs-ci.yml
  • docs/PROOF-STATUS.adoc
  • verification/proofs/idris2/NatLte.idr
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 47eef21 into main Nov 17, 2026
79 checks passed
@hyperpolymath
hyperpolymath deleted the claude/new-session-th4e9w-natlte-total branch November 17, 2026 00:32
hyperpolymath pushed a commit that referenced this pull request Nov 17, 2026
…te caveat

The 2026-11-01 routing recon still said R9 and R10 were `proven` (§ "What
is therefore not claimed" and §10.4). Under the 2026-11-16 ruling both rows
are `open`. The report is a dated record, so the original text stays and a
dated note now follows each claim.

The closing summary of PROOF-STATUS now names, among R2's limits, the fresh
receipt that NatLte totality still needs (#509).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
hyperpolymath added a commit that referenced this pull request Nov 17, 2026
…the Agda receipt (#520)

## Summary

This follows up on #509 and #510, both already merged. An independent
review of that batch raised two gaps, and this PR closes them.

## Changes

- **`dogfood-proofs-ci.yml` (verif-idris gate from #509).** The gate
only checked that `%default total` is present. A later `partial` or
`covering` annotation, or a `%default partial|covering`, switches the
totality check off again, and the package still builds. Idris 2 defaults
to covering, and under covering `bad : Void; bad = bad` type-checks. The
gate now rejects both forms.
- **`idris2-abi-ci.yml`.** A new step applies the same ban to
`src/abi/`. It runs on every event, because it is cheap.
- **`scripts/ci/check-agda.sh` (from #510).** `git rev-parse HEAD` ran
inside `echo`'s arguments, where a failure escapes `set -e`. The receipt
would then name an empty commit and the script would still pass. The
commit is now read on its own line.

**Not in this PR:** requiring `%default total` in every `src/abi/`
module. That waits for #513, which moves the one module that lacks it
(`NeSyAssistTesting.idr`) out of `src/abi/`.

## RSR Quality Checklist

### Required

- [x] Tests pass: both new gates were run against the current tree and
against a broken copy (see Testing).
- [x] Code is formatted: no Rust changed.
- [ ] Linter is clean: actionlint was not available in this session. The
repo's Workflow Security Linter runs on this PR.
- [x] No banned language patterns
- [x] No `unsafe` blocks without `// SAFETY:` comments: not applicable.
- [x] No banned functions
- [x] SPDX license headers present: no new files.
- [x] No secrets, credentials, or `.env` files included

## Testing

- **verif-idris step:** extracted with `yq` and run on the current tree,
exit 0. On a scratch corpus where `B.idr` has a `covering` line, it
prints `::error file=…B.idr::module declares a partial or covering
definition or default` and exits 1.
- **src/abi step:** run on the current tree, exit 0. On a scratch
`src/abi/X.idr` with a `partial` line, it prints the error and exits 1.
- **`check-agda.sh`:** `bash -n` passes. The changed line was not
exercised in this session: Agda is not installed here.

---
_Generated by [Claude
Code](https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants