Skip to content

fix(ci): clear the 2 red checks on main at source - #494

Closed
hyperpolymath wants to merge 3 commits into
mainfrom
marina/optimistic-cray-js64k7-main-reds
Closed

hyperpolymath wants to merge 3 commits into
mainfrom
marina/optimistic-cray-js64k7-main-reds

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

2 checks are red on main at b6ff166, and both are older than the recent PRs: Static Analysis / panic-attack assail and governance / Validate Hypatia Baseline. This PR fixes each finding at its source. No baseline or ledger entry is added.

Changes

  • static-analysis-gate.yml: PANIC_ATTACK_REF moves from f2a6a70 to 55ffcc9a240e937edd968487af15ab45c6f0522f (panic-attack main).
    • The 2 Critical ProofDrift findings are the deliberate sorry detector fixtures tests/corpus_fixtures/isabelle/Smoke.thy and tests/corpus_fixtures/minif2f/algebra.lean. Both already carry a panic-attack: accepted marker.
    • f2a6a70 does not anchor a Lean or Isabelle sorry finding to its line, so it cannot apply the marker. feat(assail): line-anchor Lean/Isabelle sorry findings so inline markers apply panic-attack#278 adds that, and 55ffcc9 includes it.
    • bridge-gate.yml reads the same pin. src/bridge/ and the Patch Bridge schema (0.3.0) did not change between the 2 commits.
  • src/rust/server/session.rs: the apply-tactic handler checked state.is_none() and then called .unwrap() 4 times. It now binds the state with let-else and reads the goal counts from values it already holds. No behaviour changes.
  • src/rust/provers/test_fixture.rs: the helper is compiled only under cfg(all(test, unix)), but the gate is on the mod line, so Hypatia scans the file alone. write_executable now returns io::Result with the failed step in the error. The 4 callers in #[cfg(test)] mod tests call .unwrap(), so a failed fixture still stops the test.

RSR Quality Checklist

Required

  • Tests pass: cargo test --lib -- provers::chuffed provers::faial provers::gpuverify provers::version_probe server:: gives 58 passed, 0 failed.
  • Code is formatted: cargo fmt -- --check on the 6 Rust files is clean.
  • Linter is clean: no new warnings in the test build.
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments
  • No banned functions introduced
  • SPDX license headers present (unchanged)
  • No secrets, credentials, or .env files included

As Applicable

  • None applies.

Testing

  • Scanner: cargo install --git … --rev 55ffcc9… --locked --features http built locally. On a clean copy of main (b6ff166), static-analysis-evidence.sh scan panic-attack gave status: ran, exit 0, coverage 951/951. Both fixture findings are suppressed: true. static-analysis-evidence.sh gate exit 0.
  • Receipt controls: bash scripts/ci/test-static-analysis-evidence.sh gives 59 passed.
  • Hypatia: Elixir is not in this session, so I could not run the scanner. I applied its rule patterns from lib/rules/code_safety.ex at the pinned 82396d8 (same comment and #[cfg(test)] stripping) to both files. Before: session.rs 4 unwrap_without_check, test_fixture.rs 3 expect_in_hot_path and 2 panic_macro. After: 0 for every code_safety Rust rule. The hosted Validate Hypatia Baseline run on this PR is the real proof.

Screenshots

Not applicable.


Generated by Claude Code

`panic-attack assail` is red on main. The scanner at f2a6a70 reports the
2 deliberate `sorry` detector fixtures under tests/corpus_fixtures/ as
Critical ProofDrift. Both fixtures already carry an inline
`panic-attack: accepted` marker, but f2a6a70 does not anchor a Lean or
Isabelle `sorry` finding to its line, so it cannot apply the marker.

55ffcc9 is panic-attack main and includes panic-attack#278, which anchors
those findings. bridge-gate.yml reads the same pin. The Patch Bridge
source and its report schema (0.3.0) did not change between the 2 commits.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6
Signed-off-by: Claude <noreply@anthropic.com>
The handler checked `session.state.is_none()` and then called
`.unwrap()` on the same Option 4 times. Hypatia reports that as
code_safety/unwrap_without_check. The baseline entry for that rule names
src/rust/server.rs, which no longer exists, so it does not cover this file.

Bind the state with let-else. Read the goal counts from values the
handler already holds. A failed tactic leaves the state as it was, so
its count is the count from before the call. No behaviour changes.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6
Signed-off-by: Claude <noreply@anthropic.com>
provers::test_fixture is compiled only under cfg(all(test, unix)), but
that gate is on the `mod` line in provers/mod.rs. Hypatia scans the file
alone and reports its expect() and panic! calls as
code_safety/expect_in_hot_path and code_safety/panic_macro.

write_executable now returns io::Result and names the failed step in
the error. The 4 callers are inside `#[cfg(test)] mod tests` and call
.unwrap(), so a failed fixture still stops the test with the same text.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6
Signed-off-by: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 65246271-f200-4b38-9b9e-8a159eb21252
Commits

Reviewing files that changed from the base of the PR and between 7cb26bf and 3b02ca3.

Files selected for processing: 7

  • .github/workflows/static-analysis-gate.yml
  • src/rust/provers/chuffed.rs
  • src/rust/provers/faial.rs
  • src/rust/provers/gpuverify.rs
  • src/rust/provers/test_fixture.rs
  • src/rust/provers/version_probe.rs
  • src/rust/server/session.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 10, 2026 18:21
@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 10, 2026 18:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T18:23:15.059472Z 3b02ca3 Draft marked ready
🔒 Security Review ❌ Failed 2026-11-10T18:21:09.610401Z
We couldn’t complete this review. Comment @codex security review to try again.
3b02ca3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

auto-merge was automatically disabled November 10, 2026 18:27

Pull request was closed

@hyperpolymath
hyperpolymath deleted the marina/optimistic-cray-js64k7-main-reds branch November 10, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants