Skip to content

SQ-GEN-05: the fix and the check say the same thing about the full-history scan - #165

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/sq-gen-05-wording
Nov 14, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/sq-gen-05-wording

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Follow-up to #163, which merged before this refinement. CodeRabbit's finding on #163 was that the SQ-GEN-05 check column reads as "any one of" the full-history triggers while the fix column reads as "all three". It then agreed that neither is right: the fix can only keep the non-PR triggers the scan already has, and at least one must remain. That condition was already in the refer-when ("no full-history scan would remain"); the fix and check columns now say it too.

Changes

  • crates/squabble-core/data/first-line-rules.tsv and docs/decisions/0004-first-line-rule-catalogue.adoc: the fix and check columns of SQ-GEN-05 only.
    • Fix: scan base..head on pull_request, and keep the full-history scan on every non-PR trigger it already has (schedule, workflow_dispatch, push to the default branch); never remove it.
    • Check: gitleaks over base..head passes, the full-history scan still runs on each non-PR trigger it had before and at least one remains, and the older finding is reported.
  • No code, no counts, no ids change.

RSR Quality Checklist

Required

  • Tests pass (cargo test -p squabble-core: 215; the TSV and the ADR ids match)
  • No banned language patterns
  • No secrets, credentials, or .env files included
  • No licence or SPDX edits

As Applicable

  • Documentation updated (ADR 0004)

Generated by Claude Code

…story scan

Follow-up to #163, which merged before this refinement. CodeRabbit's finding
was right that the check read as any-one-of while the fix read as all three;
the right rule is neither: the fix can only keep the non-PR triggers the scan
already has, and at least one must remain (else it is a referral, already in
the refer-when). Both columns, in the TSV and the ADR, now say that.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-14T09:28:46.518722Z
We couldn’t complete this review. Comment @codex review to try again.
0802001 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1d0b8577-dd0c-4079-b1b9-a9b4b7863209
Commits

Reviewing files that changed from the base of the PR and between 199d1be and 0802001.

Files ignored due to path filters: 1

  • crates/squabble-core/data/first-line-rules.tsv is excluded by !**/*.tsv
Files selected for processing: 1

  • docs/decisions/0004-first-line-rule-catalogue.adoc
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 0b36101 into main Nov 14, 2026
72 checks passed
@hyperpolymath
hyperpolymath deleted the claude/sq-gen-05-wording branch November 14, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants