Repository navigation
SQ-GEN-05: the fix and the check say the same thing about the full-history scan - #165
Conversation
…story scan Follow-up to #163, which merged before this refinement. CodeRabbit's finding was right that the check read as any-one-of while the fix read as all three; the right rule is neither: the fix can only keep the non-PR triggers the scan already has, and at least one must remain (else it is a referral, already in the refer-when). Both columns, in the TSV and the ADR, now say that. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|



Summary
Follow-up to #163, which merged before this refinement. CodeRabbit's finding on #163 was that the SQ-GEN-05 check column reads as "any one of" the full-history triggers while the fix column reads as "all three". It then agreed that neither is right: the fix can only keep the non-PR triggers the scan already has, and at least one must remain. That condition was already in the refer-when ("no full-history scan would remain"); the fix and check columns now say it too.
Changes
crates/squabble-core/data/first-line-rules.tsvanddocs/decisions/0004-first-line-rule-catalogue.adoc: the fix and check columns of SQ-GEN-05 only.base..headonpull_request, and keep the full-history scan on every non-PR trigger it already has (schedule,workflow_dispatch, push to the default branch); never remove it.gitleaksoverbase..headpasses, the full-history scan still runs on each non-PR trigger it had before and at least one remains, and the older finding is reported.RSR Quality Checklist
Required
cargo test -p squabble-core: 215; the TSV and the ADR ids match).envfiles includedAs Applicable
Generated by Claude Code