Skip to content

ci: emit the required CI/gate check from julia-ci.yml - #22

Merged
hyperpolymath merged 2 commits into
mainfrom
claude/focused-meitner-uf53td
Nov 17, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
claude/focused-meitner-uf53td

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

The account ruleset "Branch-Floor" requires a status check named exactly CI/gate on every pull request. This repo never emitted it, so merging is refused with Required status check "CI/gate" is expected. This PR adds the gate at source, by satisfying it: one new job in julia-ci.yml. No existing check is skipped, weakened or path-filtered.

Changes

  • .github/workflows/julia-ci.yml: new job ci-gate with name: CI/gate. It needs: [fmt, jet, test] (every other job in the workflow; test is a matrix and its aggregate result is read), if: always(), permissions: {}, timeout-minutes: 5, runs-on: ubuntu-latest (as its siblings). Pure run: shell, no uses: step, so actions.lock does not change.
  • It reads needs.*.result. It exits 0 only when every required job is success, or skipped for a job configured as skipped-by-design behind a detector job whose own result is success (none are configured here). failure, cancelled, an empty or missing result, a skip without a successful detector, and a job in needs that is neither required nor advisory all exit 1. It prints a job/result table and the denominator to the log and to $GITHUB_STEP_SUMMARY.
  • Host choice: julia-ci.yml is the repo's main CI workflow, triggers on every pull request with no path filter, and runs today (recent PR runs: success).
  • The pattern follows hyperpolymath/hypatia ci.yml (ci-status, job name CI/gate). The RSR template (hyperpolymath/rsr-template-repo) has no CI/gate, so there was no template version to mirror; this is an estate-level gap.

RSR Quality Checklist

Required

  • Tests pass (gate logic exercised locally, see Testing)
  • Code is formatted: not applicable (no Julia changed)
  • Linter is clean: scripts/check-action-pinning.js PASS, scripts/check-lock-sync.sh PASS; shellcheck and actionlint not installed here: NOT RUN
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments
  • No banned functions added
  • SPDX license headers present on modified files (unchanged)
  • No secrets, credentials, or .env files included

As Applicable

  • This repo has no scripts/check-required-contexts.sh and no .machine_readable/required-contexts-allow.txt, so no mapping line was added and that check is NOT RUN.
  • Advisory jobs: none.
  • Note for the owner: Governance, Secret Scanner and Hypatia Security Scan show startup_failure on recent PR runs here (not touched by this PR).

Testing

The gate's run block was extracted from the committed YAML and run under bash with hand-set NEEDS_JSON (jobs fmt, jet, test):

all success                                  exit=0 (expected 0) PASS
one failure                                  exit=1 (expected 1) PASS
one cancelled                                exit=1 (expected 1) PASS
designed skip, detector success (synthetic)  exit=0 (expected 0) PASS
skip, no successful detector (synthetic)     exit=1 (expected 1) PASS

The two skip cases use a synthetic config (DESIGNED_SKIPS=jet:detect), since this workflow has no designed skips. Denominator in the real config: 3 required jobs. Behaviour on GitHub is observed after push, not claimed here.

Screenshots

Not applicable.



Generated by Claude Code

The Branch-Floor ruleset requires a status check named exactly `CI/gate`.
This repo never emitted it. Add job `ci-gate` (name: CI/gate) to julia-ci.yml
("Julia CI"), the repo's main CI workflow: it triggers on every pull_request
with no path filter and starts and runs today. The gate needs every other job
in the workflow (fmt, jet, test), runs with if: always(), uses no third-party
action, and exits 0 only when every required job succeeded (a skip passes
only for a job configured as skipped-by-design behind a detector that itself
succeeded). Failure, cancelled, missing or empty results all fail the gate.
The test job is a matrix; its aggregate result is what the gate reads.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDiW8qD4f2JDQJ4buGo
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 16f2ae66-6405-4114-8b95-4c52b5e64cb1
Commits

Reviewing files that changed from the base of the PR and between 0934058 and a9f0592.

Files selected for processing: 1

  • .github/workflows/julia-ci.yml

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Added a final CI check that verifies required formatting, analysis and test jobs have succeeded before the workflow passes.
    • The workflow summary now reports required and advisory job results. Skipped required checks are accepted only when their configured conditions are met.

The Julia CI workflow adds a gate job that checks required job results, reports job results in the workflow summary and fails under specified conditions.

Changes: CI gate

Layer / File(s) Summary
Job classification and gate evaluation
.github/workflows/julia-ci.yml
The gate classifies required and advisory jobs. It accepts a skipped required job only when its configured detector succeeds. It reports job results and fails for unclassified dependencies, unacceptable required job results or an empty required-job list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · previous review 09340

This change adds the CI/gate status check that the branch ruleset requires. It passes only when fmt, jet and test all succeed. No defects were found in the gate logic. It has not yet been run on GitHub, so confirm the check appears after the first push.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "ci: emit the required CI/gate check from julia-ci.yml" names the main change: a new CI/gate job in julia-ci.yml that emits the status check required by the Branch-Floor ruleset. It is speci…
Description check Passed The description follows the repository template in substance. It has a Summary, a Changes list, and a filled RSR Quality Checklist with checked and unchecked items explained. It has a Testing section …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: emit the required CI/gate check from julia-ci.yml" names the main change: a new CI/gate job in julia-ci.yml that emits the status check required by the Branch-Floor ruleset. It is specific, concise and matches the raw summary and objectives.

Full details: Description check

Explanation

The description follows the repository template in substance. It has a Summary, a Changes list, and a filled RSR Quality Checklist with checked and unchecked items explained. It has a Testing section that describes the local gate tests and the scripts run. The Screenshots section is marked not applicable. The author also notes which checks were not run (shellcheck, actionlint, check-required-contexts). The description does not contain a 'Closes #N' issue link, which the template asks for, but no linked issue was given. The 'As Applicable' items are addressed in prose rather than ticked. Overall it is mostly complete.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a198fccf-2979-4b99-ac52-771087d783c4
Commits

Reviewing files that changed from the base of the PR and between 6ccf6c9 and 0934058.

Files selected for processing: 1

  • .github/workflows/julia-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 14

  • GitHub Check: CodeRabbit
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Patch Bridge CVE triage
  • GitHub Check: Validate DEED manifests
  • GitHub Check: 🟡 CHECK: Groove manifest check
  • GitHub Check: 🔴 GATE: Empty-linter (invisible characters)
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Static analysis (JET)
  • GitHub Check: Format (JuliaFormatter)
  • GitHub Check: check
  • GitHub Check: Test (Test + Aqua) (1.10, ubuntu-latest)
  • GitHub Check: Runtime Policy
  • GitHub Check: 🟡 CHECK: Validate eclexiaiser manifest
  • GitHub Check: estate-rules
Additional context used

Code guidelines: 1

.github/copilot-instructions.md — auto-discovered
Path-based instructions: 1

Source excerpt: SPDX: `MPL-2.0` on all new files.

CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

  • .github/workflows/julia-ci.yml
GitHub Check: SonarCloud Code Analysis

.github/workflows/julia-ci.yml

[warning] 114-114: Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=hyperpolymath_CoprocessorRuntime.jl&issues=AaHmqzxTUyCSwxydVRS3&open=AaHmqzxTUyCSwxydVRS3&pullRequest=22

[warning] 113-113: Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=hyperpolymath_CoprocessorRuntime.jl&issues=AaHmqzxTUyCSwxydVRS2&open=AaHmqzxTUyCSwxydVRS2&pullRequest=22

[warning] 118-118: Assign this positional parameter to a local variable.

See more on https://sonarcloud.io/project/issues?id=hyperpolymath_CoprocessorRuntime.jl&issues=AaHmqzxTUyCSwxydVRS4&open=AaHmqzxTUyCSwxydVRS4&pullRequest=22

Additional comments: 1

.github/workflows/julia-ci.yml: 1

89-166: LGTM!

@linear-code
linear-code Bot marked this pull request as ready for review November 16, 2026 23:25
SonarCloud rule githubactions:S7679 flags $1 and $2 used directly in
result_of, in_list and detector_of. Each is now assigned to a named local.
No change in behaviour: the gate's decision logic was re-run locally with
success, failure, cancelled, skipped, empty, designed-skip and
unclassified-job inputs and gives the same exit codes as before.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDiW8qD4f2JDQJ4buGo
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit b11d281 into main Nov 17, 2026
41 checks passed
@hyperpolymath
hyperpolymath deleted the claude/focused-meitner-uf53td branch November 17, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants