Repository navigation
ci: emit the required CI/gate check from julia-ci.yml - #22
Conversation
The Branch-Floor ruleset requires a status check named exactly `CI/gate`.
This repo never emitted it. Add job `ci-gate` (name: CI/gate) to julia-ci.yml
("Julia CI"), the repo's main CI workflow: it triggers on every pull_request
with no path filter and starts and runs today. The gate needs every other job
in the workflow (fmt, jet, test), runs with if: always(), uses no third-party
action, and exits 0 only when every required job succeeded (a skip passes
only for a job configured as skipped-by-design behind a detector that itself
succeeded). Failure, cancelled, missing or empty results all fail the gate.
The test job is a matrix; its aggregate result is what the gate reads.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDiW8qD4f2JDQJ4buGo
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
SonarCloud rule githubactions:S7679 flags $1 and $2 used directly in result_of, in_list and detector_of. Each is now assigned to a named local. No change in behaviour: the gate's decision logic was re-run locally with success, failure, cancelled, skipped, empty, designed-skip and unclassified-job inputs and gives the same exit codes as before. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDiW8qD4f2JDQJ4buGo
|



Summary
The account ruleset "Branch-Floor" requires a status check named exactly
CI/gateon every pull request. This repo never emitted it, so merging is refused withRequired status check "CI/gate" is expected. This PR adds the gate at source, by satisfying it: one new job injulia-ci.yml. No existing check is skipped, weakened or path-filtered.Changes
.github/workflows/julia-ci.yml: new jobci-gatewithname: CI/gate. Itneeds: [fmt, jet, test](every other job in the workflow;testis a matrix and its aggregate result is read),if: always(),permissions: {},timeout-minutes: 5,runs-on: ubuntu-latest(as its siblings). Purerun:shell, nouses:step, soactions.lockdoes not change.needs.*.result. It exits 0 only when every required job issuccess, orskippedfor a job configured as skipped-by-design behind a detector job whose own result issuccess(none are configured here).failure,cancelled, an empty or missing result, a skip without a successful detector, and a job inneedsthat is neither required nor advisory all exit 1. It prints a job/result table and the denominator to the log and to$GITHUB_STEP_SUMMARY.julia-ci.ymlis the repo's main CI workflow, triggers on every pull request with no path filter, and runs today (recent PR runs: success).ci.yml(ci-status, job nameCI/gate). The RSR template (hyperpolymath/rsr-template-repo) has noCI/gate, so there was no template version to mirror; this is an estate-level gap.RSR Quality Checklist
Required
scripts/check-action-pinning.jsPASS,scripts/check-lock-sync.shPASS; shellcheck and actionlint not installed here: NOT RUNunsafeblocks without// SAFETY:comments.envfiles includedAs Applicable
scripts/check-required-contexts.shand no.machine_readable/required-contexts-allow.txt, so no mapping line was added and that check is NOT RUN.startup_failureon recent PR runs here (not touched by this PR).Testing
The gate's run block was extracted from the committed YAML and run under bash with hand-set
NEEDS_JSON(jobsfmt,jet,test):The two skip cases use a synthetic config (
DESIGNED_SKIPS=jet:detect), since this workflow has no designed skips. Denominator in the real config: 3 required jobs. Behaviour on GitHub is observed after push, not claimed here.Screenshots
Not applicable.
Generated by Claude Code