Repository navigation
ci: fit the root allowlist to a Julia package - #15
Conversation
estate-rules failed on main: Project.toml, test/ and this repo's own deed are not on the template allowlist, and the template's deed name was required but absent. Add the first two, and require the repo's own deed name. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dd6bfba87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| CLAUDE.md # generated arrival pack; the generator, pre-commit and Claude Code all read it from the ROOT (do not hand-edit; edit the a2ml source) | ||
| ?GEMINI.md # pointer to CLAUDE.md for repos without AGENTS.md yet | ||
| Justfile # thin; delegates phases to build/just/*.just | ||
| Project.toml # Julia package manifest: Pkg reads it from the package root only (julia-library archetype) |
There was a problem hiding this comment.
Regenerate the repository map after changing its input
In the checked estate-rules.yml workflow, scripts/gen-repo-map.sh harvests annotations from this allowlist and then fails if docs/architecture/REPOSITORY-MAP.adoc changes. This new Project.toml entry and the deed rename both alter the generated map, but that artifact is not updated in this commit, so the Repository map is not stale step produces a diff and exits 1; regenerate and commit the map so the workflow this patch is intended to repair can pass.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Valid: estate-rules regenerates the map and diffs it. The map is regenerated and committed in this branch's next commit; bash scripts/gen-repo-map.sh . now produces no diff, and tests/shape/repo_map_determinism_test.sh passes.
Generated by Claude Code
| session/ # dispatch.sh, custom-checks.k9.ncl, local-hooks.sh | ||
| src/ | ||
| tests/ | ||
| test/ # Julia's Pkg.test() runs test/runtests.jl; Pkg looks for exactly this directory name at the package root |
There was a problem hiding this comment.
Keep the test annotation parseable by the map generator
When scripts/gen-repo-map.sh processes this line, its echo "$comment" | xargs trimming command interprets the apostrophe in Julia's as an unmatched quote and emits xargs: unmatched single quote. The surrounding || true hides the failure, causing the generated test/ row to contain - rather than this explanation; avoid the apostrophe or make the generator trim annotations without parsing them as quoted input.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Valid: the apostrophe was parsed by xargs as an unmatched quote and the annotation was silently dropped. Reworded without it; the generated test/ row now carries the explanation.
Generated by Claude Code
…-safe estate-rules regenerates docs/architecture/REPOSITORY-MAP.adoc and fails on any diff, so the allowlist change needs the regenerated map. The test/ annotation also had an apostrophe, which scripts/gen-repo-map.sh's xargs trimming parses as an unmatched quote and silently drops; reworded. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
estate-rules' 'Every tracked .adoc renders clean' step fails on main: the first row of the table in TEMPLATE-STANDARDS-AUDIT.adoc has five cells in a six-column table, so asciidoctor drops cells. It was hidden behind the root-shape failure. Add the missing Expected-path cell. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Keep both changelog entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
|



Summary
estate-rulesis red onmainbecause the root allowlist is still the template's:Project.tomlandtest/are not on it (Pkg needs both names at the package root).rsr-template-repo_chora.deedis required but absent; this repo's deed isCoprocessorRuntime.jl_chora.deed.Changes
.machine_readable/root-allow.txt: permitProject.tomlandtest/with justifications; require this repo's own deed name.CHANGELOG.adoc: Fixed entry.Testing
bash scripts/check-root-shape.sh .fails onmainwith the three unlisted entries and the one missing required entry (the CI log shows the same); on this branch it printsPASS: root matches allowlist (44 entries; 36 required, 13 optional).Not touched here: the
CLAUDE.mdand deed contents still describe the template (separate topic). #12 also editsroot-allow.txt(adds?ext/); the two edits are on different lines.Generated by Claude Code