Skip to content

ci: fix the Julia CI Format and JET steps, floor Julia at 1.10, format the code - #14

Merged
hyperpolymath merged 9 commits into
ci/relock-standards-ownerfrom
ci/julia-ci-fixes
Nov 14, 2026
Merged

hyperpolymath merged 9 commits into
ci/relock-standards-ownerfrom
ci/julia-ci-fixes

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Stacked on #13 (base ci/relock-standards-owner), so its CI runs with the lock fix in place. Retarget to main when #13 merges. Julia CI has never exercised this package on main: the Format and JET steps crash before checking anything, and the 1.9 leg cannot start. Per the owner's rule, each red was classified and fixed at its root: a correct check means the code is fixed, an incorrect check means the CI is fixed.

Red check on main Verdict Fix
Test (Test + Aqua) (1) correct: UndefVarError: WarrantOnly is a real hole (the enum instances were never exported) export the four instances (cherry-picked from #12, same one-line change)
Format (JuliaFormatter) both: the step is broken (3 defects) and, once it runs, 7 files are genuinely unformatted fix the step; format the 7 files
Static analysis (JET) incorrect: test_package(path=, julia_version=) matches no method pass the package module
Test (…) (1.9) incorrect: setup-julia installs 1.9.4 and the runner cannot load its libopenlibm.so, before any test owner chose a 1.10 LTS floor: matrix leg and compat julia both 1.10

Changes

  • julia-ci.yml Format step: filter over an uncollected Iterators.Flatten (a MethodError) now collects; format_string (not in JuliaFormatter 2) is format_text; and it read every file in src/, including src/README.adoc, on which format_text throws a ParseError, so only *.jl files are checked. The third defect was found by running the step locally past the first two.
  • julia-ci.yml JET step: the package module is the argument.
  • Julia floor: matrix ["1.10", "1"], compat julia = "1.10". Breaking for Julia 1.9 users; recorded in the changelog.
  • Seven files formatted (src/Choreography.jl, src/CoprocessorRuntime.jl, src/Nullity.jl, src/Receipts.jl, src/Sessions.jl, test/cases/receipts.jl, test/cases/sessions.jl). Formatting only, and checked: each file's old and new text were parsed, line numbers stripped, and the syntax trees compared. All seven are identical, so no behaviour changes.
  • Knowledge, Belief, WarrantOnly, Unsound exported (the hole fix).
  • Not changed: licences and SPDX headers, .a2ml files, rulesets and required checks.

RSR Quality Checklist

Required

  • Tests pass: 46 of 46 locally on Julia 1.11.5 and on Julia 1.10.10 (the new floor); CI decides
  • Code is formatted: the workflow's Format step, extracted and run as written, exits 0
  • No banned language patterns
  • SPDX license headers unchanged
  • No secrets, credentials, or .env files included

As Applicable

  • CHANGELOG updated, including the breaking floor change

Testing

  • Format step (as written in the workflow): exit 0.
  • JET.test_package(CoprocessorRuntime) with JET 0.9.20 on Julia 1.11.5: no finding. Not verified: JET on the newest Julia, which is what CI runs.
  • Pkg.test(): 46 of 46 on Julia 1.11.5 and on 1.10.10 (clean manifests, isolated depot for 1.10).

Known reds that this PR does not and cannot fix

Canon lockstep (stale canon pin; the re-pin edits retired .a2ml), estate-rules (the template's root allowlist does not fit a Julia package), openssf-compliance ({{PROJECT_NAME}} unfilled in CITATION.cff) and main-estate-audit (needs a tag in hyperpolymath/cicd-suite; see #13). Each is its own topic.


Generated by Claude Code

Both steps crashed before checking anything, and the 1.9 leg could not
start, so Julia CI had never exercised this package on main.

Format (JuliaFormatter), three defects in the step:
- `filter(isfile, Iterators.flatten(...))` is a MethodError: filter needs
  a collection, so the Flatten is collected;
- `format_string` is not in JuliaFormatter 2; `format_text` is;
- it read every file in src/, including src/README.adoc, and
  format_text throws a ParseError on a non-Julia file; only `*.jl` files
  are checked now. (Found by running the step locally past the first
  fix; the first two alone would have crashed on that file.)

JET: `JET.test_package(path=".", julia_version="1")` matches no method
in JET 0.9 or newer; the package module is the argument.

Julia floor: the 1.9 leg failed in setup-julia ("Unable to load
dependent library .../julia/1.9.4/.../libopenlibm.so") before any test,
on main and on every PR. The owner chose a 1.10 LTS floor: the matrix
leg is 1.10 and compat julia is 1.10, so the repository claims only what
CI tests. A breaking change for Julia 1.9 users, recorded in the
changelog.

Verified locally with Julia 1.11.5: the Format step, extracted from the
workflow and run as written, exits 0 after the formatting commit that
follows; JET.test_package(CoprocessorRuntime) with JET 0.9.20 raises no
finding. Not verified: JET on the newest Julia (what CI runs), and the
1.10 leg (CI decides).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Once the CI Format step can run, it correctly reports these files as
unformatted: src/Choreography.jl, src/CoprocessorRuntime.jl,
src/Nullity.jl, src/Receipts.jl, src/Sessions.jl, test/cases/receipts.jl
and test/cases/sessions.jl. They are formatted with JuliaFormatter 2.14
(default style), nothing else.

Formatting only, and checked: for each file the old and new text were
parsed, line numbers stripped, and the syntax trees compared; all seven
are identical, so no behaviour changes. A file would not have been
written otherwise.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
README.adoc, docs/ecosystem/HYPERPOLYMATH-WIRING.adoc and the receipts
tests all write `warrant=WarrantOnly` unqualified, but the module
exported only the enum type WarrantKind and not its instances Knowledge,
Belief, WarrantOnly and Unsound. Pkg.test() therefore failed on main with
`UndefVarError: WarrantOnly not defined` (42 passed, 0 failed, 1
errored), the same failure the Test + Aqua jobs show on both Julia
versions in CI.

Export the instances at the source, in the module's export list, rather
than qualifying them at each call site: the documented usage is the
unqualified one, and the extension and sibling packages that issue
receipts (FirmwareAudit issues WarrantOnly receipts) will write it the
same way.

Verified locally with Julia 1.11.5: Pkg.test() passes 46 of 46, Aqua
included, against 42 passed and 1 errored before.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 14, 2026 16:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T17:49:02.955088Z b6d7693 New commits
🔒 Security Review ✅ Completed 2026-11-14T17:49:39.312991Z b6d7693 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Repository owner deleted a comment from coderabbitai Bot Nov 14, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b66ce3e9ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Project.toml

[compat]
julia = "1.9"
julia = "1.10"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the developer guide to require Julia 1.10

When a developer follows docs/onboarding/QUICKSTART-DEV.adoc:11, the guide still advertises Julia 1.9+, but this compatibility change makes package instantiation fail on Julia 1.9 before the documented setup or tests can run. Update the guide's version requirement (including its template reminder on line 4) alongside the new floor.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid. Fixed in 74d08b1: docs/onboarding/QUICKSTART-DEV.adoc (line 4 template reminder and line 11) and the matching record in .machine_readable/ai/PLACEHOLDERS.adoc now say Julia 1.10+. A changelog line follows in the next commit.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4bf288ca-8c65-4e2d-a19b-515589b99a6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

JET 0.13 on Julia 1.13 reports five possible errors through the default
constructors' convert into Vector{Symbol} and Vector{Endpoint}. Typing the
constructors rejects ill-typed input at the call, keeps conforming callers
unchanged, and clears the report (JET.test_package exits 0 on 1.13.4; 46/46
tests pass on 1.13.4, 1.11.5 and 1.10.10).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Keep both changelog entries.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 7a86665 into ci/relock-standards-owner Nov 14, 2026
32 of 34 checks passed
@hyperpolymath
hyperpolymath deleted the ci/julia-ci-fixes branch November 14, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants