Repository navigation
ci: fix the Julia CI Format and JET steps, floor Julia at 1.10, format the code - #14
Conversation
Both steps crashed before checking anything, and the 1.9 leg could not
start, so Julia CI had never exercised this package on main.
Format (JuliaFormatter), three defects in the step:
- `filter(isfile, Iterators.flatten(...))` is a MethodError: filter needs
a collection, so the Flatten is collected;
- `format_string` is not in JuliaFormatter 2; `format_text` is;
- it read every file in src/, including src/README.adoc, and
format_text throws a ParseError on a non-Julia file; only `*.jl` files
are checked now. (Found by running the step locally past the first
fix; the first two alone would have crashed on that file.)
JET: `JET.test_package(path=".", julia_version="1")` matches no method
in JET 0.9 or newer; the package module is the argument.
Julia floor: the 1.9 leg failed in setup-julia ("Unable to load
dependent library .../julia/1.9.4/.../libopenlibm.so") before any test,
on main and on every PR. The owner chose a 1.10 LTS floor: the matrix
leg is 1.10 and compat julia is 1.10, so the repository claims only what
CI tests. A breaking change for Julia 1.9 users, recorded in the
changelog.
Verified locally with Julia 1.11.5: the Format step, extracted from the
workflow and run as written, exits 0 after the formatting commit that
follows; JET.test_package(CoprocessorRuntime) with JET 0.9.20 raises no
finding. Not verified: JET on the newest Julia (what CI runs), and the
1.10 leg (CI decides).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Once the CI Format step can run, it correctly reports these files as unformatted: src/Choreography.jl, src/CoprocessorRuntime.jl, src/Nullity.jl, src/Receipts.jl, src/Sessions.jl, test/cases/receipts.jl and test/cases/sessions.jl. They are formatted with JuliaFormatter 2.14 (default style), nothing else. Formatting only, and checked: for each file the old and new text were parsed, line numbers stripped, and the syntax trees compared; all seven are identical, so no behaviour changes. A file would not have been written otherwise. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
README.adoc, docs/ecosystem/HYPERPOLYMATH-WIRING.adoc and the receipts tests all write `warrant=WarrantOnly` unqualified, but the module exported only the enum type WarrantKind and not its instances Knowledge, Belief, WarrantOnly and Unsound. Pkg.test() therefore failed on main with `UndefVarError: WarrantOnly not defined` (42 passed, 0 failed, 1 errored), the same failure the Test + Aqua jobs show on both Julia versions in CI. Export the instances at the source, in the module's export list, rather than qualifying them at each call site: the documented usage is the unqualified one, and the extension and sibling packages that issue receipts (FirmwareAudit issues WarrantOnly receipts) will write it the same way. Verified locally with Julia 1.11.5: Pkg.test() passes 46 of 46, Aqua included, against 42 passed and 1 errored before. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b66ce3e9ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| [compat] | ||
| julia = "1.9" | ||
| julia = "1.10" |
There was a problem hiding this comment.
Update the developer guide to require Julia 1.10
When a developer follows docs/onboarding/QUICKSTART-DEV.adoc:11, the guide still advertises Julia 1.9+, but this compatibility change makes package instantiation fail on Julia 1.9 before the documented setup or tests can run. Update the guide's version requirement (including its template reminder on line 4) alongside the new floor.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Valid. Fixed in 74d08b1: docs/onboarding/QUICKSTART-DEV.adoc (line 4 template reminder and line 11) and the matching record in .machine_readable/ai/PLACEHOLDERS.adoc now say Julia 1.10+. A changelog line follows in the next commit.
Generated by Claude Code
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
JET 0.13 on Julia 1.13 reports five possible errors through the default
constructors' convert into Vector{Symbol} and Vector{Endpoint}. Typing the
constructors rejects ill-typed input at the call, keeps conforming callers
unchanged, and clears the report (JET.test_package exits 0 on 1.13.4; 46/46
tests pass on 1.13.4, 1.11.5 and 1.10.10).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Keep both changelog entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
|
7a86665
into
ci/relock-standards-owner



Summary
Stacked on #13 (base
ci/relock-standards-owner), so its CI runs with the lock fix in place. Retarget tomainwhen #13 merges. Julia CI has never exercised this package onmain: the Format and JET steps crash before checking anything, and the 1.9 leg cannot start. Per the owner's rule, each red was classified and fixed at its root: a correct check means the code is fixed, an incorrect check means the CI is fixed.mainTest (Test + Aqua) (1)UndefVarError: WarrantOnlyis a real hole (the enum instances were never exported)Format (JuliaFormatter)Static analysis (JET)test_package(path=, julia_version=)matches no methodTest (…) (1.9)setup-juliainstalls 1.9.4 and the runner cannot load itslibopenlibm.so, before any testcompat juliaboth 1.10Changes
julia-ci.ymlFormat step:filterover an uncollectedIterators.Flatten(aMethodError) now collects;format_string(not in JuliaFormatter 2) isformat_text; and it read every file insrc/, includingsrc/README.adoc, on whichformat_textthrows aParseError, so only*.jlfiles are checked. The third defect was found by running the step locally past the first two.julia-ci.ymlJET step: the package module is the argument.["1.10", "1"],compat julia = "1.10". Breaking for Julia 1.9 users; recorded in the changelog.src/Choreography.jl,src/CoprocessorRuntime.jl,src/Nullity.jl,src/Receipts.jl,src/Sessions.jl,test/cases/receipts.jl,test/cases/sessions.jl). Formatting only, and checked: each file's old and new text were parsed, line numbers stripped, and the syntax trees compared. All seven are identical, so no behaviour changes.Knowledge,Belief,WarrantOnly,Unsoundexported (the hole fix)..a2mlfiles, rulesets and required checks.RSR Quality Checklist
Required
.envfiles includedAs Applicable
CHANGELOGupdated, including the breaking floor changeTesting
JET.test_package(CoprocessorRuntime)with JET 0.9.20 on Julia 1.11.5: no finding. Not verified: JET on the newest Julia, which is what CI runs.Pkg.test(): 46 of 46 on Julia 1.11.5 and on 1.10.10 (clean manifests, isolated depot for 1.10).Known reds that this PR does not and cannot fix
Canon lockstep(stale canon pin; the re-pin edits retired.a2ml),estate-rules(the template's root allowlist does not fit a Julia package),openssf-compliance({{PROJECT_NAME}}unfilled inCITATION.cff) andmain-estate-audit(needs a tag inhyperpolymath/cicd-suite; see #13). Each is its own topic.Generated by Claude Code