Skip to content

Use signed upstream fiberd and controller images - #66

Open
jsturtevant wants to merge 3 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-53-20261114
Open

jsturtevant wants to merge 3 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-53-20261114

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

Pin the published upstream fiberd and controller images by digest instead of building and publishing Lampyr copies. Keep the controller install manifest in the platform package and align the runtime inputs with the upstream images.

Fixes #53.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 00:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Azure organization SAML enforcement blocked upstream source access, leaving the pinned release’s Hyperlight support and image compatibility with runtime contracts and packaged manifests unverified and requiring human validation.

No open issues 🎉

What changed in this PR

This PR switches Lampyr to signed, digest-pinned upstream fiberd and controller images instead of building and publishing its own copies. Platform packages retain the matching controller install manifest and template tools.

Changes:

  • Pin upstream releases and verify image provenance before packaging or preparing cluster inputs.
  • Remove upstream image builds from CI and release publishing; update preview mirroring to verify upstream images.
  • Align the fiberd dependency, tests, and documentation with the new image sources.
File Description
upstream/​pins.env Pin upstream release versions, commits, and image digests.
upstream/​Justfile Verify and pull upstream images while retaining manifest and tool generation.
upstream/​controller.Dockerfile Remove the Lampyr-built controller image definition.
scripts/​tests/​test_preview_workflow.py Update workflow checks for upstream pins and provenance verification.
scripts/​tests/​test_preview_mirror.py Cover upstream image verification and rejection paths.
scripts/​tests/​test_package_platform.py Use an upstream grant image in the packaging fixture.
scripts/​tests/​test_cluster_inputs.py Cover image pulls, helper-only builds, and pull failures.
scripts/​publish-version-release.sh Stop publishing upstream image copies in versioned releases.
scripts/​publish-preview-release.sh Remove upstream copies from preview publishing and release notes.
scripts/​mirror-preview-images.sh Read upstream digests from the verified platform archive and verify them before copying.
scripts/​fiberd-controller-inputs.sh Update comments describing cluster installation inputs.
scripts/​check_preview_images.py Remove validation of the retired controller build context.
Justfile Remove upstream image preparation from preview builds.
go.sum Update checksums for fiberd v0.4.0.
go.mod Align the fiberd dependency with the upstream release.
docs/​designs/​knative-fiber-serving.md Remove the outdated claim that the controller has no release.
docs/​contributing.md Document upstream verification, packaging, and mirroring.
CHANGELOG.md Record the switch to signed upstream images.
.github/​workflows/​release.yml Package upstream image references and remove their build-matrix entries.
.github/​workflows/​ci.yml Authenticate upstream verification and remove the fiberd image build cache step.
.github/​dependabot.yml Remove the directory for the deleted controller Dockerfile.

Review effort: Balanced

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 03:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The controller recipe pulls and tags the index digest instead of resolving and using the linux/amd64 child digest, causing the new successful-path test to fail.

1 open issue

Review effort: Balanced

Comment thread upstream/Justfile Resolved
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 03:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Organization SAML blocked upstream controller source access, leaving the new runtime-policy contract and pinned-image Hyperlight compatibility unverified and requiring human validation.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use fiberd's and fiberd-k8s-controller's own published images

2 participants