You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bundle pinned bootstrap manifests in platform releases - #60
Include pinned Serving, Kourier, and cert-manager manifests in the platform archive and verify their checksums during packaging. Load them from the archive during installation so these steps do not depend on upstream download URLs.
This does not make container image downloads offline.
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approval recommended
There are no active review issues for the change to bundle pinned bootstrap manifests with platform releases.
No open issues 🎉
What changed in this PR
This PR bundles pinned Knative Serving, Kourier, and cert-manager manifests in Lampyr platform releases, removing upstream manifest downloads from installation. Container image downloads remain separate and are not made offline.
Changes:
Package bootstrap manifests, source metadata, and controller pins, validating manifest checksums during packaging.
Load and verify bundled manifests during installation, with no download fallback.
Add packaging and bootstrap tests, asset-update documentation, and spell-check exclusions for vendored YAML.
File
Description
scripts/tests/test_package_platform.py
Updates archive expectations and verifies controller manifest preservation.
scripts/tests/test_bootstrap_manifests.py
Tests bundled contents and rejection of missing, altered, or invalid assets.
scripts/package-platform.py
Validates and packages bootstrap manifests, source metadata, and controller pins.
k8s/upstream/sources.json
Records upstream versions, source URLs, and SHA-256 checksums.
k8s/upstream/README.md
Documents verification, update procedures, and offline limitations.
k8s/upstream/kourier.yaml
Vendors the pinned upstream Kourier manifest.
cli/src/bootstrap.rs
Replaces bootstrap downloads with verified local files and adds tests.
cli/Justfile
Adds bootstrap manifest tests to the packaging test recipe.
_typos.toml
Excludes vendored upstream YAML from spell checking.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Installation preflight incorrectly reads bundled manifests from the customer workspace rather than the installed platform root, causing failures for existing workspaces or copies with outdated checksums.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Read bundled manifests from the platform root, not the workspace
cli/src/bootstrap.rs:462
options.root is the customer workspace passed through platform_host::install, not the installed platform root. Workspaces created before this change lack k8s/upstream, so installation fails even with a complete platform bundle; workspace copies with older checksums also fail after a manifest update. Pass the platform root separately and use it for this preflight and all subsequent bundled-manifest reads, while preserving the workspace root for editable manifests.
Review effort: Balanced
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include pinned Serving, Kourier, and cert-manager manifests in the platform archive and verify their checksums during packaging. Load them from the archive during installation so these steps do not depend on upstream download URLs.
This does not make container image downloads offline.
Fixes #20.