Skip to content

Bundle pinned bootstrap manifests in platform releases - #60

Open
jsturtevant wants to merge 3 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-20-20261114
Open

jsturtevant wants to merge 3 commits into
hyperlight-dev:mainfrom
jsturtevant:fix/issue-20-20261114

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

Include pinned Serving, Kourier, and cert-manager manifests in the platform archive and verify their checksums during packaging. Load them from the archive during installation so these steps do not depend on upstream download URLs.

This does not make container image downloads offline.

Fixes #20.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 00:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the change to bundle pinned bootstrap manifests with platform releases.

No open issues 🎉

What changed in this PR

This PR bundles pinned Knative Serving, Kourier, and cert-manager manifests in Lampyr platform releases, removing upstream manifest downloads from installation. Container image downloads remain separate and are not made offline.

Changes:

  • Package bootstrap manifests, source metadata, and controller pins, validating manifest checksums during packaging.
  • Load and verify bundled manifests during installation, with no download fallback.
  • Add packaging and bootstrap tests, asset-update documentation, and spell-check exclusions for vendored YAML.
File Description
scripts/​tests/​test_package_platform.py Updates archive expectations and verifies controller manifest preservation.
scripts/​tests/​test_bootstrap_manifests.py Tests bundled contents and rejection of missing, altered, or invalid assets.
scripts/​package-platform.py Validates and packages bootstrap manifests, source metadata, and controller pins.
k8s/​upstream/​sources.json Records upstream versions, source URLs, and SHA-256 checksums.
k8s/​upstream/​README.md Documents verification, update procedures, and offline limitations.
k8s/​upstream/​kourier.yaml Vendors the pinned upstream Kourier manifest.
cli/​src/​bootstrap.rs Replaces bootstrap downloads with verified local files and adds tests.
cli/​Justfile Adds bootstrap manifest tests to the packaging test recipe.
_typos.toml Excludes vendored upstream YAML from spell checking.

Review effort: Balanced

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 03:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change bundling pinned bootstrap manifests into platform releases.

No open issues 🎉

Review effort: Balanced

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 03:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Installation preflight incorrectly reads bundled manifests from the customer workspace rather than the installed platform root, causing failures for existing workspaces or copies with outdated checksums.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

High severity Read bundled manifests from the platform root, not the workspace

cli/​src/​bootstrap.rs:462

options.root is the customer workspace passed through platform_host::install, not the installed platform root. Workspaces created before this change lack k8s/upstream, so installation fails even with a complete platform bundle; workspace copies with older checksums also fail after a manifest update. Pass the platform root separately and use it for this preflight and all subsequent bundled-manifest reads, while preserving the workspace root for editable manifests.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle upstream bootstrap manifests in the platform release

2 participants