-
Notifications
You must be signed in to change notification settings - Fork 187
Automate removal of the ready-for-review label #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simongdavies
wants to merge
3
commits into
hyperlight-dev:main
Choose a base branch
from
simongdavies:feat/ready-for-review-label
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Ready-for-review label | ||
|
|
||
| # Caller workflow that wires this repository's pull-request events up to the | ||
| # reusable `manage-ready-for-review.yml` workflow, which removes the | ||
| # "ready-for-review" label once a PR is no longer awaiting review. | ||
| # | ||
| # `pull_request_target` (rather than `pull_request`) is required so that the job | ||
| # has a read/write token for pull requests opened from forks. This is safe here | ||
| # because the reusable workflow never checks out or executes pull-request code. | ||
| # | ||
| # The label logic lives in the organisation's `.github` repository so that every | ||
| # repository consumes the same engine. To roll this out to another repository, | ||
| # copy this file verbatim - the `uses:` reference below already points at the | ||
| # shared engine. | ||
| on: | ||
| pull_request_target: | ||
| types: [closed, converted_to_draft] | ||
| pull_request_review: | ||
| types: [submitted, dismissed] | ||
|
|
||
| # Serialise runs per pull request so that concurrent events (for example, a | ||
| # review submitted at the same moment the PR is closed) cannot race on the label. | ||
| concurrency: | ||
| group: ready-for-review-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: false | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| issues: write | ||
| jobs: | ||
| manage-label: | ||
| # Shared engine in the org-wide `.github` repository, pinned to a commit SHA | ||
| # (matching this repository's action-pinning convention). | ||
| uses: hyperlight-dev/.github/.github/workflows/manage-ready-for-review.yml@8eaae4229db908ea64fff06c31dbf5677611ce5e | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TIL
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TIL too :) https://docs.github.com/en/actions/how-tos/reuse-automations/share-with-your-organization nit: the comment above sounds very AI-generated |
||
| with: | ||
| pr-number: ${{ github.event.pull_request.number }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we try this with pull_request first? its only a write for issues and I don't think
pull_request_targetis needed for that:hyperlight/.github/workflows/RustNightly.yml
Lines 133 to 134 in 69c362b
pull_request also has types of closed/converted_to_draft https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree pull_request_target is a code smell. Although it might be better soon https://github.blog/changelog/2026-06-18-safer-pull_request_target-defaults-for-github-actions-checkout/