Repository navigation
Stop using cargo-component to build examples - #582
Open
syntactically wants to merge 1 commit into
Open
syntactically wants to merge 1 commit into
syntactically wants to merge 1 commit into
Conversation
Previously, we built the component examples using `cargo component`, which is a useful easy entry tool for building components. Unfortunately, `cargo component` has not had a release for some time, and the version of wit-bindgen that it depends on and uses for bindings generation is quite old. That wit-bindgen is no longer compatible with modern `wit-bindgen-rt` when generating bindings using p3 future/stream/async types. This commit replaces `cargo component build` with an explicit `wit_bindgen::generate` macro invocation (which, as a dependency of the example crates, is now in sync with the relevant `wit-bingen-rt` version) and `RUSTFLAGS="-C linker=wasm-component-ld" cargo build --target=wasm32-unknown-unknown`, which seems to work well enough. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we built the component examples using
cargo component, which is a useful easy entry tool for building components. Unfortunately,cargo componenthas not had a release for some time, and the version of wit-bindgen that it depends on and uses for bindings generation is quite old. That wit-bindgen is no longer compatible with modernwit-bindgen-rtwhen generating bindings using p3 future/stream/async types.This commit replaces
cargo component buildwith an explicitwit_bindgen::generatemacro invocation (which, as a dependency of the example crates, is now in sync with the relevantwit-bingen-rtversion) andRUSTFLAGS="-C linker=wasm-component-ld" cargo build --target=wasm32-unknown-unknown, which seems to work well enough.