Skip to content

Updates and fixes to allow using upstream targets - #581

Open
syntactically wants to merge 3 commits into
lm/aot-fixesfrom
lm/nightly-targets
Open

syntactically wants to merge 3 commits into
lm/aot-fixesfrom
lm/nightly-targets

Conversation

@syntactically

@syntactically syntactically commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

a5b50bc is needed to work correctly with new versions of target-lexicon, whether or not the new upstream targets are in use (see commit message). 3b5a573 is just a fix that is needed for recent rustc versions that we had not encountered due to being unable to build with recent(ish) rustc.

Together with hyperlight-dev/cargo-hyperlight#98, this allows building hyperlight-wasm with recent rustc nightlies and the upstream targets, and should enable building with rustc 1.101 as soon as it is released.

These versions include the changes necessary to use the
{aarch64,x86_64}-unknown-hyperlight targets

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
…ight

This is unconditional (done on all Rust versions), because
target-lexicon 0.13.6 parses even the
old ({aarch64,x86_64}-hyperlight-none) targets as having os =
"hyperlight" (that release adds hyperlight as a known OS, and the
general parsing logic in the crate does not allow an OS to be used as
a vendor).

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Previously, we were using the fact that wasm targets in Rust defaulted
to linking with `--allow-undefined`. Since that behaviour is
changing (https://blog.rust-lang.org/2026/04/04/changes-to-webassembly-targets-and-handling-undefined-symbols/),
we need to avoid relying on it.

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
@syntactically
syntactically added this pull request to stack #580 November 17, 2026 19:35
@syntactically syntactically added the kind/enhancement New feature or request label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant