Repository navigation
Updates and fixes to allow using upstream targets - #581
Open
syntactically wants to merge 3 commits into
Open
syntactically wants to merge 3 commits into
syntactically wants to merge 3 commits into
Conversation
These versions include the changes necessary to use the
{aarch64,x86_64}-unknown-hyperlight targets
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
…ight
This is unconditional (done on all Rust versions), because
target-lexicon 0.13.6 parses even the
old ({aarch64,x86_64}-hyperlight-none) targets as having os =
"hyperlight" (that release adds hyperlight as a known OS, and the
general parsing logic in the crate does not allow an OS to be used as
a vendor).
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Previously, we were using the fact that wasm targets in Rust defaulted to linking with `--allow-undefined`. Since that behaviour is changing (https://blog.rust-lang.org/2026/04/04/changes-to-webassembly-targets-and-handling-undefined-symbols/), we need to avoid relying on it. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a5b50bc is needed to work correctly with new versions of target-lexicon, whether or not the new upstream targets are in use (see commit message). 3b5a573 is just a fix that is needed for recent rustc versions that we had not encountered due to being unable to build with recent(ish) rustc.
Together with hyperlight-dev/cargo-hyperlight#98, this allows building hyperlight-wasm with recent rustc nightlies and the upstream targets, and should enable building with rustc 1.101 as soon as it is released.