Repository navigation
Various fixes/refactors to hyperlight_wasm_aot - #579
Open
syntactically wants to merge 2 commits into
Open
syntactically wants to merge 2 commits into
syntactically wants to merge 2 commits into
Conversation
`hyperlight-wasm-aot check-wasmtime-version` attempts to report the version of wasmtime that it was compiled with, in order to make it clear what version it is testing the provided file with. Previously, it used a `cargo metadata` invocation at runtime to attempt to obtain this information from the cargo crate dependency graph. Unfortunately, this only appeared to be working because we test running it in the normal cargo source tree: `cargo metadata` looks up the metadata of the directory in which the command is run at runtime. This commit replaces that cargo metadata invocation by one in a new hyperlight-wasm-aot build.rs, and compiles the relevant dependency versions directly into the executable. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Previously, both of the hyperlight-wasm-aot commands had completely divergent implementations for the wasmtime LTS and latest wasmtime cases, even though the core logic of both was precisely the same. This was probably mostly due to the annoyance of having to deal with the different types (e.g. `wasmtime::Config` vs `wasmtime_lts::Config`) throughout, making it difficult to provide abstractions which work on either version. This commit adds some macros to make that easier, and converges the code paths. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.