Repository navigation
Small fix to platform::dicachesync() - #578
Merged
Merged
Conversation
- Update Nightly rust toolchain to 1.100 - Use binary wasi-sdk since Docker is no longer used to build wasm modules - Support `RUSTUP_TOOLCHAIN` env var Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
The data/instruction-cache synchronising routine used to ensure cache coherence uses a specific protocol to communicate with the host because KVM does not support cache maintenance operations on readonly memslots (see hyperlight_host:src/hypervisor/virtual_machine/kvm/aarch64.rs), which includes, among other things, the requirement that PSTATE.Z should be unset whenever a cache maintenance instruction is encountered. The assembly stub used for cache maintenance successfully ensured this was true during its first `dc cvau` loop, but the condition to exit that loop set the Z flag, so it was incorrect on the first iteration of the `ic ivau` loop. This could lead to difficult-to-diagnose failures in KVM. This commit modifies the assembly stub to correctly reset the Z flag before beginning the `ic ivau`-loop. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
ludfjig
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit message for more detail on why this is needed.