Skip to content

fix: native module resolution breaks validation loop for ha:pdf #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simongdavies merged 2 commits into from
May 7, 2026
+13 −2
Merged

fix: native module resolution breaks validation loop for ha:pdf #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b94d34
fix: native module resolution breaks validation loop for ha:pdf
simongdavies May 7, 2026
44bbe0a
fix: address PR #111 review feedback — clarify comment wording
simongdavies May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/agent/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,13 @@ async function validateHandlerCode(
moduleJsons: newModuleJsons,
} = loadModuleFilesForValidator(validation.missingSources, pluginManager);

if (Object.keys(newSources).length === 0) {
if (
Object.keys(newSources).length === 0 &&
Object.keys(newModuleJsons).length === 0 &&
Object.keys(newDtsSources).length === 0
) {
// No new sources, module metadata, or type definitions found.
// Check if any specifiers are missing a ha: or host: prefix.
const unresolvable = validation.missingSources.filter(
(s) => !s.startsWith("ha:") && !s.startsWith("host:"),
);
Expand Down Expand Up @@ -1401,7 +1407,12 @@ const registerHandlerTool = defineTool("register_handler", {

// If we couldn't resolve ANY of the missing sources, generate helpful errors
// This happens when imports use wrong prefixes (e.g., "pptx" instead of "ha:pptx")
if (Object.keys(newSources).length === 0) {
// Native modules have module.json but no .js source — check all three.
if (
Object.keys(newSources).length === 0 &&
Object.keys(newModuleJsons).length === 0 &&
Object.keys(newDtsSources).length === 0
) {
Comment thread
simongdavies marked this conversation as resolved.
const unresolvable = validation.missingSources.filter(
(s) => !s.startsWith("ha:") && !s.startsWith("host:"),
);
Expand Down
Loading