Repository navigation
fix(uri): reject trailing path, query or fragment in Authority::from_static - #881
Closed
G26karthik wants to merge 1 commit into
Closed
G26karthik wants to merge 1 commit into
G26karthik wants to merge 1 commit into
Conversation
Author
|
Closing this so the issue author can take it. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #879
Authority::from_static("https://127.0.0.1")returns anAuthoritywithout panicking, while"https://127.0.0.1".parse::<Authority>()returns an error.Both call
validate_authority_bytes, which stops at the first/,?or#and returns that position as the end of the authority.create_authority(used byparse) compares that position to the input length and rejects the input if there is leftover data.from_staticmatched onOk(_)and threw the position away, so anything after the first/,?or#was accepted as part of the authority.from_staticnow only acceptsOk(end)whenend == src.len(), so it agrees withparseand is stillconst.Tests:
from_static_rejects_trailing_pathinsrc/uri/authority.rs. It fails on master (the call does not panic) and passes with this change.cargo testpasses (422 tests).cargo fmtis not installed here, so I formatted by hand.