Skip to content

refactor: Remove usage of float instruction #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanmonstar merged 1 commit into from
Mar 3, 2026
Merged

refactor: Remove usage of float instruction #823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/header/map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ const FORWARD_SHIFT_THRESHOLD: usize = 512;
// If growing the hash map would cause the load factor to drop bellow this
// threshold, then instead of growing, the headermap is switched to the red
// danger state and safe hashing is used instead.
const LOAD_FACTOR_THRESHOLD: f32 = 0.2;
const LOAD_FACTOR_THRESHOLD: usize = 5;

// Macro used to iterate the hash table starting at a given point, looping when
// the end is hit.
Expand Down Expand Up @@ -1739,9 +1739,10 @@ impl<T> HeaderMap<T> {
let len = self.entries.len();

if self.danger.is_yellow() {
let load_factor = self.entries.len() as f32 / self.indices.len() as f32;

if load_factor >= LOAD_FACTOR_THRESHOLD {
// Overflow is not a concern here: entries.len() is bounded by
// MAX_SIZE (2^15) and LOAD_FACTOR_THRESHOLD is 5, so the product
// fits comfortably within a usize.
if self.entries.len() * LOAD_FACTOR_THRESHOLD >= self.indices.len() {
// Transition back to green danger level
self.danger.set_green();

Expand Down