Skip to content

fix: key the linux tarball upload on the tarball #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catinspace-au merged 1 commit into from
Oct 14, 2026
Merged

fix: key the linux tarball upload on the tarball #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,11 @@ jobs:
aws configure set aws_access_key_id "$R2_ACCESS_KEY_ID"
aws configure set aws_secret_access_key "$R2_SECRET_ACCESS_KEY"
aws configure set region auto
# Versioned paths are write-once: the formula and install.sh pin these
# bytes by sha256. The .sha256 goes up last, so it marks a full upload.
marker="macbash/${TAG}/macbash-linux-${ARCH}.sha256"
# Versioned paths are write-once: the formula pins the tarball by sha256.
# hyperi-ci has already written <tag>/macbash-linux-<arch>.sha256 for the
# raw binary and this job adds the tarball line, so the tarball, which
# only this job writes, is the marker and goes up last.
marker="macbash/${TAG}/macbash-linux-${ARCH}.tar.gz"
published=$(aws s3api list-objects-v2 --endpoint-url "$R2_ENDPOINT" --bucket "$R2_BUCKET" \
--prefix "$marker" --query "length(Contents || \`[]\`)" --output text)
case "$published" in
Expand All @@ -164,10 +166,10 @@ jobs:
*) echo "::error::unexpected R2 listing for ${marker}: ${published}"; exit 1 ;;
esac
for dest in "s3://${R2_BUCKET}/macbash/${TAG}/" "s3://${R2_BUCKET}/macbash/latest/"; do
aws s3 cp --endpoint-url "$R2_ENDPOINT" \
"dist/macbash-linux-${ARCH}.tar.gz" "$dest"
aws s3 cp --endpoint-url "$R2_ENDPOINT" \
"dist/macbash-linux-${ARCH}.sha256" "$dest"
aws s3 cp --endpoint-url "$R2_ENDPOINT" \
"dist/macbash-linux-${ARCH}.tar.gz" "$dest"
done

deb-rpm:
Expand Down
2 changes: 1 addition & 1 deletion docs/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ A Cross-build that refuses a run concludes `skipped`, and Package only follows a

## Versioned paths are write-once

The Homebrew formula and `install.sh` pin the bytes at `/<tag>/` by SHA-256, so nothing overwrites them. Each upload checks R2 for the file it writes last (its `.sha256`, or `<tag>/install.sh` for the manifests), and when that exists it writes nothing, `latest/` included. The root `install.sh` is the exception: it is re-rendered from the default branch on every Package run. A re-run, or a CI run that published nothing new, therefore leaves the release alone. Replacing a published artefact means deleting it from R2 by hand first.
The Homebrew formula and `install.sh` pin the bytes at `/<tag>/` by SHA-256, so nothing overwrites them. Each upload checks R2 for a file only it writes, uploaded last, and when that exists it writes nothing, `latest/` included. That file is the `.sha256` for the darwin, windows and package uploads, the tarball for the linux tarballs (hyperi-ci writes the linux `.sha256` first), and `<tag>/install.sh` for the manifests. The root `install.sh` is the exception: it is re-rendered from the default branch on every Package run. A re-run, or a CI run that published nothing new, therefore leaves the release alone. Replacing a published artefact means deleting it from R2 by hand first.

The binaries carry no build clock either: `build.rs` stamps `SOURCE_DATE_EPOCH` when it is set, else the commit time of HEAD.

Expand Down
Loading