chore(test): delete unused testdata and redundant comment lines#2
chore(test): delete unused testdata and redundant comment lines#2hyperfinitism merged 2 commits intomainfrom
Conversation
Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request removes documentation comments from the parses_builtin_tcb_policy test in tests/testdata.rs. The reviewer recommends retaining these comments as they provide critical context regarding the test's design and explain why a dynamic line count is used instead of a hardcoded assertion, which helps prevent future maintenance issues.
I am having trouble creating individual review comments. Click here to see my feedback.
tests/testdata.rs (30-33)
The removed comments provide valuable context regarding the design of this test. Specifically, explaining that the rule count 'has wandered across kernel versions' justifies why the test uses a dynamic line count rather than a hardcoded assertion. Removing this information makes the test's rationale less transparent for future maintainers who might otherwise attempt to 'simplify' the test with a fragile fixed count.
Changes
pcr10s-serialized.dattestdata.rs