Skip to content

chore(test): delete unused testdata and redundant comment lines#2

Merged
hyperfinitism merged 2 commits intomainfrom
chore/test-tweak
Apr 20, 2026
Merged

chore(test): delete unused testdata and redundant comment lines#2
hyperfinitism merged 2 commits intomainfrom
chore/test-tweak

Conversation

@hyperfinitism
Copy link
Copy Markdown
Owner

Changes

  • Delete unused testdata pcr10s-serialized.dat
  • Remove redundant comment lines in testdata.rs

Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
@hyperfinitism hyperfinitism self-assigned this Apr 20, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes documentation comments from the parses_builtin_tcb_policy test in tests/testdata.rs. The reviewer recommends retaining these comments as they provide critical context regarding the test's design and explain why a dynamic line count is used instead of a hardcoded assertion, which helps prevent future maintenance issues.

I am having trouble creating individual review comments. Click here to see my feedback.

tests/testdata.rs (30-33)

medium

The removed comments provide valuable context regarding the design of this test. Specifically, explaining that the rule count 'has wandered across kernel versions' justifies why the test uses a dynamic line count rather than a hardcoded assertion. Removing this information makes the test's rationale less transparent for future maintainers who might otherwise attempt to 'simplify' the test with a fragile fixed count.

@hyperfinitism hyperfinitism merged commit 0cc9d5e into main Apr 20, 2026
50 checks passed
@hyperfinitism hyperfinitism deleted the chore/test-tweak branch April 20, 2026 12:44
@hyperfinitism hyperfinitism added the refactor Refactoring without functional changes label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring without functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant