Skip to content

chore(ci): exclude Storybook stories from PR tiering #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brandon-pereira wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

chore(ci): exclude Storybook stories from PR tiering #2989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/scripts/__tests__/pr-triage-classify.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ describe('isTestFile', () => {
assert.ok(isTestFile('packages/app/tests/e2e/navigation.ts'));
});

it('matches Storybook story files', () => {
assert.ok(isTestFile('packages/app/src/components/Alert.stories.tsx'));
assert.ok(isTestFile('packages/app/src/HDXMultiSeriesTable.stories.ts'));
});

it('matches the E2E-only ClickHouse fixture, but not its shipped siblings', () => {
assert.ok(isTestFile('docker/clickhouse/local/init-db-e2e.sh'));
// config.xml / users.xml are copied into the all-in-one image — production config
Expand Down
3 changes: 3 additions & 0 deletions .github/scripts/pr-triage-classify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ const TEST_FILE_PATTERNS = [
/\/__tests__\//,
/\.test\.[jt]sx?$/,
/\.spec\.[jt]sx?$/,
// Storybook stories are dev-only fixtures — never shipped in the app bundle,
// so they carry no production risk and should not drive the tier.
/\.stories\.[jt]sx?$/,
/^packages\/app\/tests\//,
// E2E-only ClickHouse fixture, mounted solely by packages/app/tests/e2e. Its
// siblings (config.xml, users.xml) ship in the image and stay critical.
Expand Down
Loading